* [net-next PATCH] net: phy: marvell: Fix inconsistent indenting in led_blink_set
@ 2023-04-23 17:28 Christian Marangi
2023-04-24 0:37 ` Andrew Lunn
2023-04-25 2:10 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Christian Marangi @ 2023-04-23 17:28 UTC (permalink / raw)
To: Andrew Lunn, Heiner Kallweit, Russell King, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Christian Marangi,
Florian Fainelli, netdev, linux-kernel
Cc: kernel test robot
Fix inconsistent indeinting in m88e1318_led_blink_set reported by kernel
test robot, probably done by the presence of an if condition dropped in
later revision of the same code.
Cc: Andrew Lunn <andrew@lunn.ch>
Reported-by: kernel test robot <lkp@intel.com>
Link: https://lore.kernel.org/oe-kbuild-all/202304240007.0VEX8QYG-lkp@intel.com/
Fixes: 46969f66e928 ("net: phy: marvell: Implement led_blink_set()")
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
---
drivers/net/phy/marvell.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c
index cd5d0ed9c5e5..43b6cb725551 100644
--- a/drivers/net/phy/marvell.c
+++ b/drivers/net/phy/marvell.c
@@ -2880,10 +2880,10 @@ static int m88e1318_led_blink_set(struct phy_device *phydev, u8 index,
case 1:
case 2:
reg &= ~(0xf << (4 * index));
- reg |= MII_88E1318S_PHY_LED_FUNC_BLINK << (4 * index);
- /* Reset default is 84ms */
- *delay_on = 84 / 2;
- *delay_off = 84 / 2;
+ reg |= MII_88E1318S_PHY_LED_FUNC_BLINK << (4 * index);
+ /* Reset default is 84ms */
+ *delay_on = 84 / 2;
+ *delay_off = 84 / 2;
break;
default:
return -EINVAL;
--
2.39.2
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [net-next PATCH] net: phy: marvell: Fix inconsistent indenting in led_blink_set
2023-04-23 17:28 [net-next PATCH] net: phy: marvell: Fix inconsistent indenting in led_blink_set Christian Marangi
@ 2023-04-24 0:37 ` Andrew Lunn
2023-04-25 2:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2023-04-24 0:37 UTC (permalink / raw)
To: Christian Marangi
Cc: Heiner Kallweit, Russell King, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Florian Fainelli, netdev,
linux-kernel, kernel test robot
On Sun, Apr 23, 2023 at 07:28:00PM +0200, Christian Marangi wrote:
> Fix inconsistent indeinting in m88e1318_led_blink_set reported by kernel
> test robot, probably done by the presence of an if condition dropped in
> later revision of the same code.
>
> Cc: Andrew Lunn <andrew@lunn.ch>
> Reported-by: kernel test robot <lkp@intel.com>
> Link: https://lore.kernel.org/oe-kbuild-all/202304240007.0VEX8QYG-lkp@intel.com/
> Fixes: 46969f66e928 ("net: phy: marvell: Implement led_blink_set()")
> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [net-next PATCH] net: phy: marvell: Fix inconsistent indenting in led_blink_set
2023-04-23 17:28 [net-next PATCH] net: phy: marvell: Fix inconsistent indenting in led_blink_set Christian Marangi
2023-04-24 0:37 ` Andrew Lunn
@ 2023-04-25 2:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-04-25 2:10 UTC (permalink / raw)
To: Ansuel Smith
Cc: andrew, hkallweit1, linux, davem, edumazet, kuba, pabeni,
f.fainelli, netdev, linux-kernel, lkp
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Sun, 23 Apr 2023 19:28:00 +0200 you wrote:
> Fix inconsistent indeinting in m88e1318_led_blink_set reported by kernel
> test robot, probably done by the presence of an if condition dropped in
> later revision of the same code.
>
> Cc: Andrew Lunn <andrew@lunn.ch>
> Reported-by: kernel test robot <lkp@intel.com>
> Link: https://lore.kernel.org/oe-kbuild-all/202304240007.0VEX8QYG-lkp@intel.com/
> Fixes: 46969f66e928 ("net: phy: marvell: Implement led_blink_set()")
> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
>
> [...]
Here is the summary with links:
- [net-next] net: phy: marvell: Fix inconsistent indenting in led_blink_set
https://git.kernel.org/netdev/net-next/c/4774ad841bef
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-04-25 2:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-23 17:28 [net-next PATCH] net: phy: marvell: Fix inconsistent indenting in led_blink_set Christian Marangi
2023-04-24 0:37 ` Andrew Lunn
2023-04-25 2:10 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®