* [PATCH] clocksource: stm32-lp: drop of_match_ptr for ID table
@ 2023-03-11 17:38 Krzysztof Kozlowski
2023-04-06 13:56 ` Daniel Lezcano
2023-04-26 9:12 ` [tip: timers/core] clocksource/drivers/stm32-lp: Drop " tip-bot2 for Krzysztof Kozlowski
0 siblings, 2 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-11 17:38 UTC (permalink / raw)
To: Daniel Lezcano, Thomas Gleixner, Maxime Coquelin,
Alexandre Torgue, linux-kernel, linux-stm32, linux-arm-kernel
Cc: Krzysztof Kozlowski
The driver can match only via the DT table so the table should be always
used and the of_match_ptr does not have any sense (this also allows ACPI
matching via PRP0001, even though it might not be relevant here).
drivers/clocksource/timer-stm32-lp.c:203:34: error: ‘stm32_clkevent_lp_of_match’ defined but not used [-Werror=unused-const-variable=]
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
drivers/clocksource/timer-stm32-lp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clocksource/timer-stm32-lp.c b/drivers/clocksource/timer-stm32-lp.c
index db2841d0beb8..646bb90f5e92 100644
--- a/drivers/clocksource/timer-stm32-lp.c
+++ b/drivers/clocksource/timer-stm32-lp.c
@@ -211,7 +211,7 @@ static struct platform_driver stm32_clkevent_lp_driver = {
.remove = stm32_clkevent_lp_remove,
.driver = {
.name = "stm32-lptimer-timer",
- .of_match_table = of_match_ptr(stm32_clkevent_lp_of_match),
+ .of_match_table = stm32_clkevent_lp_of_match,
},
};
module_platform_driver(stm32_clkevent_lp_driver);
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] clocksource: stm32-lp: drop of_match_ptr for ID table
2023-03-11 17:38 [PATCH] clocksource: stm32-lp: drop of_match_ptr for ID table Krzysztof Kozlowski
@ 2023-04-06 13:56 ` Daniel Lezcano
2023-04-26 9:12 ` [tip: timers/core] clocksource/drivers/stm32-lp: Drop " tip-bot2 for Krzysztof Kozlowski
1 sibling, 0 replies; 3+ messages in thread
From: Daniel Lezcano @ 2023-04-06 13:56 UTC (permalink / raw)
To: Krzysztof Kozlowski, Thomas Gleixner, Maxime Coquelin,
Alexandre Torgue, linux-kernel, linux-stm32, linux-arm-kernel
On 11/03/2023 18:38, Krzysztof Kozlowski wrote:
> The driver can match only via the DT table so the table should be always
> used and the of_match_ptr does not have any sense (this also allows ACPI
> matching via PRP0001, even though it might not be relevant here).
>
> drivers/clocksource/timer-stm32-lp.c:203:34: error: ‘stm32_clkevent_lp_of_match’ defined but not used [-Werror=unused-const-variable=]
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Applied, thanks
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 3+ messages in thread
* [tip: timers/core] clocksource/drivers/stm32-lp: Drop of_match_ptr for ID table
2023-03-11 17:38 [PATCH] clocksource: stm32-lp: drop of_match_ptr for ID table Krzysztof Kozlowski
2023-04-06 13:56 ` Daniel Lezcano
@ 2023-04-26 9:12 ` tip-bot2 for Krzysztof Kozlowski
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot2 for Krzysztof Kozlowski @ 2023-04-26 9:12 UTC (permalink / raw)
To: linux-tip-commits; +Cc: Krzysztof Kozlowski, Daniel Lezcano, x86, linux-kernel
The following commit has been merged into the timers/core branch of tip:
Commit-ID: b6f228e800ccf285906bb1c4c366ce3848a5443e
Gitweb: https://git.kernel.org/tip/b6f228e800ccf285906bb1c4c366ce3848a5443e
Author: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
AuthorDate: Sat, 11 Mar 2023 18:38:03 +01:00
Committer: Daniel Lezcano <daniel.lezcano@linaro.org>
CommitterDate: Mon, 24 Apr 2023 16:56:13 +02:00
clocksource/drivers/stm32-lp: Drop of_match_ptr for ID table
The driver can match only via the DT table so the table should be always
used and the of_match_ptr does not have any sense (this also allows ACPI
matching via PRP0001, even though it might not be relevant here).
drivers/clocksource/timer-stm32-lp.c:203:34: error: ‘stm32_clkevent_lp_of_match’ defined but not used [-Werror=unused-const-variable=]
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20230311173803.263446-1-krzysztof.kozlowski@linaro.org
---
drivers/clocksource/timer-stm32-lp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clocksource/timer-stm32-lp.c b/drivers/clocksource/timer-stm32-lp.c
index 0adf22d..d14a175 100644
--- a/drivers/clocksource/timer-stm32-lp.c
+++ b/drivers/clocksource/timer-stm32-lp.c
@@ -205,7 +205,7 @@ static struct platform_driver stm32_clkevent_lp_driver = {
.probe = stm32_clkevent_lp_probe,
.driver = {
.name = "stm32-lptimer-timer",
- .of_match_table = of_match_ptr(stm32_clkevent_lp_of_match),
+ .of_match_table = stm32_clkevent_lp_of_match,
.suppress_bind_attrs = true,
},
};
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-04-26 9:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-11 17:38 [PATCH] clocksource: stm32-lp: drop of_match_ptr for ID table Krzysztof Kozlowski
2023-04-06 13:56 ` Daniel Lezcano
2023-04-26 9:12 ` [tip: timers/core] clocksource/drivers/stm32-lp: Drop " tip-bot2 for Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®