From: "tip-bot2 for Uwe Kleine-König" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: u.kleine-koenig@pengutronix.de,
Daniel Lezcano <daniel.lezcano@linaro.org>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: timers/core] clocksource/drivers/timer-ti-dm: Improve error message in .remove
Date: Wed, 26 Apr 2023 09:12:32 -0000 [thread overview]
Message-ID: <168250035216.404.14983446522756531530.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20230313075430.2730803-4-u.kleine-koenig@pengutronix.de>
The following commit has been merged into the timers/core branch of tip:
Commit-ID: 8efcbe927c5129d5b2528bbb40034c7dde87a6b6
Gitweb: https://git.kernel.org/tip/8efcbe927c5129d5b2528bbb40034c7dde87a6b6
Author: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
AuthorDate: Mon, 13 Mar 2023 08:54:28 +01:00
Committer: Daniel Lezcano <daniel.lezcano@linaro.org>
CommitterDate: Mon, 24 Apr 2023 16:56:13 +02:00
clocksource/drivers/timer-ti-dm: Improve error message in .remove
If a platform driver's remove callback returns an error code, the driver
core emits a generic (and thus little helpful) error message.
Instead emit a more specifc error message about the actual error and
return zero to suppress the core's message.
Note that returning zero has no side effects apart from not emitting
said error message. This prepares converting platform driver's remove
message to return void.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20230313075430.2730803-4-u.kleine-koenig@pengutronix.de
---
drivers/clocksource/timer-ti-dm.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/clocksource/timer-ti-dm.c b/drivers/clocksource/timer-ti-dm.c
index b24b903..098562b 100644
--- a/drivers/clocksource/timer-ti-dm.c
+++ b/drivers/clocksource/timer-ti-dm.c
@@ -1197,7 +1197,10 @@ static int omap_dm_timer_remove(struct platform_device *pdev)
pm_runtime_disable(&pdev->dev);
- return ret;
+ if (ret)
+ dev_err(&pdev->dev, "Unable to determine timer entry in list of drivers on remove\n");
+
+ return 0;
}
static const struct omap_dm_timer_ops dmtimer_ops = {
next prev parent reply other threads:[~2023-04-26 9:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-13 7:54 [PATCH 0/5] clocksource: Convert to platform remove callback returning void Uwe Kleine-König
2023-03-13 7:54 ` [PATCH 1/5] clocksource: sh_mtu2: Mark driver as non-removable Uwe Kleine-König
2023-04-26 9:12 ` [tip: timers/core] clocksource/drivers/sh_mtu2: " tip-bot2 for Uwe Kleine-König
2023-03-13 7:54 ` [PATCH 2/5] clocksource: timer-stm32-lp: " Uwe Kleine-König
2023-03-13 9:43 ` Uwe Kleine-König
2023-03-13 13:10 ` kernel test robot
2023-04-26 9:12 ` [tip: timers/core] clocksource/drivers/timer-stm32-lp: " tip-bot2 for Uwe Kleine-König
2023-03-13 7:54 ` [PATCH 3/5] clocksource: timer-ti-dm: Improve error message in .remove Uwe Kleine-König
2023-04-26 9:12 ` tip-bot2 for Uwe Kleine-König [this message]
2023-03-13 7:54 ` [PATCH 4/5] clocksource: timer-tegra186: Convert to platform remove callback returning void Uwe Kleine-König
2023-04-26 9:12 ` [tip: timers/core] clocksource/drivers/timer-tegra186: " tip-bot2 for Uwe Kleine-König
2023-03-13 7:54 ` [PATCH 5/5] clocksource: timer-ti-dm: " Uwe Kleine-König
2023-04-26 9:12 ` [tip: timers/core] clocksource/drivers/timer-ti-dm: " tip-bot2 for Uwe Kleine-König
2023-04-06 13:54 ` [PATCH 0/5] clocksource: " Daniel Lezcano
2023-04-06 14:07 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168250035216.404.14983446522756531530.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®