mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "tip-bot2 for Uwe Kleine-König" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: u.kleine-koenig@pengutronix.de,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: timers/core] clocksource/drivers/sh_mtu2: Mark driver as non-removable
Date: Wed, 26 Apr 2023 09:12:32 -0000	[thread overview]
Message-ID: <168250035266.404.6498503358644410758.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20230313075430.2730803-2-u.kleine-koenig@pengutronix.de>

The following commit has been merged into the timers/core branch of tip:

Commit-ID:     78012e3880a62e0eb130a0b5a10230162ad42a06
Gitweb:        https://git.kernel.org/tip/78012e3880a62e0eb130a0b5a10230162ad42a06
Author:        Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
AuthorDate:    Mon, 13 Mar 2023 08:54:26 +01:00
Committer:     Daniel Lezcano <daniel.lezcano@linaro.org>
CommitterDate: Mon, 24 Apr 2023 16:56:13 +02:00

clocksource/drivers/sh_mtu2: Mark driver as non-removable

The comment in the remove callback suggests that the driver is not
supposed to be unbound. However returning an error code in the remove
callback doesn't accomplish that. Instead set the suppress_bind_attrs
property (which makes it impossible to unbind the driver via sysfs).
The only remaining way to unbind a sh_tmu2 device would be module
unloading, but that doesn't apply here, as the driver cannot be built as
a module.

Also drop the useless remove callback.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20230313075430.2730803-2-u.kleine-koenig@pengutronix.de
---
 drivers/clocksource/sh_mtu2.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/clocksource/sh_mtu2.c b/drivers/clocksource/sh_mtu2.c
index 169a1fc..6bd2d02 100644
--- a/drivers/clocksource/sh_mtu2.c
+++ b/drivers/clocksource/sh_mtu2.c
@@ -484,11 +484,6 @@ static int sh_mtu2_probe(struct platform_device *pdev)
 	return 0;
 }
 
-static int sh_mtu2_remove(struct platform_device *pdev)
-{
-	return -EBUSY; /* cannot unregister clockevent */
-}
-
 static const struct platform_device_id sh_mtu2_id_table[] = {
 	{ "sh-mtu2", 0 },
 	{ },
@@ -503,10 +498,10 @@ MODULE_DEVICE_TABLE(of, sh_mtu2_of_table);
 
 static struct platform_driver sh_mtu2_device_driver = {
 	.probe		= sh_mtu2_probe,
-	.remove		= sh_mtu2_remove,
 	.driver		= {
 		.name	= "sh_mtu2",
 		.of_match_table = of_match_ptr(sh_mtu2_of_table),
+		.suppress_bind_attrs = true,
 	},
 	.id_table	= sh_mtu2_id_table,
 };

  reply	other threads:[~2023-04-26  9:14 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-13  7:54 [PATCH 0/5] clocksource: Convert to platform remove callback returning void Uwe Kleine-König
2023-03-13  7:54 ` [PATCH 1/5] clocksource: sh_mtu2: Mark driver as non-removable Uwe Kleine-König
2023-04-26  9:12   ` tip-bot2 for Uwe Kleine-König [this message]
2023-03-13  7:54 ` [PATCH 2/5] clocksource: timer-stm32-lp: " Uwe Kleine-König
2023-03-13  9:43   ` Uwe Kleine-König
2023-03-13 13:10   ` kernel test robot
2023-04-26  9:12   ` [tip: timers/core] clocksource/drivers/timer-stm32-lp: " tip-bot2 for Uwe Kleine-König
2023-03-13  7:54 ` [PATCH 3/5] clocksource: timer-ti-dm: Improve error message in .remove Uwe Kleine-König
2023-04-26  9:12   ` [tip: timers/core] clocksource/drivers/timer-ti-dm: " tip-bot2 for Uwe Kleine-König
2023-03-13  7:54 ` [PATCH 4/5] clocksource: timer-tegra186: Convert to platform remove callback returning void Uwe Kleine-König
2023-04-26  9:12   ` [tip: timers/core] clocksource/drivers/timer-tegra186: " tip-bot2 for Uwe Kleine-König
2023-03-13  7:54 ` [PATCH 5/5] clocksource: timer-ti-dm: " Uwe Kleine-König
2023-04-26  9:12   ` [tip: timers/core] clocksource/drivers/timer-ti-dm: " tip-bot2 for Uwe Kleine-König
2023-04-06 13:54 ` [PATCH 0/5] clocksource: " Daniel Lezcano
2023-04-06 14:07   ` Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=168250035266.404.6498503358644410758.tip-bot2@tip-bot2 \
    --to=tip-bot2@linutronix.de \
    --cc=daniel.lezcano@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®