From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: matthias.bgg@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com,
frank-w@public-files.de
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
Matthias Brugger <mbrugger@suse.com>
Subject: Re: [PATCH] arm64: dts: mediatek: mt7986: Add SoC compatible
Date: Mon, 14 Nov 2022 12:02:30 +0100 [thread overview]
Message-ID: <1683603c-8486-b7a7-e9d7-bddd28c1cd8c@collabora.com> (raw)
In-Reply-To: <20221111113635.4603-1-matthias.bgg@kernel.org>
Il 11/11/22 12:36, matthias.bgg@kernel.org ha scritto:
> From: Matthias Brugger <mbrugger@suse.com>
>
> Missing SoC compatible in the board file causes dt bindings check.
>
> Signed-off-by: Matthias Brugger <mbrugger@suse.com>
> ---
> arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts | 2 +-
> arch/arm64/boot/dts/mediatek/mt7986a.dtsi | 2 ++
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts b/arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts
> index afe37b702eef9..0e3b603159477 100644
> --- a/arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts
> +++ b/arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts
> @@ -9,7 +9,7 @@
>
> / {
> model = "MediaTek MT7986a RFB";
> - compatible = "mediatek,mt7986a-rfb";
> + compatible = "mediatek,mt7986a-rfb", "mediatek,mt7986a";
>
> aliases {
> serial0 = &uart0;
> diff --git a/arch/arm64/boot/dts/mediatek/mt7986a.dtsi b/arch/arm64/boot/dts/mediatek/mt7986a.dtsi
> index 72e0d9722e07a..1191ecf345a7d 100644
> --- a/arch/arm64/boot/dts/mediatek/mt7986a.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt7986a.dtsi
> @@ -14,6 +14,8 @@ / {
> #address-cells = <2>;
> #size-cells = <2>;
>
> + compatible = "mediatek,mt7986a";
> +
It's DTS that shall declare the machine compatible and it's expected that they
all declare their own, so please drop this one.
Also, while at it, the same should happen with mt7986b-rfb.dts: can you fix that
one too?
compatible = "mediatek,mt7986b-rfb", "mediatek,mt7986b";
Cheers,
Angelo
next prev parent reply other threads:[~2022-11-14 11:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-11 11:36 matthias.bgg
2022-11-14 11:02 ` AngeloGioacchino Del Regno [this message]
2022-11-14 11:26 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1683603c-8486-b7a7-e9d7-bddd28c1cd8c@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=frank-w@public-files.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=matthias.bgg@kernel.org \
--cc=mbrugger@suse.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®