Re: [PATCH] arm64: dts: mediatek: mt7986: Add SoC compatible

[Matthias Brugger <mbrugger@suse.com>]

On 14/11/2022 12:02, AngeloGioacchino Del Regno wrote:
> Il 11/11/22 12:36, matthias.bgg@kernel.org ha scritto:
>> From: Matthias Brugger <mbrugger@suse.com>
>>
>> Missing SoC compatible in the board file causes dt bindings check.
>>
>> Signed-off-by: Matthias Brugger <mbrugger@suse.com>
>> ---
>>   arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts | 2 +-
>>   arch/arm64/boot/dts/mediatek/mt7986a.dtsi    | 2 ++
>>   2 files changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts 
>> b/arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts
>> index afe37b702eef9..0e3b603159477 100644
>> --- a/arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts
>> +++ b/arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts
>> @@ -9,7 +9,7 @@
>>   / {
>>       model = "MediaTek MT7986a RFB";
>> -    compatible = "mediatek,mt7986a-rfb";
>> +    compatible = "mediatek,mt7986a-rfb", "mediatek,mt7986a";
>>       aliases {
>>           serial0 = &uart0;
>> diff --git a/arch/arm64/boot/dts/mediatek/mt7986a.dtsi 
>> b/arch/arm64/boot/dts/mediatek/mt7986a.dtsi
>> index 72e0d9722e07a..1191ecf345a7d 100644
>> --- a/arch/arm64/boot/dts/mediatek/mt7986a.dtsi
>> +++ b/arch/arm64/boot/dts/mediatek/mt7986a.dtsi
>> @@ -14,6 +14,8 @@ / {
>>       #address-cells = <2>;
>>       #size-cells = <2>;
>> +    compatible = "mediatek,mt7986a";
>> +
> 
> It's DTS that shall declare the machine compatible and it's expected that they
> all declare their own, so please drop this one.

SoC compatible should have a the compatible for it's SoC. But for style reasons 
it should be the first of the block, I'll fix that.

> 
> Also, while at it, the same should happen with mt7986b-rfb.dts: can you fix that
> one too?
> 
>      compatible = "mediatek,mt7986b-rfb", "mediatek,mt7986b";

Will do.

Thanks,
Matthias

> 
> Cheers,
> Angelo
> 
>