From: Mark Brown <broonie@kernel.org>
To: paul@crapouillou.net, Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
Cc: lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com,
linux-mips@vger.kernel.org, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] ASoC: jz4740-i2s: Make I2S divider calculations more robust
Date: Thu, 11 May 2023 14:36:25 +0900 [thread overview]
Message-ID: <168378338586.323079.4615747574575722094.b4-ty@kernel.org> (raw)
In-Reply-To: <20230509125134.208129-1-aidanmacdonald.0x0@gmail.com>
On Tue, 09 May 2023 13:51:34 +0100, Aidan MacDonald wrote:
> When the CPU supplies bit/frame clocks, the system clock (clk_i2s)
> is divided to produce the bit clock. This is a simple 1/N divider
> with a fairly limited range, so for a given system clock frequency
> only a few sample rates can be produced. Usually a wider range of
> sample rates is supported by varying the system clock frequency.
>
> The old calculation method was not very robust and could easily
> produce the wrong clock rate, especially with non-standard rates.
> For example, if the system clock is 1.99x the target bit clock
> rate, the divider would be calculated as 1 instead of the more
> accurate 2.
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: jz4740-i2s: Make I2S divider calculations more robust
commit: ad721bc919edfd8b4b06977458a412011e2f0c50
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
prev parent reply other threads:[~2023-05-11 5:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-09 12:51 Aidan MacDonald
2023-05-11 5:36 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168378338586.323079.4615747574575722094.b4-ty@kernel.org \
--to=broonie@kernel.org \
--cc=aidanmacdonald.0x0@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=paul@crapouillou.net \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®