* [PATCH v2] Bluetooth: btqca: use le32_to_cpu for ver.soc_id
@ 2023-05-19 10:43 Min-Hua Chen
2023-05-19 20:20 ` patchwork-bot+bluetooth
0 siblings, 1 reply; 2+ messages in thread
From: Min-Hua Chen @ 2023-05-19 10:43 UTC (permalink / raw)
To: Marcel Holtmann, Johan Hedberg, Luiz Augusto von Dentz
Cc: Min-Hua Chen, linux-bluetooth, linux-kernel
Use le32_to_cpu for ver.soc_id to fix the following
sparse warning.
drivers/bluetooth/btqca.c:640:24: sparse: warning: restricted
__le32 degrades to integer
Signed-off-by: Min-Hua Chen <minhuadotchen@gmail.com>
---
Change since v1:
fix the line length > 80 error reported by bluez.test.bot
---
drivers/bluetooth/btqca.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c
index fd0941fe8608..e7e58a956d15 100644
--- a/drivers/bluetooth/btqca.c
+++ b/drivers/bluetooth/btqca.c
@@ -637,7 +637,7 @@ int qca_uart_setup(struct hci_dev *hdev, uint8_t baudrate,
snprintf(config.fwname, sizeof(config.fwname),
"qca/%s", firmware_name);
else if (qca_is_wcn399x(soc_type)) {
- if (ver.soc_id == QCA_WCN3991_SOC_ID) {
+ if (le32_to_cpu(ver.soc_id) == QCA_WCN3991_SOC_ID) {
snprintf(config.fwname, sizeof(config.fwname),
"qca/crnv%02xu.bin", rom_ver);
} else {
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2] Bluetooth: btqca: use le32_to_cpu for ver.soc_id
2023-05-19 10:43 [PATCH v2] Bluetooth: btqca: use le32_to_cpu for ver.soc_id Min-Hua Chen
@ 2023-05-19 20:20 ` patchwork-bot+bluetooth
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+bluetooth @ 2023-05-19 20:20 UTC (permalink / raw)
To: Min-Hua Chen
Cc: marcel, johan.hedberg, luiz.dentz, linux-bluetooth, linux-kernel
Hello:
This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:
On Fri, 19 May 2023 18:43:23 +0800 you wrote:
> Use le32_to_cpu for ver.soc_id to fix the following
> sparse warning.
>
> drivers/bluetooth/btqca.c:640:24: sparse: warning: restricted
> __le32 degrades to integer
>
> Signed-off-by: Min-Hua Chen <minhuadotchen@gmail.com>
>
> [...]
Here is the summary with links:
- [v2] Bluetooth: btqca: use le32_to_cpu for ver.soc_id
https://git.kernel.org/bluetooth/bluetooth-next/c/0f1e103dc579
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-05-19 20:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-19 10:43 [PATCH v2] Bluetooth: btqca: use le32_to_cpu for ver.soc_id Min-Hua Chen
2023-05-19 20:20 ` patchwork-bot+bluetooth
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome