* [PATCH net-next v1 1/1] dsa: lan9303: Remove stray gpiod_unexport() call
@ 2023-05-28 14:25 Andy Shevchenko
2023-05-29 15:00 ` Andrew Lunn
2023-05-30 11:20 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Andy Shevchenko @ 2023-05-28 14:25 UTC (permalink / raw)
To: Jerry Ray, David S. Miller, netdev, linux-kernel
Cc: Andrew Lunn, Florian Fainelli, Vladimir Oltean, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Andy Shevchenko
There is no gpiod_export() and gpiod_unexport() looks pretty much stray.
The gpiod_export() and gpiod_unexport() shouldn't be used in the code,
GPIO sysfs is deprecated. That said, simply drop the stray call.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/net/dsa/lan9303-core.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/dsa/lan9303-core.c b/drivers/net/dsa/lan9303-core.c
index cbe831875347..b560e73c14ca 100644
--- a/drivers/net/dsa/lan9303-core.c
+++ b/drivers/net/dsa/lan9303-core.c
@@ -1462,7 +1462,6 @@ int lan9303_remove(struct lan9303 *chip)
/* assert reset to the whole device to prevent it from doing anything */
gpiod_set_value_cansleep(chip->reset_gpio, 1);
- gpiod_unexport(chip->reset_gpio);
return 0;
}
--
2.40.0.1.gaa8946217a0b
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next v1 1/1] dsa: lan9303: Remove stray gpiod_unexport() call
2023-05-28 14:25 [PATCH net-next v1 1/1] dsa: lan9303: Remove stray gpiod_unexport() call Andy Shevchenko
@ 2023-05-29 15:00 ` Andrew Lunn
2023-05-30 11:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2023-05-29 15:00 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Jerry Ray, David S. Miller, netdev, linux-kernel,
Florian Fainelli, Vladimir Oltean, Eric Dumazet, Jakub Kicinski,
Paolo Abeni
On Sun, May 28, 2023 at 05:25:31PM +0300, Andy Shevchenko wrote:
> There is no gpiod_export() and gpiod_unexport() looks pretty much stray.
> The gpiod_export() and gpiod_unexport() shouldn't be used in the code,
> GPIO sysfs is deprecated. That said, simply drop the stray call.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net-next v1 1/1] dsa: lan9303: Remove stray gpiod_unexport() call
2023-05-28 14:25 [PATCH net-next v1 1/1] dsa: lan9303: Remove stray gpiod_unexport() call Andy Shevchenko
2023-05-29 15:00 ` Andrew Lunn
@ 2023-05-30 11:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-05-30 11:20 UTC (permalink / raw)
To: Andy Shevchenko
Cc: jerry.ray, davem, netdev, linux-kernel, andrew, f.fainelli,
olteanv, edumazet, kuba, pabeni
Hello:
This patch was applied to netdev/net-next.git (main)
by Paolo Abeni <pabeni@redhat.com>:
On Sun, 28 May 2023 17:25:31 +0300 you wrote:
> There is no gpiod_export() and gpiod_unexport() looks pretty much stray.
> The gpiod_export() and gpiod_unexport() shouldn't be used in the code,
> GPIO sysfs is deprecated. That said, simply drop the stray call.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/net/dsa/lan9303-core.c | 1 -
> 1 file changed, 1 deletion(-)
Here is the summary with links:
- [net-next,v1,1/1] dsa: lan9303: Remove stray gpiod_unexport() call
https://git.kernel.org/netdev/net-next/c/3ea3c9cff7f9
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-05-30 11:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-28 14:25 [PATCH net-next v1 1/1] dsa: lan9303: Remove stray gpiod_unexport() call Andy Shevchenko
2023-05-29 15:00 ` Andrew Lunn
2023-05-30 11:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®