From: Rob Herring <robh@kernel.org>
To: Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, Mark Brown <broonie@kernel.org>,
devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
linux-i2c@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Andi Shyti <andi.shyti@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-spi@vger.kernel.org, linux-serial@vger.kernel.org,
Andy Gross <agross@kernel.org>,
linux-kernel@vger.kernel.org,
Marijn Suijten <marijn.suijten@somainline.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Bjorn Andersson <andersson@kernel.org>
Subject: Re: [PATCH 2/5] dt-bindings: serial: geni-qcom: Allow no qup-core icc path
Date: Mon, 03 Jul 2023 08:50:47 -0600 [thread overview]
Message-ID: <168839584680.3733361.16157756581298354084.robh@kernel.org> (raw)
In-Reply-To: <20230703-topic-8250_qup_icc-v1-2-fea39aa07525@linaro.org>
On Mon, 03 Jul 2023 15:31:11 +0200, Konrad Dybcio wrote:
> Some SoCs (like SM8150 and SM8250) don't seem to provide a qup-core path.
> Allow such case.
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
> .../bindings/serial/qcom,serial-geni-qcom.yaml | 26 +++++++++++++++-------
> 1 file changed, 18 insertions(+), 8 deletions(-)
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.example.dtb: geniqup@8c0000: serial@a88000: More than one condition true in oneOf schema:
{'$filename': '/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/serial/qcom,serial-geni-qcom.yaml',
'$id': 'http://devicetree.org/schemas/serial/qcom,serial-geni-qcom.yaml#',
'$schema': 'http://devicetree.org/meta-schemas/core.yaml#',
'allOf': [{'$ref': '/schemas/serial/serial.yaml#'},
{'oneOf': [{'required': ['interrupts']},
{'required': ['interrupts-extended']}]}],
'oneOf': [{'patternProperties': {'pinctrl-[0-9]+': True},
'properties': {'$nodename': True,
'bootph-all': True,
'bootph-pre-ram': True,
'bootph-pre-sram': True,
'bootph-some-ram': True,
'bootph-verify': True,
'interconnect-names': {'items': [{'const': 'qup-config'}],
'maxItems': 1,
'minItems': 1,
'type': 'array'},
'interconnects': {'maxItems': 1,
'minItems': 1},
'phandle': True,
'pinctrl-names': True,
'secure-status': True,
'status': True}},
{'patternProperties': {'pinctrl-[0-9]+': True},
'properties': {'$nodename': True,
'bootph-all': True,
'bootph-pre-ram': True,
'bootph-pre-sram': True,
'bootph-some-ram': True,
'bootph-verify': True,
'interconnect-names': {'items': [{'const': 'qup-core'},
{'const': 'qup-config'}],
'maxItems': 2,
'minItems': 2,
'type': 'array'},
'interconnects': {'maxItems': 2,
'minItems': 2},
'phandle': True,
'pinctrl-names': True,
'secure-status': True,
'status': True}}],
'properties': {'$nodename': True,
'assigned-clock-parents': True,
'assigned-clock-rates': True,
'assigned-clocks': True,
'bootph-all': True,
'bootph-pre-ram': True,
'bootph-pre-sram': True,
'bootph-some-ram': True,
'bootph-verify': True,
'clock-names': {'items': [{'const': 'se'}],
'maxItems': 1,
'minItems': 1,
'type': 'array'},
'clocks': {'maxItems': 1, 'minItems': 1},
'compatible': {'items': [{'enum': ['qcom,geni-uart',
'qcom,geni-debug-uart']}],
'maxItems': 1,
'minItems': 1,
'type': 'array'},
'interrupt-parent': True,
'interrupts': {'maxItems': 2,
'minItems': 1,
'type': 'array'},
'interrupts-extended': {'maxItems': 2,
'minItems': 1,
'type': 'array'},
'operating-points-v2': True,
'phandle': True,
'pinctrl-0': True,
'pinctrl-1': True,
'pinctrl-names': {'items': [{'const': 'default'},
{'const': 'sleep'}],
'maxItems': 2,
'minItems': 1,
'type': 'array'},
'power-domains': {'maxItems': 1, 'minItems': 1},
'reg': {'maxItems': 1, 'minItems': 1},
'secure-status': True,
'status': True},
'required': ['compatible', 'clocks', 'clock-names', 'reg'],
'select': {'properties': {'compatible': {'contains': {'enum': ['qcom,geni-debug-uart',
'qcom,geni-uart']}}},
'required': ['compatible']},
'title': 'Qualcomm Geni based QUP UART interface',
'type': 'object',
'unevaluatedProperties': False}
from schema $id: http://devicetree.org/schemas/soc/qcom/qcom,geni-se.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.example.dtb: serial@a88000: More than one condition true in oneOf schema:
{'$filename': '/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/serial/qcom,serial-geni-qcom.yaml',
'$id': 'http://devicetree.org/schemas/serial/qcom,serial-geni-qcom.yaml#',
'$schema': 'http://devicetree.org/meta-schemas/core.yaml#',
'allOf': [{'$ref': '/schemas/serial/serial.yaml#'},
{'oneOf': [{'required': ['interrupts']},
{'required': ['interrupts-extended']}]}],
'oneOf': [{'patternProperties': {'pinctrl-[0-9]+': True},
'properties': {'$nodename': True,
'bootph-all': True,
'bootph-pre-ram': True,
'bootph-pre-sram': True,
'bootph-some-ram': True,
'bootph-verify': True,
'interconnect-names': {'items': [{'const': 'qup-config'}],
'maxItems': 1,
'minItems': 1,
'type': 'array'},
'interconnects': {'maxItems': 1,
'minItems': 1},
'phandle': True,
'pinctrl-names': True,
'secure-status': True,
'status': True}},
{'patternProperties': {'pinctrl-[0-9]+': True},
'properties': {'$nodename': True,
'bootph-all': True,
'bootph-pre-ram': True,
'bootph-pre-sram': True,
'bootph-some-ram': True,
'bootph-verify': True,
'interconnect-names': {'items': [{'const': 'qup-core'},
{'const': 'qup-config'}],
'maxItems': 2,
'minItems': 2,
'type': 'array'},
'interconnects': {'maxItems': 2,
'minItems': 2},
'phandle': True,
'pinctrl-names': True,
'secure-status': True,
'status': True}}],
'properties': {'$nodename': True,
'assigned-clock-parents': True,
'assigned-clock-rates': True,
'assigned-clocks': True,
'bootph-all': True,
'bootph-pre-ram': True,
'bootph-pre-sram': True,
'bootph-some-ram': True,
'bootph-verify': True,
'clock-names': {'items': [{'const': 'se'}],
'maxItems': 1,
'minItems': 1,
'type': 'array'},
'clocks': {'maxItems': 1, 'minItems': 1},
'compatible': {'items': [{'enum': ['qcom,geni-uart',
'qcom,geni-debug-uart']}],
'maxItems': 1,
'minItems': 1,
'type': 'array'},
'interrupt-parent': True,
'interrupts': {'maxItems': 2,
'minItems': 1,
'type': 'array'},
'interrupts-extended': {'maxItems': 2,
'minItems': 1,
'type': 'array'},
'operating-points-v2': True,
'phandle': True,
'pinctrl-0': True,
'pinctrl-1': True,
'pinctrl-names': {'items': [{'const': 'default'},
{'const': 'sleep'}],
'maxItems': 2,
'minItems': 1,
'type': 'array'},
'power-domains': {'maxItems': 1, 'minItems': 1},
'reg': {'maxItems': 1, 'minItems': 1},
'secure-status': True,
'status': True},
'required': ['compatible', 'clocks', 'clock-names', 'reg'],
'select': {'properties': {'compatible': {'contains': {'enum': ['qcom,geni-debug-uart',
'qcom,geni-uart']}}},
'required': ['compatible']},
'title': 'Qualcomm Geni based QUP UART interface',
'type': 'object',
'unevaluatedProperties': False}
from schema $id: http://devicetree.org/schemas/serial/qcom,serial-geni-qcom.yaml#
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230703-topic-8250_qup_icc-v1-2-fea39aa07525@linaro.org
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2023-07-03 14:50 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-03 13:31 [PATCH 0/5] Add interconnects to QUPs on SM8250 Konrad Dybcio
2023-07-03 13:31 ` [PATCH 1/5] dt-bindings: spi: spi-geni-qcom: Allow no qup-core icc path Konrad Dybcio
2023-07-03 13:59 ` Krzysztof Kozlowski
2023-07-03 13:31 ` [PATCH 2/5] dt-bindings: serial: geni-qcom: " Konrad Dybcio
2023-07-03 14:01 ` Krzysztof Kozlowski
2023-07-03 14:38 ` Konrad Dybcio
2023-07-03 14:41 ` Krzysztof Kozlowski
2023-07-03 14:50 ` Rob Herring [this message]
2023-07-03 13:31 ` [PATCH 3/5] dt-bindings: i2c: qcom,i2c-geni: " Konrad Dybcio
2023-07-03 14:36 ` Krzysztof Kozlowski
2023-07-03 14:59 ` Krzysztof Kozlowski
2023-07-03 14:50 ` Rob Herring
2023-07-03 13:31 ` [PATCH 4/5] soc: qcom: geni-se: Allow any combination of icc paths Konrad Dybcio
2023-07-03 14:31 ` Dmitry Baryshkov
2023-07-03 13:31 ` [PATCH 5/5] arm64: dts: qcom: sm8250: Add interconnects and power-domains to QUPs Konrad Dybcio
2023-07-03 14:25 ` Dmitry Baryshkov
2023-07-03 14:58 ` [PATCH 0/5] Add interconnects to QUPs on SM8250 Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168839584680.3733361.16157756581298354084.robh@kernel.org \
--to=robh@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®