From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Konrad Dybcio <konrad.dybcio@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andi Shyti <andi.shyti@kernel.org>
Cc: Marijn Suijten <marijn.suijten@somainline.org>,
linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org, linux-i2c@vger.kernel.org
Subject: Re: [PATCH 3/5] dt-bindings: i2c: qcom,i2c-geni: Allow no qup-core icc path
Date: Mon, 3 Jul 2023 16:59:27 +0200 [thread overview]
Message-ID: <4b1beb09-c9ba-82c5-69f0-058025c7f7e2@linaro.org> (raw)
In-Reply-To: <05869d6f-972b-75e1-6c0f-46baeafca5ff@linaro.org>
On 03/07/2023 16:36, Krzysztof Kozlowski wrote:
> On 03/07/2023 15:31, Konrad Dybcio wrote:
>> Some SoCs (like SM8150 and SM8250) don't seem to provide a qup-core path.
>> Allow such case.
>>
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Un-reviewed. Don't define properties in oneOf, instead use the syntax I
pointed out in other patch. If you remove interconnects from this
example, you will reproduce the error.
This should be something like:
interconnects:
minItems: 2
maxItems: 3
interconnect-names:
oneOf:
- items:
- const: qup-config
- const: qup-memory
- items:
- const: qup-core
- const: qup-config
- const: qup-memory
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-07-03 14:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-03 13:31 [PATCH 0/5] Add interconnects to QUPs on SM8250 Konrad Dybcio
2023-07-03 13:31 ` [PATCH 1/5] dt-bindings: spi: spi-geni-qcom: Allow no qup-core icc path Konrad Dybcio
2023-07-03 13:59 ` Krzysztof Kozlowski
2023-07-03 13:31 ` [PATCH 2/5] dt-bindings: serial: geni-qcom: " Konrad Dybcio
2023-07-03 14:01 ` Krzysztof Kozlowski
2023-07-03 14:38 ` Konrad Dybcio
2023-07-03 14:41 ` Krzysztof Kozlowski
2023-07-03 14:50 ` Rob Herring
2023-07-03 13:31 ` [PATCH 3/5] dt-bindings: i2c: qcom,i2c-geni: " Konrad Dybcio
2023-07-03 14:36 ` Krzysztof Kozlowski
2023-07-03 14:59 ` Krzysztof Kozlowski [this message]
2023-07-03 14:50 ` Rob Herring
2023-07-03 13:31 ` [PATCH 4/5] soc: qcom: geni-se: Allow any combination of icc paths Konrad Dybcio
2023-07-03 14:31 ` Dmitry Baryshkov
2023-07-03 13:31 ` [PATCH 5/5] arm64: dts: qcom: sm8250: Add interconnects and power-domains to QUPs Konrad Dybcio
2023-07-03 14:25 ` Dmitry Baryshkov
2023-07-03 14:58 ` [PATCH 0/5] Add interconnects to QUPs on SM8250 Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b1beb09-c9ba-82c5-69f0-058025c7f7e2@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®