From: Rob Herring <robh@kernel.org>
To: huaqian.li@siemens.com
Cc: baocheng.su@siemens.com, krzysztof.kozlowski+dt@linaro.org,
huaqianlee@gmail.com, robh+dt@kernel.org, nm@ti.com,
jan.kiszka@siemens.com, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-watchdog@vger.kernel.org, linux@roeck-us.net,
kristo@kernel.org, linux-kernel@vger.kernel.org,
conor+dt@kernel.org, wim@linux-watchdog.org, vigneshr@ti.com
Subject: Re: [PATCH v2 1/3] dt-bindings: watchdog: ti,rti-wdt: Add support for WDIOF_CARDRESET
Date: Tue, 11 Jul 2023 04:13:31 -0600 [thread overview]
Message-ID: <168907041196.552587.9843900798401014394.robh@kernel.org> (raw)
In-Reply-To: <20230711091713.1113010-2-huaqian.li@siemens.com>
On Tue, 11 Jul 2023 17:17:11 +0800, huaqian.li@siemens.com wrote:
> From: Li Hua Qian <huaqian.li@siemens.com>
>
> TI RTI (Real Time Interrupt) Watchdog doesn't support to record the
> watchdog cause. Add a reserved memory to know the last reboot was caused
> by the watchdog card. In the reserved memory, some specific info will be
> saved to indicate whether the watchdog reset was triggered in last
> boot.
>
> Signed-off-by: Li Hua Qian <huaqian.li@siemens.com>
> ---
> .../devicetree/bindings/watchdog/ti,rti-wdt.yaml | 13 ++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
./Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml:30:18: [error] syntax error: mapping values are not allowed here (syntax)
dtschema/dtc warnings/errors:
make[2]: *** Deleting file 'Documentation/devicetree/bindings/watchdog/ti,rti-wdt.example.dts'
Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml:30:18: mapping values are not allowed in this context
make[2]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/watchdog/ti,rti-wdt.example.dts] Error 1
make[2]: *** Waiting for unfinished jobs....
./Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml:30:18: mapping values are not allowed in this context
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml: ignoring, error parsing file
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1500: dt_binding_check] Error 2
make: *** [Makefile:234: __sub-make] Error 2
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230711091713.1113010-2-huaqian.li@siemens.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2023-07-11 10:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-11 9:17 [PATCH v2 0/3] Add support for WDIOF_CARDRESET on TI AM65x huaqian.li
2023-07-11 9:17 ` [PATCH v2 1/3] dt-bindings: watchdog: ti,rti-wdt: Add support for WDIOF_CARDRESET huaqian.li
2023-07-11 9:23 ` Krzysztof Kozlowski
2023-07-12 1:40 ` Li, Hua Qian
2023-07-11 10:13 ` Rob Herring [this message]
2023-07-12 1:42 ` Li, Hua Qian
2023-07-11 9:17 ` [PATCH v2 2/3] arm64: dts: ti: Add reserved memory for watchdog huaqian.li
2023-07-11 9:24 ` Krzysztof Kozlowski
2023-07-12 1:48 ` Li, Hua Qian
2023-07-11 9:17 ` [PATCH v2 3/3] watchdog:rit_wdt: Add support for WDIOF_CARDRESET huaqian.li
2023-07-12 2:32 ` Guenter Roeck
2023-07-12 4:03 ` Li, Hua Qian
2023-07-12 5:01 ` Guenter Roeck
2023-07-12 6:05 ` Li, Hua Qian
2023-07-12 9:34 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168907041196.552587.9843900798401014394.robh@kernel.org \
--to=robh@kernel.org \
--cc=baocheng.su@siemens.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=huaqian.li@siemens.com \
--cc=huaqianlee@gmail.com \
--cc=jan.kiszka@siemens.com \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®