From: "Li, Hua Qian" <HuaQian.Li@siemens.com>
To: "wim@linux-watchdog.org" <wim@linux-watchdog.org>,
"linux@roeck-us.net" <linux@roeck-us.net>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"krzysztof.kozlowski@linaro.org" <krzysztof.kozlowski@linaro.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>
Cc: "kristo@kernel.org" <kristo@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"huaqianlee@gmail.com" <huaqianlee@gmail.com>,
"nm@ti.com" <nm@ti.com>, "vigneshr@ti.com" <vigneshr@ti.com>,
"Kiszka, Jan" <jan.kiszka@siemens.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"Su, Bao Cheng" <baocheng.su@siemens.com>,
"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>
Subject: Re: [PATCH v2 1/3] dt-bindings: watchdog: ti,rti-wdt: Add support for WDIOF_CARDRESET
Date: Wed, 12 Jul 2023 01:40:32 +0000 [thread overview]
Message-ID: <19bf680470e4b0c38f9182be621d3b75151740be.camel@siemens.com> (raw)
In-Reply-To: <8d52eaa7-0934-97fd-0288-9e8ed2f82bee@linaro.org>
On Tue, 2023-07-11 at 11:23 +0200, Krzysztof Kozlowski wrote:
> On 11/07/2023 11:17, huaqian.li@siemens.com wrote:
> > From: Li Hua Qian <huaqian.li@siemens.com>
> >
> > TI RTI (Real Time Interrupt) Watchdog doesn't support to record the
> > watchdog cause. Add a reserved memory to know the last reboot was
> > caused
> > by the watchdog card. In the reserved memory, some specific info
> > will be
> > saved to indicate whether the watchdog reset was triggered in last
> > boot.
> >
> > Signed-off-by: Li Hua Qian <huaqian.li@siemens.com>
> > ---
>
> Missing changelog.
Thanks for pointing out.
>
> > .../devicetree/bindings/watchdog/ti,rti-wdt.yaml | 13
> > ++++++++++++-
> > 1 file changed, 12 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/watchdog/ti,rti-
> > wdt.yaml b/Documentation/devicetree/bindings/watchdog/ti,rti-
> > wdt.yaml
> > index fc553211e42d..f227db08dc70 100644
> > --- a/Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml
> > +++ b/Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml
> > @@ -26,7 +26,18 @@ properties:
> > - ti,j7-rti-wdt
> >
> > reg:
> > - maxItems: 1
> > + maxItems: 2
>
> The expected syntax is in such case:
> items:
> - description: ...
> - description: ...
>
> You will find plenty of examples for this.
>
> > + description:
> > + - Contains the address and the size of MCU RTI register.
> > + - Contains the address and the size of reserved memory,
> > which
>
> I don't think Conor suggested using reg of the device, but reg of
> reserved memory. This is not device address space, but just some
> random
> memory.
>
> memory-region seems proper to me. We were just discussing totally
> useless new property of size.
I guess I misunderstood what Conor suggested, I will change back to
memory-region and get size from reserved-memory. Does this look good
to you?
>
> What's more - you did not test it... so usual template:
>
> It does not look like you tested the DTS against bindings. Please run
> `make dtbs_check` (see
> Documentation/devicetree/bindings/writing-schema.rst or
> https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
> for instructions).
>
> Best regards,
> Krzysztof
>
Sorry for this, I will make sure this is no problem in the next
version.
Best regards,
Li Hua Qian
next prev parent reply other threads:[~2023-07-12 1:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-11 9:17 [PATCH v2 0/3] Add support for WDIOF_CARDRESET on TI AM65x huaqian.li
2023-07-11 9:17 ` [PATCH v2 1/3] dt-bindings: watchdog: ti,rti-wdt: Add support for WDIOF_CARDRESET huaqian.li
2023-07-11 9:23 ` Krzysztof Kozlowski
2023-07-12 1:40 ` Li, Hua Qian [this message]
2023-07-11 10:13 ` Rob Herring
2023-07-12 1:42 ` Li, Hua Qian
2023-07-11 9:17 ` [PATCH v2 2/3] arm64: dts: ti: Add reserved memory for watchdog huaqian.li
2023-07-11 9:24 ` Krzysztof Kozlowski
2023-07-12 1:48 ` Li, Hua Qian
2023-07-11 9:17 ` [PATCH v2 3/3] watchdog:rit_wdt: Add support for WDIOF_CARDRESET huaqian.li
2023-07-12 2:32 ` Guenter Roeck
2023-07-12 4:03 ` Li, Hua Qian
2023-07-12 5:01 ` Guenter Roeck
2023-07-12 6:05 ` Li, Hua Qian
2023-07-12 9:34 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19bf680470e4b0c38f9182be621d3b75151740be.camel@siemens.com \
--to=huaqian.li@siemens.com \
--cc=baocheng.su@siemens.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=huaqianlee@gmail.com \
--cc=jan.kiszka@siemens.com \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®