mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v9 0/2] dt-bindings: dma: Add support for SM6115 and QCM2290 SoCs
@ 2023-06-30  8:22 Bhupesh Sharma
  2023-06-30  8:22 ` [PATCH v9 1/2] " Bhupesh Sharma
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Bhupesh Sharma @ 2023-06-30  8:22 UTC (permalink / raw)
  To: devicetree, dmaengine
  Cc: vkoul, krzysztof.kozlowski+dt, linux-kernel, linux-arm-msm,
	andersson, bhupesh.sharma, bhupesh.linux, agross, konrad.dybcio,
	conor+dt, robh+dt

Add support for SM6115 and QCM2290 SoCs in qcom,bam-dma bindings.
Also increase iommu maxItems for BAM DMA to 6 which is the number
required on sm8250 SoC.

This patchset is rebased on linux-next/master.

Changes since v8:
-----------------
- v8 can be viewed here: https://www.spinics.net/lists/linux-crypto/msg72349.html
- As rest of the patches from v8 have been applied to linux-next, dropped them from v9.
- Added dma list and maintainer in Cc again as the Cc list got messed up while
  sending out v8.

Changes since v7:
-----------------
- v7 can be viewed here: https://lore.kernel.org/linux-arm-msm/20230519214813.2593271-1-bhupesh.sharma@linaro.org/
- Addressed Stephan's comment about RPM clocks for sm6115 crypto block in dtsi.
- Also fixed the iommu context ids for sm6115 crypto block in dtsi.

Changes since v6:
-----------------
- v6 can be viewed here: https://lore.kernel.org/linux-arm-msm/20230405072836.1690248-1-bhupesh.sharma@linaro.org/
- Collected Acks, R-Bs and Tested-by for various patches.
- Addressed Konrad's comment about iommu sids for sm8150 and sm8250
  crypto node entries.
- Addressed Konrad's and Stephan's comments about adding RPM clock for
  crypto blocks on qcm2290 and sm6115.

Changes since v5:
-----------------
- v5 can be viewed here: https://lore.kernel.org/linux-arm-msm/20230402100509.1154220-1-bhupesh.sharma@linaro.org/
- Collected Ack from Rob for [PATCH 01/11].
- Addressed Georgi's comment about interconnect cells in [PATCH 10/11].

Changes since v4:
-----------------
- v4 can be viewed here: https://lore.kernel.org/linux-arm-msm/20230331164323.729093-1-bhupesh.sharma@linaro.org/
- Collected R-Bs from Konrad for a couple of patches sent in v4.
- Fixed incorrect email IDs for a couple of patches sent in v3, which I used for
  some patches created on a different work machine.
- No functional changes since v3.

Changes since v3:
-----------------
- v3 can be viewed here: https://lore.kernel.org/linux-arm-msm/20230328092815.292665-1-bhupesh.sharma@linaro.org/
- Collected Acks from Krzysztof for a couple of patches sent in v3.
- Fixed review comments from Krzysztof regarding DMA binding document
  and also added a couple of new patches which are required to fix the
  'dtbs_check' errors highlighted after this fix.

Changes since v2:
-----------------
- v2 can be viewed here: https://lore.kernel.org/linux-arm-msm/20230322114519.3412469-1-bhupesh.sharma@linaro.org/
- No functional change since v2. As the sdm845 patch from v1 was accepted in linux-next,
  dropped it from this version.

Changes since v1:
-----------------
- v1 can be viewed here: https://lore.kernel.org/linux-arm-msm/20230321190118.3327360-1-bhupesh.sharma@linaro.org/
- Folded the BAM DMA dt-binding change.
  (sent earlier as: https://lore.kernel.org/linux-arm-msm/20230321184811.3325725-1-bhupesh.sharma@linaro.org/)
- Folded the QCE dt-binding change.
  (sent earlier as: https://lore.kernel.org/linux-arm-msm/20230320073816.3012198-1-bhupesh.sharma@linaro.org/)
- Folded Neil's SM8450 dts patch in this series.
- Addressed review comments from Rob, Stephan and Konrad.
- Collected Konrad's R-B for [PATCH 5/9].

Bhupesh Sharma (2):
  dt-bindings: dma: Add support for SM6115 and QCM2290 SoCs
  dt-bindings: dma: Increase iommu maxItems for BAM DMA

 .../devicetree/bindings/dma/qcom,bam-dma.yaml | 22 ++++++++++++-------
 1 file changed, 14 insertions(+), 8 deletions(-)

-- 
2.38.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH v9 1/2] dt-bindings: dma: Add support for SM6115 and QCM2290 SoCs
  2023-06-30  8:22 [PATCH v9 0/2] dt-bindings: dma: Add support for SM6115 and QCM2290 SoCs Bhupesh Sharma
@ 2023-06-30  8:22 ` Bhupesh Sharma
  2023-06-30  8:22 ` [PATCH v9 2/2] dt-bindings: dma: Increase iommu maxItems for BAM DMA Bhupesh Sharma
  2023-07-11 16:43 ` [PATCH v9 0/2] dt-bindings: dma: Add support for SM6115 and QCM2290 SoCs Vinod Koul
  2 siblings, 0 replies; 4+ messages in thread
From: Bhupesh Sharma @ 2023-06-30  8:22 UTC (permalink / raw)
  To: devicetree, dmaengine
  Cc: vkoul, krzysztof.kozlowski+dt, linux-kernel, linux-arm-msm,
	andersson, bhupesh.sharma, bhupesh.linux, agross, konrad.dybcio,
	conor+dt, robh+dt, Rob Herring, Anders Roxell,
	Linux Kernel Functional Testing

Add new compatible for BAM DMA engine version v1.7.4 which is
found on Qualcomm SM6115 and QCM2290 SoCs. Since its very similar
to v1.7.0 used on SM8150 like SoCs, mark the comptible scheme
accordingly.

While at it, also update qcom,bam-dma bindings to add comments
which describe the BAM DMA versions used in SM8150 and SM8250 SoCs.
This provides an easy reference for identifying the actual BAM DMA
version available on Qualcomm SoCs.

Acked-by: Rob Herring <robh@kernel.org>
Tested-by: Anders Roxell <anders.roxell@linaro.org>
Tested-by: Linux Kernel Functional Testing <lkft@linaro.org>
Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
---
 .../devicetree/bindings/dma/qcom,bam-dma.yaml | 20 ++++++++++++-------
 1 file changed, 13 insertions(+), 7 deletions(-)

diff --git a/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml b/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml
index f1ddcf672261..c663b6102f50 100644
--- a/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml
+++ b/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml
@@ -15,13 +15,19 @@ allOf:
 
 properties:
   compatible:
-    enum:
-        # APQ8064, IPQ8064 and MSM8960
-      - qcom,bam-v1.3.0
-        # MSM8974, APQ8074 and APQ8084
-      - qcom,bam-v1.4.0
-        # MSM8916 and SDM845
-      - qcom,bam-v1.7.0
+    oneOf:
+      - enum:
+          # APQ8064, IPQ8064 and MSM8960
+          - qcom,bam-v1.3.0
+          # MSM8974, APQ8074 and APQ8084
+          - qcom,bam-v1.4.0
+          # MSM8916, SDM630
+          - qcom,bam-v1.7.0
+      - items:
+          - enum:
+              # SDM845, SM6115, SM8150, SM8250 and QCM2290
+              - qcom,bam-v1.7.4
+          - const: qcom,bam-v1.7.0
 
   clocks:
     maxItems: 1
-- 
2.38.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH v9 2/2] dt-bindings: dma: Increase iommu maxItems for BAM DMA
  2023-06-30  8:22 [PATCH v9 0/2] dt-bindings: dma: Add support for SM6115 and QCM2290 SoCs Bhupesh Sharma
  2023-06-30  8:22 ` [PATCH v9 1/2] " Bhupesh Sharma
@ 2023-06-30  8:22 ` Bhupesh Sharma
  2023-07-11 16:43 ` [PATCH v9 0/2] dt-bindings: dma: Add support for SM6115 and QCM2290 SoCs Vinod Koul
  2 siblings, 0 replies; 4+ messages in thread
From: Bhupesh Sharma @ 2023-06-30  8:22 UTC (permalink / raw)
  To: devicetree, dmaengine
  Cc: vkoul, krzysztof.kozlowski+dt, linux-kernel, linux-arm-msm,
	andersson, bhupesh.sharma, bhupesh.linux, agross, konrad.dybcio,
	conor+dt, robh+dt, Krzysztof Kozlowski, Anders Roxell,
	Linux Kernel Functional Testing

Since SM8250 BAM DMA engine supports six iommu entries,
increase the maxItems in the iommu property section, without
which 'dtbs_check' would throw errors.

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Tested-by: Anders Roxell <anders.roxell@linaro.org>
Tested-by: Linux Kernel Functional Testing <lkft@linaro.org>
Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
---
 Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml b/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml
index c663b6102f50..6433f2892ae4 100644
--- a/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml
+++ b/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml
@@ -44,7 +44,7 @@ properties:
 
   iommus:
     minItems: 1
-    maxItems: 4
+    maxItems: 6
 
   num-channels:
     $ref: /schemas/types.yaml#/definitions/uint32
-- 
2.38.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v9 0/2] dt-bindings: dma: Add support for SM6115 and QCM2290 SoCs
  2023-06-30  8:22 [PATCH v9 0/2] dt-bindings: dma: Add support for SM6115 and QCM2290 SoCs Bhupesh Sharma
  2023-06-30  8:22 ` [PATCH v9 1/2] " Bhupesh Sharma
  2023-06-30  8:22 ` [PATCH v9 2/2] dt-bindings: dma: Increase iommu maxItems for BAM DMA Bhupesh Sharma
@ 2023-07-11 16:43 ` Vinod Koul
  2 siblings, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2023-07-11 16:43 UTC (permalink / raw)
  To: devicetree, dmaengine, Bhupesh Sharma
  Cc: krzysztof.kozlowski+dt, linux-kernel, linux-arm-msm, andersson,
	bhupesh.linux, agross, konrad.dybcio, conor+dt, robh+dt


On Fri, 30 Jun 2023 13:52:28 +0530, Bhupesh Sharma wrote:
> Add support for SM6115 and QCM2290 SoCs in qcom,bam-dma bindings.
> Also increase iommu maxItems for BAM DMA to 6 which is the number
> required on sm8250 SoC.
> 
> This patchset is rebased on linux-next/master.
> 
> Changes since v8:
> -----------------
> - v8 can be viewed here: https://www.spinics.net/lists/linux-crypto/msg72349.html
> - As rest of the patches from v8 have been applied to linux-next, dropped them from v9.
> - Added dma list and maintainer in Cc again as the Cc list got messed up while
>   sending out v8.
> 
> [...]

Applied, thanks!

[1/2] dt-bindings: dma: Add support for SM6115 and QCM2290 SoCs
      commit: 80159ca4314224f5778d5fa8ded24d6ef7876c53
[2/2] dt-bindings: dma: Increase iommu maxItems for BAM DMA
      commit: ffcde05811d97e9320358674625f28002102f7c9

Best regards,
-- 
~Vinod



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-07-11 16:45 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-30  8:22 [PATCH v9 0/2] dt-bindings: dma: Add support for SM6115 and QCM2290 SoCs Bhupesh Sharma
2023-06-30  8:22 ` [PATCH v9 1/2] " Bhupesh Sharma
2023-06-30  8:22 ` [PATCH v9 2/2] dt-bindings: dma: Increase iommu maxItems for BAM DMA Bhupesh Sharma
2023-07-11 16:43 ` [PATCH v9 0/2] dt-bindings: dma: Add support for SM6115 and QCM2290 SoCs Vinod Koul

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®