From: "tip-bot2 for Arnd Bergmann" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Arnd Bergmann <arnd@arndb.de>,
"Borislav Petkov (AMD)" <bp@alien8.de>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: x86/cleanups] x86/apic: Hide unused safe_smp_processor_id() on 32-bit UP
Date: Thu, 03 Aug 2023 15:59:15 -0000 [thread overview]
Message-ID: <169107835581.28540.12068505666604846343.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20230725134837.1534228-2-arnd@kernel.org>
The following commit has been merged into the x86/cleanups branch of tip:
Commit-ID: ac1c6283c45a77431af33fbae435f1a29f23a9f4
Gitweb: https://git.kernel.org/tip/ac1c6283c45a77431af33fbae435f1a29f23a9f4
Author: Arnd Bergmann <arnd@arndb.de>
AuthorDate: Tue, 25 Jul 2023 15:48:33 +02:00
Committer: Borislav Petkov (AMD) <bp@alien8.de>
CommitterDate: Mon, 31 Jul 2023 11:32:25 +02:00
x86/apic: Hide unused safe_smp_processor_id() on 32-bit UP
When CONFIG_SMP is disabled in a 32-bit config, the prototype for
safe_smp_processor_id() is hidden, which causes a W=1 warning:
arch/x86/kernel/apic/ipi.c:316:5: error: no previous prototype for 'safe_smp_processor_id' [-Werror=missing-prototypes]
Since there are no callers in this configuration, just hide the definition
as well.
[ bp: Clarify it is a 32-bit config. ]
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
Link: https://lore.kernel.org/r/20230725134837.1534228-2-arnd@kernel.org
---
arch/x86/kernel/apic/ipi.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/x86/kernel/apic/ipi.c b/arch/x86/kernel/apic/ipi.c
index 2a6509e..9bfd6e3 100644
--- a/arch/x86/kernel/apic/ipi.c
+++ b/arch/x86/kernel/apic/ipi.c
@@ -301,6 +301,7 @@ void default_send_IPI_mask_logical(const struct cpumask *cpumask, int vector)
local_irq_restore(flags);
}
+#ifdef CONFIG_SMP
/* must come after the send_IPI functions above for inlining */
static int convert_apicid_to_cpu(int apic_id)
{
@@ -329,3 +330,4 @@ int safe_smp_processor_id(void)
return cpuid >= 0 ? cpuid : 0;
}
#endif
+#endif
next prev parent reply other threads:[~2023-08-03 15:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-25 13:48 [PATCH 0/5] remaining x86 -Wmissing-prototype warnings Arnd Bergmann
2023-07-25 13:48 ` [PATCH 1/5] [RESEND] x86: apic: hide unused safe_smp_processor_id on UP Arnd Bergmann
2023-08-03 15:59 ` tip-bot2 for Arnd Bergmann [this message]
2023-07-25 13:48 ` [PATCH 2/5] [RESEND] x86: avoid unneeded __div64_32 function definition Arnd Bergmann
2023-08-01 17:03 ` Borislav Petkov
2023-08-01 20:48 ` Arnd Bergmann
2023-08-02 17:20 ` Borislav Petkov
2023-08-07 20:37 ` Maciej W. Rozycki
2023-08-07 21:16 ` Borislav Petkov
2023-08-07 21:58 ` Maciej W. Rozycki
2023-07-25 13:48 ` [PATCH 3/5] [RESEND] x86: qspinlock-paravirt: fix mising-prototype warnings Arnd Bergmann
2023-08-01 19:22 ` Borislav Petkov
2023-08-01 20:26 ` Arnd Bergmann
2023-08-02 17:26 ` Borislav Petkov
2023-08-02 17:27 ` Borislav Petkov
2023-07-25 13:48 ` [PATCH 4/5] [RESEND] x86: purgatory: include header for warn() declaration Arnd Bergmann
2023-07-25 13:48 ` [PATCH 5/5] [RESEND] x86: alternative: add __alt_reloc_selftest prototype Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169107835581.28540.12068505666604846343.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®