From: Arnd Bergmann <arnd@kernel.org>
To: linux-kernel@vger.kernel.org, x86@kernel.org
Cc: Arnd Bergmann <arnd@arndb.de>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: [PATCH 2/5] [RESEND] x86: avoid unneeded __div64_32 function definition
Date: Tue, 25 Jul 2023 15:48:34 +0200 [thread overview]
Message-ID: <20230725134837.1534228-3-arnd@kernel.org> (raw)
In-Reply-To: <20230725134837.1534228-1-arnd@kernel.org>
From: Arnd Bergmann <arnd@arndb.de>
The __div64_32() function is provided for 32-bit architectures that
don't have a custom do_div() implementation. x86_32 has one, and
does not use the header file that declares the function prototype,
so the definition causes a W=1 warning:
lib/math/div64.c:31:32: error: no previous prototype for '__div64_32' [-Werror=missing-prototypes]
Define an empty macro to prevent the function definition from getting
built, which avoids the warning and saves a little .text space.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
arch/x86/include/asm/div64.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/x86/include/asm/div64.h b/arch/x86/include/asm/div64.h
index b8f1dc0761e4b..9826d5fc12e34 100644
--- a/arch/x86/include/asm/div64.h
+++ b/arch/x86/include/asm/div64.h
@@ -71,6 +71,8 @@ static inline u64 mul_u32_u32(u32 a, u32 b)
}
#define mul_u32_u32 mul_u32_u32
+#define __div64_32 /* not needed */
+
#else
# include <asm-generic/div64.h>
--
2.39.2
next prev parent reply other threads:[~2023-07-25 13:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-25 13:48 [PATCH 0/5] remaining x86 -Wmissing-prototype warnings Arnd Bergmann
2023-07-25 13:48 ` [PATCH 1/5] [RESEND] x86: apic: hide unused safe_smp_processor_id on UP Arnd Bergmann
2023-08-03 15:59 ` [tip: x86/cleanups] x86/apic: Hide unused safe_smp_processor_id() on 32-bit UP tip-bot2 for Arnd Bergmann
2023-07-25 13:48 ` Arnd Bergmann [this message]
2023-08-01 17:03 ` [PATCH 2/5] [RESEND] x86: avoid unneeded __div64_32 function definition Borislav Petkov
2023-08-01 20:48 ` Arnd Bergmann
2023-08-02 17:20 ` Borislav Petkov
2023-08-07 20:37 ` Maciej W. Rozycki
2023-08-07 21:16 ` Borislav Petkov
2023-08-07 21:58 ` Maciej W. Rozycki
2023-07-25 13:48 ` [PATCH 3/5] [RESEND] x86: qspinlock-paravirt: fix mising-prototype warnings Arnd Bergmann
2023-08-01 19:22 ` Borislav Petkov
2023-08-01 20:26 ` Arnd Bergmann
2023-08-02 17:26 ` Borislav Petkov
2023-08-02 17:27 ` Borislav Petkov
2023-07-25 13:48 ` [PATCH 4/5] [RESEND] x86: purgatory: include header for warn() declaration Arnd Bergmann
2023-07-25 13:48 ` [PATCH 5/5] [RESEND] x86: alternative: add __alt_reloc_selftest prototype Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230725134837.1534228-3-arnd@kernel.org \
--to=arnd@kernel.org \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome