* [PATCH] drm: bridge: for GENERIC_PHY_MIPI_DPHY also select GENERIC_PHY
@ 2023-08-04 3:01 Randy Dunlap
2023-08-04 7:38 ` Guido Günther
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Randy Dunlap @ 2023-08-04 3:01 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, Aleksandr Nogikh, Adam Ford, Maxime Ripard,
Guido Günther, Robert Chiras, Sam Ravnborg, Neil Armstrong,
Andrzej Hajda, Robert Foss, David Airlie, Daniel Vetter,
dri-devel
Three DRM bridge drivers select GENERIC_PHY_MIPI_DPHY when GENERIC_PHY
might not be set. This causes Kconfig warnings and a build error.
WARNING: unmet direct dependencies detected for GENERIC_PHY_MIPI_DPHY
Depends on [n]: GENERIC_PHY [=n]
Selected by [y]:
- DRM_NWL_MIPI_DSI [=y] && DRM_BRIDGE [=y] && DRM [=y] && COMMON_CLK [=y] && OF [=y] && HAS_IOMEM [=y]
- DRM_SAMSUNG_DSIM [=y] && DRM [=y] && DRM_BRIDGE [=y] && COMMON_CLK [=y] && OF [=y] && HAS_IOMEM [=y]
(drm/bridge/cadence/Kconfig was found by inspection.)
aarch64-linux-ld: drivers/gpu/drm/bridge/samsung-dsim.o: in function `samsung_dsim_set_phy_ctrl':
drivers/gpu/drm/bridge/samsung-dsim.c:731: undefined reference to `phy_mipi_dphy_get_default_config_for_hsclk'
Prevent these warnings and build error by also selecting GENERIC_PHY
whenever selecting GENERIC_PHY_MIPI_DPHY.
Fixes: fced5a364dee ("drm/bridge: cdns: Convert to phy framework")
Fixes: 44cfc6233447 ("drm/bridge: Add NWL MIPI DSI host controller support")
Fixes: 171b3b1e0f8b ("drm: bridge: samsung-dsim: Select GENERIC_PHY_MIPI_DPHY")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reported-by: Aleksandr Nogikh <nogikh@google.com>
Link: lore.kernel.org/r/20230803144227.2187749-1-nogikh@google.com
Cc: Adam Ford <aford173@gmail.com>
Cc: Maxime Ripard <maxime.ripard@bootlin.com>
Cc: Guido Günther <agx@sigxcpu.org>
Cc: Robert Chiras <robert.chiras@nxp.com>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Neil Armstrong <neil.armstrong@linaro.org>
Cc: Andrzej Hajda <andrzej.hajda@intel.com>
Cc: Robert Foss <rfoss@kernel.org>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org
---
drivers/gpu/drm/bridge/Kconfig | 2 ++
drivers/gpu/drm/bridge/cadence/Kconfig | 1 +
2 files changed, 3 insertions(+)
diff -- a/drivers/gpu/drm/bridge/cadence/Kconfig b/drivers/gpu/drm/bridge/cadence/Kconfig
--- a/drivers/gpu/drm/bridge/cadence/Kconfig
+++ b/drivers/gpu/drm/bridge/cadence/Kconfig
@@ -4,6 +4,7 @@ config DRM_CDNS_DSI
select DRM_KMS_HELPER
select DRM_MIPI_DSI
select DRM_PANEL_BRIDGE
+ select GENERIC_PHY
select GENERIC_PHY_MIPI_DPHY
depends on OF
help
diff -- a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
--- a/drivers/gpu/drm/bridge/Kconfig
+++ b/drivers/gpu/drm/bridge/Kconfig
@@ -181,6 +181,7 @@ config DRM_NWL_MIPI_DSI
select DRM_KMS_HELPER
select DRM_MIPI_DSI
select DRM_PANEL_BRIDGE
+ select GENERIC_PHY
select GENERIC_PHY_MIPI_DPHY
select MFD_SYSCON
select MULTIPLEXER
@@ -227,6 +228,7 @@ config DRM_SAMSUNG_DSIM
select DRM_KMS_HELPER
select DRM_MIPI_DSI
select DRM_PANEL_BRIDGE
+ select GENERIC_PHY
select GENERIC_PHY_MIPI_DPHY
help
The Samsung MIPI DSIM bridge controller driver.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm: bridge: for GENERIC_PHY_MIPI_DPHY also select GENERIC_PHY
2023-08-04 3:01 [PATCH] drm: bridge: for GENERIC_PHY_MIPI_DPHY also select GENERIC_PHY Randy Dunlap
@ 2023-08-04 7:38 ` Guido Günther
2023-08-04 9:35 ` Aleksandr Nogikh
2023-08-04 11:22 ` Adam Ford
2023-08-11 12:47 ` Robert Foss
2 siblings, 1 reply; 5+ messages in thread
From: Guido Günther @ 2023-08-04 7:38 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-kernel, Aleksandr Nogikh, Adam Ford, Maxime Ripard,
Robert Chiras, Sam Ravnborg, Neil Armstrong, Andrzej Hajda,
Robert Foss, David Airlie, Daniel Vetter, dri-devel
Hi,
On Thu, Aug 03, 2023 at 08:01:37PM -0700, Randy Dunlap wrote:
> Three DRM bridge drivers select GENERIC_PHY_MIPI_DPHY when GENERIC_PHY
> might not be set. This causes Kconfig warnings and a build error.
>
> WARNING: unmet direct dependencies detected for GENERIC_PHY_MIPI_DPHY
> Depends on [n]: GENERIC_PHY [=n]
> Selected by [y]:
> - DRM_NWL_MIPI_DSI [=y] && DRM_BRIDGE [=y] && DRM [=y] && COMMON_CLK [=y] && OF [=y] && HAS_IOMEM [=y]
> - DRM_SAMSUNG_DSIM [=y] && DRM [=y] && DRM_BRIDGE [=y] && COMMON_CLK [=y] && OF [=y] && HAS_IOMEM [=y]
>
> (drm/bridge/cadence/Kconfig was found by inspection.)
>
> aarch64-linux-ld: drivers/gpu/drm/bridge/samsung-dsim.o: in function `samsung_dsim_set_phy_ctrl':
> drivers/gpu/drm/bridge/samsung-dsim.c:731: undefined reference to `phy_mipi_dphy_get_default_config_for_hsclk'
>
> Prevent these warnings and build error by also selecting GENERIC_PHY
n> whenever selecting GENERIC_PHY_MIPI_DPHY.
>
> Fixes: fced5a364dee ("drm/bridge: cdns: Convert to phy framework")
> Fixes: 44cfc6233447 ("drm/bridge: Add NWL MIPI DSI host controller support")
> Fixes: 171b3b1e0f8b ("drm: bridge: samsung-dsim: Select GENERIC_PHY_MIPI_DPHY")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: Aleksandr Nogikh <nogikh@google.com>
> Link: lore.kernel.org/r/20230803144227.2187749-1-nogikh@google.com
> Cc: Adam Ford <aford173@gmail.com>
> Cc: Maxime Ripard <maxime.ripard@bootlin.com>
> Cc: Guido Günther <agx@sigxcpu.org>
> Cc: Robert Chiras <robert.chiras@nxp.com>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: Neil Armstrong <neil.armstrong@linaro.org>
> Cc: Andrzej Hajda <andrzej.hajda@intel.com>
> Cc: Robert Foss <rfoss@kernel.org>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: dri-devel@lists.freedesktop.org
> ---
> drivers/gpu/drm/bridge/Kconfig | 2 ++
> drivers/gpu/drm/bridge/cadence/Kconfig | 1 +
> 2 files changed, 3 insertions(+)
>
> diff -- a/drivers/gpu/drm/bridge/cadence/Kconfig b/drivers/gpu/drm/bridge/cadence/Kconfig
> --- a/drivers/gpu/drm/bridge/cadence/Kconfig
> +++ b/drivers/gpu/drm/bridge/cadence/Kconfig
> @@ -4,6 +4,7 @@ config DRM_CDNS_DSI
> select DRM_KMS_HELPER
> select DRM_MIPI_DSI
> select DRM_PANEL_BRIDGE
> + select GENERIC_PHY
> select GENERIC_PHY_MIPI_DPHY
> depends on OF
> help
> diff -- a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
> --- a/drivers/gpu/drm/bridge/Kconfig
> +++ b/drivers/gpu/drm/bridge/Kconfig
> @@ -181,6 +181,7 @@ config DRM_NWL_MIPI_DSI
> select DRM_KMS_HELPER
> select DRM_MIPI_DSI
> select DRM_PANEL_BRIDGE
> + select GENERIC_PHY
> select GENERIC_PHY_MIPI_DPHY
> select MFD_SYSCON
> select MULTIPLEXER
> @@ -227,6 +228,7 @@ config DRM_SAMSUNG_DSIM
> select DRM_KMS_HELPER
> select DRM_MIPI_DSI
> select DRM_PANEL_BRIDGE
> + select GENERIC_PHY
> select GENERIC_PHY_MIPI_DPHY
> help
> The Samsung MIPI DSIM bridge controller driver.
>
For NWL:
Reviewed-by: Guido Günther <agx@sigxcpu.org>
Cheers,
-- Guido
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm: bridge: for GENERIC_PHY_MIPI_DPHY also select GENERIC_PHY
2023-08-04 7:38 ` Guido Günther
@ 2023-08-04 9:35 ` Aleksandr Nogikh
0 siblings, 0 replies; 5+ messages in thread
From: Aleksandr Nogikh @ 2023-08-04 9:35 UTC (permalink / raw)
To: Guido Günther
Cc: Randy Dunlap, linux-kernel, Adam Ford, Maxime Ripard,
Robert Chiras, Sam Ravnborg, Neil Armstrong, Andrzej Hajda,
Robert Foss, David Airlie, Daniel Vetter, dri-devel
Thank you for resolving this issue so quickly!
I've applied the patch locally and gone through the reproduction
steps. The kernel builds fine now.
Tested-by: Aleksandr Nogikh <nogikh@google.com>
On Fri, Aug 4, 2023 at 9:38 AM Guido Günther <agx@sigxcpu.org> wrote:
>
> Hi,
> On Thu, Aug 03, 2023 at 08:01:37PM -0700, Randy Dunlap wrote:
> > Three DRM bridge drivers select GENERIC_PHY_MIPI_DPHY when GENERIC_PHY
> > might not be set. This causes Kconfig warnings and a build error.
> >
> > WARNING: unmet direct dependencies detected for GENERIC_PHY_MIPI_DPHY
> > Depends on [n]: GENERIC_PHY [=n]
> > Selected by [y]:
> > - DRM_NWL_MIPI_DSI [=y] && DRM_BRIDGE [=y] && DRM [=y] && COMMON_CLK [=y] && OF [=y] && HAS_IOMEM [=y]
> > - DRM_SAMSUNG_DSIM [=y] && DRM [=y] && DRM_BRIDGE [=y] && COMMON_CLK [=y] && OF [=y] && HAS_IOMEM [=y]
> >
> > (drm/bridge/cadence/Kconfig was found by inspection.)
> >
> > aarch64-linux-ld: drivers/gpu/drm/bridge/samsung-dsim.o: in function `samsung_dsim_set_phy_ctrl':
> > drivers/gpu/drm/bridge/samsung-dsim.c:731: undefined reference to `phy_mipi_dphy_get_default_config_for_hsclk'
> >
> > Prevent these warnings and build error by also selecting GENERIC_PHY
> n> whenever selecting GENERIC_PHY_MIPI_DPHY.
> >
> > Fixes: fced5a364dee ("drm/bridge: cdns: Convert to phy framework")
> > Fixes: 44cfc6233447 ("drm/bridge: Add NWL MIPI DSI host controller support")
> > Fixes: 171b3b1e0f8b ("drm: bridge: samsung-dsim: Select GENERIC_PHY_MIPI_DPHY")
> > Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> > Reported-by: Aleksandr Nogikh <nogikh@google.com>
> > Link: lore.kernel.org/r/20230803144227.2187749-1-nogikh@google.com
> > Cc: Adam Ford <aford173@gmail.com>
> > Cc: Maxime Ripard <maxime.ripard@bootlin.com>
> > Cc: Guido Günther <agx@sigxcpu.org>
> > Cc: Robert Chiras <robert.chiras@nxp.com>
> > Cc: Sam Ravnborg <sam@ravnborg.org>
> > Cc: Neil Armstrong <neil.armstrong@linaro.org>
> > Cc: Andrzej Hajda <andrzej.hajda@intel.com>
> > Cc: Robert Foss <rfoss@kernel.org>
> > Cc: David Airlie <airlied@gmail.com>
> > Cc: Daniel Vetter <daniel@ffwll.ch>
> > Cc: dri-devel@lists.freedesktop.org
> > ---
> > drivers/gpu/drm/bridge/Kconfig | 2 ++
> > drivers/gpu/drm/bridge/cadence/Kconfig | 1 +
> > 2 files changed, 3 insertions(+)
> >
> > diff -- a/drivers/gpu/drm/bridge/cadence/Kconfig b/drivers/gpu/drm/bridge/cadence/Kconfig
> > --- a/drivers/gpu/drm/bridge/cadence/Kconfig
> > +++ b/drivers/gpu/drm/bridge/cadence/Kconfig
> > @@ -4,6 +4,7 @@ config DRM_CDNS_DSI
> > select DRM_KMS_HELPER
> > select DRM_MIPI_DSI
> > select DRM_PANEL_BRIDGE
> > + select GENERIC_PHY
> > select GENERIC_PHY_MIPI_DPHY
> > depends on OF
> > help
> > diff -- a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
> > --- a/drivers/gpu/drm/bridge/Kconfig
> > +++ b/drivers/gpu/drm/bridge/Kconfig
> > @@ -181,6 +181,7 @@ config DRM_NWL_MIPI_DSI
> > select DRM_KMS_HELPER
> > select DRM_MIPI_DSI
> > select DRM_PANEL_BRIDGE
> > + select GENERIC_PHY
> > select GENERIC_PHY_MIPI_DPHY
> > select MFD_SYSCON
> > select MULTIPLEXER
> > @@ -227,6 +228,7 @@ config DRM_SAMSUNG_DSIM
> > select DRM_KMS_HELPER
> > select DRM_MIPI_DSI
> > select DRM_PANEL_BRIDGE
> > + select GENERIC_PHY
> > select GENERIC_PHY_MIPI_DPHY
> > help
> > The Samsung MIPI DSIM bridge controller driver.
> >
>
> For NWL:
>
> Reviewed-by: Guido Günther <agx@sigxcpu.org>
>
> Cheers,
> -- Guido
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm: bridge: for GENERIC_PHY_MIPI_DPHY also select GENERIC_PHY
2023-08-04 3:01 [PATCH] drm: bridge: for GENERIC_PHY_MIPI_DPHY also select GENERIC_PHY Randy Dunlap
2023-08-04 7:38 ` Guido Günther
@ 2023-08-04 11:22 ` Adam Ford
2023-08-11 12:47 ` Robert Foss
2 siblings, 0 replies; 5+ messages in thread
From: Adam Ford @ 2023-08-04 11:22 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-kernel, Aleksandr Nogikh, Maxime Ripard,
Guido Günther, Robert Chiras, Sam Ravnborg, Neil Armstrong,
Andrzej Hajda, Robert Foss, David Airlie, Daniel Vetter,
dri-devel
On Thu, Aug 3, 2023 at 10:01 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> Three DRM bridge drivers select GENERIC_PHY_MIPI_DPHY when GENERIC_PHY
> might not be set. This causes Kconfig warnings and a build error.
>
> WARNING: unmet direct dependencies detected for GENERIC_PHY_MIPI_DPHY
> Depends on [n]: GENERIC_PHY [=n]
> Selected by [y]:
> - DRM_NWL_MIPI_DSI [=y] && DRM_BRIDGE [=y] && DRM [=y] && COMMON_CLK [=y] && OF [=y] && HAS_IOMEM [=y]
> - DRM_SAMSUNG_DSIM [=y] && DRM [=y] && DRM_BRIDGE [=y] && COMMON_CLK [=y] && OF [=y] && HAS_IOMEM [=y]
>
> (drm/bridge/cadence/Kconfig was found by inspection.)
>
> aarch64-linux-ld: drivers/gpu/drm/bridge/samsung-dsim.o: in function `samsung_dsim_set_phy_ctrl':
> drivers/gpu/drm/bridge/samsung-dsim.c:731: undefined reference to `phy_mipi_dphy_get_default_config_for_hsclk'
>
> Prevent these warnings and build error by also selecting GENERIC_PHY
> whenever selecting GENERIC_PHY_MIPI_DPHY.
>
Reviewed-by: Adam Ford <aford173@gmail.com>
> Fixes: fced5a364dee ("drm/bridge: cdns: Convert to phy framework")
> Fixes: 44cfc6233447 ("drm/bridge: Add NWL MIPI DSI host controller support")
> Fixes: 171b3b1e0f8b ("drm: bridge: samsung-dsim: Select GENERIC_PHY_MIPI_DPHY")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: Aleksandr Nogikh <nogikh@google.com>
> Link: lore.kernel.org/r/20230803144227.2187749-1-nogikh@google.com
> Cc: Adam Ford <aford173@gmail.com>
> Cc: Maxime Ripard <maxime.ripard@bootlin.com>
> Cc: Guido Günther <agx@sigxcpu.org>
> Cc: Robert Chiras <robert.chiras@nxp.com>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: Neil Armstrong <neil.armstrong@linaro.org>
> Cc: Andrzej Hajda <andrzej.hajda@intel.com>
> Cc: Robert Foss <rfoss@kernel.org>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: dri-devel@lists.freedesktop.org
> ---
> drivers/gpu/drm/bridge/Kconfig | 2 ++
> drivers/gpu/drm/bridge/cadence/Kconfig | 1 +
> 2 files changed, 3 insertions(+)
>
> diff -- a/drivers/gpu/drm/bridge/cadence/Kconfig b/drivers/gpu/drm/bridge/cadence/Kconfig
> --- a/drivers/gpu/drm/bridge/cadence/Kconfig
> +++ b/drivers/gpu/drm/bridge/cadence/Kconfig
> @@ -4,6 +4,7 @@ config DRM_CDNS_DSI
> select DRM_KMS_HELPER
> select DRM_MIPI_DSI
> select DRM_PANEL_BRIDGE
> + select GENERIC_PHY
> select GENERIC_PHY_MIPI_DPHY
> depends on OF
> help
> diff -- a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
> --- a/drivers/gpu/drm/bridge/Kconfig
> +++ b/drivers/gpu/drm/bridge/Kconfig
> @@ -181,6 +181,7 @@ config DRM_NWL_MIPI_DSI
> select DRM_KMS_HELPER
> select DRM_MIPI_DSI
> select DRM_PANEL_BRIDGE
> + select GENERIC_PHY
> select GENERIC_PHY_MIPI_DPHY
> select MFD_SYSCON
> select MULTIPLEXER
> @@ -227,6 +228,7 @@ config DRM_SAMSUNG_DSIM
> select DRM_KMS_HELPER
> select DRM_MIPI_DSI
> select DRM_PANEL_BRIDGE
> + select GENERIC_PHY
> select GENERIC_PHY_MIPI_DPHY
> help
> The Samsung MIPI DSIM bridge controller driver.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm: bridge: for GENERIC_PHY_MIPI_DPHY also select GENERIC_PHY
2023-08-04 3:01 [PATCH] drm: bridge: for GENERIC_PHY_MIPI_DPHY also select GENERIC_PHY Randy Dunlap
2023-08-04 7:38 ` Guido Günther
2023-08-04 11:22 ` Adam Ford
@ 2023-08-11 12:47 ` Robert Foss
2 siblings, 0 replies; 5+ messages in thread
From: Robert Foss @ 2023-08-11 12:47 UTC (permalink / raw)
To: Randy Dunlap, linux-kernel
Cc: Robert Foss, David Airlie, Andrzej Hajda, Adam Ford,
Neil Armstrong, Robert Chiras, Sam Ravnborg, Guido Günther,
dri-devel, Aleksandr Nogikh, Maxime Ripard, Daniel Vetter
On Thu, 3 Aug 2023 20:01:37 -0700, Randy Dunlap wrote:
> Three DRM bridge drivers select GENERIC_PHY_MIPI_DPHY when GENERIC_PHY
> might not be set. This causes Kconfig warnings and a build error.
>
> WARNING: unmet direct dependencies detected for GENERIC_PHY_MIPI_DPHY
> Depends on [n]: GENERIC_PHY [=n]
> Selected by [y]:
> - DRM_NWL_MIPI_DSI [=y] && DRM_BRIDGE [=y] && DRM [=y] && COMMON_CLK [=y] && OF [=y] && HAS_IOMEM [=y]
> - DRM_SAMSUNG_DSIM [=y] && DRM [=y] && DRM_BRIDGE [=y] && COMMON_CLK [=y] && OF [=y] && HAS_IOMEM [=y]
>
> [...]
Applied, thanks!
[1/1] drm: bridge: for GENERIC_PHY_MIPI_DPHY also select GENERIC_PHY
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=96413b355a49
Rob
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-08-11 12:47 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-04 3:01 [PATCH] drm: bridge: for GENERIC_PHY_MIPI_DPHY also select GENERIC_PHY Randy Dunlap
2023-08-04 7:38 ` Guido Günther
2023-08-04 9:35 ` Aleksandr Nogikh
2023-08-04 11:22 ` Adam Ford
2023-08-11 12:47 ` Robert Foss
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®