From: Lee Jones <lee@kernel.org>
To: Pavel Machek <pavel@ucw.cz>, Lee Jones <lee@kernel.org>,
Stephan Gerhold <stephan@gerhold.net>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Nikita Travkin <nikita@trvn.ru>,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, "Lin,
Meng-Bo" <linmengbo0689@protonmail.com>
Subject: Re: [PATCH v3 0/3] leds: aw2013: Document interrupt and pull-up supply
Date: Fri, 18 Aug 2023 16:47:36 +0100 [thread overview]
Message-ID: <169237365663.1285443.14239471615825184081.b4-ty@kernel.org> (raw)
In-Reply-To: <20230815-aw2013-vio-v3-0-2505296b0856@gerhold.net>
On Tue, 15 Aug 2023 19:21:03 +0200, Stephan Gerhold wrote:
> AW2013 has an optional interrupt pin "INTN" which is used to report
> completion of started operations (e.g. power up or LED breath effects).
> The driver does not use it (yet) but it should be already described for
> completeness inside the DT schema.
>
> Since the interrupt and I2C lines operate in open drain low active mode
> a pull-up supply is needed for correct operation. Unfortunately there
> is no ideal place to describe it in the DT: The pull-up needed for the
> I2C lines could be described on the I2C bus. However, the pull-up
> needed for the interrupt line belongs neither directly to the interrupt
> controller nor to AW2013. Since the AW2013 driver will be typically in
> control of the power management and interrupt masking it makes more
> sense to describe it inside the AW2013 device tree node.
>
> [...]
Applied, thanks!
[1/3] dt-bindings: leds: aw2013: Document interrupt
commit: 9422bcf125b94e553c795af4f6c59d8e8fd8affa
[2/3] dt-bindings: leds: Document pull-up supply for interrupt and I2C
commit: 2cccb179addedff6a5234e37237fc6b22d9217d4
[3/3] leds: aw2013: Enable pull-up supply for interrupt and I2C
commit: baca986e1f2c31f8e4b2a6d99d47c3bc844033e8
--
Lee Jones [李琼斯]
prev parent reply other threads:[~2023-08-18 15:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-15 17:21 Stephan Gerhold
2023-08-15 17:21 ` [PATCH v3 1/3] dt-bindings: leds: aw2013: Document interrupt Stephan Gerhold
2023-08-15 20:31 ` Krzysztof Kozlowski
2023-08-15 17:21 ` [PATCH v3 2/3] dt-bindings: leds: Document pull-up supply for interrupt and I2C Stephan Gerhold
2023-08-15 20:31 ` Krzysztof Kozlowski
2023-08-15 17:21 ` [PATCH v3 3/3] leds: aw2013: Enable " Stephan Gerhold
2023-08-16 5:38 ` [PATCH v3 0/3] leds: aw2013: Document interrupt and pull-up supply Nikita Travkin
2023-08-18 15:47 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169237365663.1285443.14239471615825184081.b4-ty@kernel.org \
--to=lee@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linmengbo0689@protonmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=nikita@trvn.ru \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=stephan@gerhold.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®