From: Michael Kelley <mikelley@microsoft.com>
To: kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org,
decui@microsoft.com, tglx@linutronix.de, mingo@redhat.com,
bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com,
luto@kernel.org, peterz@infradead.org, thomas.lendacky@amd.com,
sathyanarayanan.kuppuswamy@linux.intel.com,
kirill.shutemov@linux.intel.com, seanjc@google.com,
rick.p.edgecombe@intel.com, linux-kernel@vger.kernel.org,
linux-hyperv@vger.kernel.org, x86@kernel.org
Cc: mikelley@microsoft.com
Subject: [PATCH 4/5] x86/mm: Remove unnecessary call layer for __set_memory_enc_pgtable()
Date: Fri, 29 Sep 2023 11:19:08 -0700 [thread overview]
Message-ID: <1696011549-28036-5-git-send-email-mikelley@microsoft.com> (raw)
In-Reply-To: <1696011549-28036-1-git-send-email-mikelley@microsoft.com>
__set_memory_enc_pgtable() is only called from __set_memory_enc_dec()
after doing a simple validation check. Prior to commit 812b0597fb40,
__set_memory_enc_dec() did more complex checking, but now the code
can be simplified by collapsing the two functions.
No functional change.
Signed-off-by: Michael Kelley <mikelley@microsoft.com>
---
arch/x86/mm/pat/set_memory.c | 15 +++++----------
1 file changed, 5 insertions(+), 10 deletions(-)
diff --git a/arch/x86/mm/pat/set_memory.c b/arch/x86/mm/pat/set_memory.c
index d062e01..1578077 100644
--- a/arch/x86/mm/pat/set_memory.c
+++ b/arch/x86/mm/pat/set_memory.c
@@ -2131,15 +2131,18 @@ int set_memory_global(unsigned long addr, int numpages)
}
/*
- * __set_memory_enc_pgtable() is used for the hypervisors that get
+ * __set_memory_enc_dec() is used for the hypervisors that get
* informed about "encryption" status via page tables.
*/
-static int __set_memory_enc_pgtable(unsigned long addr, int numpages, bool enc)
+static int __set_memory_enc_dec(unsigned long addr, int numpages, bool enc)
{
pgprot_t empty = __pgprot(0);
struct cpa_data cpa;
int ret;
+ if (!cc_platform_has(CC_ATTR_MEM_ENCRYPT))
+ return 0;
+
/* Should not be working on unaligned addresses */
if (WARN_ONCE(addr & ~PAGE_MASK, "misaligned address: %#lx\n", addr))
addr &= PAGE_MASK;
@@ -2200,14 +2203,6 @@ static int __set_memory_enc_pgtable(unsigned long addr, int numpages, bool enc)
return set_memory_p(&addr, numpages);
}
-static int __set_memory_enc_dec(unsigned long addr, int numpages, bool enc)
-{
- if (cc_platform_has(CC_ATTR_MEM_ENCRYPT))
- return __set_memory_enc_pgtable(addr, numpages, enc);
-
- return 0;
-}
-
int set_memory_encrypted(unsigned long addr, int numpages)
{
return __set_memory_enc_dec(addr, numpages, true);
--
1.8.3.1
next prev parent reply other threads:[~2023-09-29 18:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-29 18:19 [PATCH 0/5] x86/coco: Mark CoCo VM pages not present when changing encrypted state Michael Kelley
2023-09-29 18:19 ` [PATCH 1/5] x86/coco: Use slow_virt_to_phys() in page transition hypervisor callbacks Michael Kelley
2023-10-02 15:52 ` Tom Lendacky
2023-09-29 18:19 ` [PATCH 2/5] x86/mm: Don't do a TLB flush if changing a PTE that isn't marked present Michael Kelley
2023-09-29 18:19 ` [PATCH 3/5] x86/mm: Mark CoCo VM pages not present while changing encrypted state Michael Kelley
2023-09-29 23:13 ` kernel test robot
2023-10-02 16:35 ` Tom Lendacky
2023-10-02 18:59 ` Tom Lendacky
2023-10-02 20:43 ` Michael Kelley (LINUX)
2023-10-17 0:35 ` Michael Kelley (LINUX)
2023-09-29 18:19 ` Michael Kelley [this message]
2023-09-29 18:19 ` [PATCH 5/5] x86/mm: Add comments about errors in set_memory_decrypted()/encrypted() Michael Kelley
2023-10-02 15:42 ` [PATCH 0/5] x86/coco: Mark CoCo VM pages not present when changing encrypted state Tom Lendacky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1696011549-28036-5-git-send-email-mikelley@microsoft.com \
--to=mikelley@microsoft.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=hpa@zytor.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rick.p.edgecombe@intel.com \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=wei.liu@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®