* [PATCH 1/2] dt-bindings: serial: fix regex pattern for matching serial node children
@ 2023-10-05 9:32 Krzysztof Kozlowski
2023-10-05 9:32 ` [PATCH 2/2] dt-bindings: serial: allow naming of Bluetooth with GPS children Krzysztof Kozlowski
2023-10-06 16:58 ` [PATCH 1/2] dt-bindings: serial: fix regex pattern for matching serial node children Rob Herring
0 siblings, 2 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2023-10-05 9:32 UTC (permalink / raw)
To: Rob Herring, Greg Kroah-Hartman, Jiri Slaby, Krzysztof Kozlowski,
Conor Dooley, Linus Walleij, linux-serial, linux-kernel,
devicetree
Cc: Krzysztof Kozlowski, Andreas Kemnade
The regular expression pattern for matching serial node children should
accept only nodes starting and ending with the set of words: bluetooth,
gnss, gps or mcu. Add missing brackets to enforce such matching.
Fixes: 0c559bc8abfb ("dt-bindings: serial: restrict possible child node names")
Reported-by: Andreas Kemnade <andreas@kemnade.info>
Closes: https://lore.kernel.org/all/20231004170021.36b32465@aktux/
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Documentation/devicetree/bindings/serial/serial.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/serial/serial.yaml b/Documentation/devicetree/bindings/serial/serial.yaml
index ea277560a596..5727bd549dec 100644
--- a/Documentation/devicetree/bindings/serial/serial.yaml
+++ b/Documentation/devicetree/bindings/serial/serial.yaml
@@ -96,7 +96,7 @@ then:
rts-gpios: false
patternProperties:
- "^bluetooth|gnss|gps|mcu$":
+ "^(bluetooth|gnss|gps|mcu)$":
if:
type: object
then:
--
2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 2/2] dt-bindings: serial: allow naming of Bluetooth with GPS children
2023-10-05 9:32 [PATCH 1/2] dt-bindings: serial: fix regex pattern for matching serial node children Krzysztof Kozlowski
@ 2023-10-05 9:32 ` Krzysztof Kozlowski
2023-10-06 16:59 ` Rob Herring
2023-10-06 16:58 ` [PATCH 1/2] dt-bindings: serial: fix regex pattern for matching serial node children Rob Herring
1 sibling, 1 reply; 4+ messages in thread
From: Krzysztof Kozlowski @ 2023-10-05 9:32 UTC (permalink / raw)
To: Rob Herring, Greg Kroah-Hartman, Jiri Slaby, Krzysztof Kozlowski,
Conor Dooley, Linus Walleij, linux-serial, linux-kernel,
devicetree
Cc: Krzysztof Kozlowski, Andreas Kemnade
Some devices attached over UART combine Bluetooth and GNSS/GPS receiver,
so allow "bluetooth-gnss" naming of children nodes.
Link: https://lore.kernel.org/all/20231004070309.2408745-1-andreas@kemnade.info/
Suggested-by: Andreas Kemnade <andreas@kemnade.info>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Documentation/devicetree/bindings/serial/serial.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/serial/serial.yaml b/Documentation/devicetree/bindings/serial/serial.yaml
index 5727bd549dec..468af429c3e6 100644
--- a/Documentation/devicetree/bindings/serial/serial.yaml
+++ b/Documentation/devicetree/bindings/serial/serial.yaml
@@ -96,7 +96,7 @@ then:
rts-gpios: false
patternProperties:
- "^(bluetooth|gnss|gps|mcu)$":
+ "^(bluetooth|bluetooth-gnss|gnss|gps|mcu)$":
if:
type: object
then:
--
2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] dt-bindings: serial: fix regex pattern for matching serial node children
2023-10-05 9:32 [PATCH 1/2] dt-bindings: serial: fix regex pattern for matching serial node children Krzysztof Kozlowski
2023-10-05 9:32 ` [PATCH 2/2] dt-bindings: serial: allow naming of Bluetooth with GPS children Krzysztof Kozlowski
@ 2023-10-06 16:58 ` Rob Herring
1 sibling, 0 replies; 4+ messages in thread
From: Rob Herring @ 2023-10-06 16:58 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Linus Walleij, Andreas Kemnade, Krzysztof Kozlowski,
Greg Kroah-Hartman, linux-serial, linux-kernel, devicetree,
Conor Dooley, Jiri Slaby
On Thu, 05 Oct 2023 11:32:46 +0200, Krzysztof Kozlowski wrote:
> The regular expression pattern for matching serial node children should
> accept only nodes starting and ending with the set of words: bluetooth,
> gnss, gps or mcu. Add missing brackets to enforce such matching.
>
> Fixes: 0c559bc8abfb ("dt-bindings: serial: restrict possible child node names")
> Reported-by: Andreas Kemnade <andreas@kemnade.info>
> Closes: https://lore.kernel.org/all/20231004170021.36b32465@aktux/
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> Documentation/devicetree/bindings/serial/serial.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] dt-bindings: serial: allow naming of Bluetooth with GPS children
2023-10-05 9:32 ` [PATCH 2/2] dt-bindings: serial: allow naming of Bluetooth with GPS children Krzysztof Kozlowski
@ 2023-10-06 16:59 ` Rob Herring
0 siblings, 0 replies; 4+ messages in thread
From: Rob Herring @ 2023-10-06 16:59 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Jiri Slaby, linux-kernel, devicetree, linux-serial, Conor Dooley,
Andreas Kemnade, Greg Kroah-Hartman, Linus Walleij,
Krzysztof Kozlowski
On Thu, 05 Oct 2023 11:32:47 +0200, Krzysztof Kozlowski wrote:
> Some devices attached over UART combine Bluetooth and GNSS/GPS receiver,
> so allow "bluetooth-gnss" naming of children nodes.
>
> Link: https://lore.kernel.org/all/20231004070309.2408745-1-andreas@kemnade.info/
> Suggested-by: Andreas Kemnade <andreas@kemnade.info>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> Documentation/devicetree/bindings/serial/serial.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-10-06 16:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-05 9:32 [PATCH 1/2] dt-bindings: serial: fix regex pattern for matching serial node children Krzysztof Kozlowski
2023-10-05 9:32 ` [PATCH 2/2] dt-bindings: serial: allow naming of Bluetooth with GPS children Krzysztof Kozlowski
2023-10-06 16:59 ` Rob Herring
2023-10-06 16:58 ` [PATCH 1/2] dt-bindings: serial: fix regex pattern for matching serial node children Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®