mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] irqchip/stm32-exti: add missing DT IRQ flag translation
@ 2023-10-03 16:20 Ben Wolsieffer
  2023-10-07 12:00 ` [irqchip: irq/irqchip-fixes] " irqchip-bot for Ben Wolsieffer
  0 siblings, 1 reply; 2+ messages in thread
From: Ben Wolsieffer @ 2023-10-03 16:20 UTC (permalink / raw)
  To: linux-stm32, linux-arm-kernel, linux-kernel
  Cc: Thomas Gleixner, Marc Zyngier, Maxime Coquelin, Alexandre Torgue,
	Ben Wolsieffer

The STM32F4/7 EXTI driver was missing the xlate callback, so IRQ trigger
flags specified in the device tree were being ignored. This was
preventing the RTC alarm interrupt from working, because it must be set
to trigger on the rising edge to function correctly.

Signed-off-by: Ben Wolsieffer <ben.wolsieffer@hefring.com>
---
 drivers/irqchip/irq-stm32-exti.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/irqchip/irq-stm32-exti.c b/drivers/irqchip/irq-stm32-exti.c
index b5fa76ce5046..cb4b195bc849 100644
--- a/drivers/irqchip/irq-stm32-exti.c
+++ b/drivers/irqchip/irq-stm32-exti.c
@@ -459,6 +459,7 @@ static const struct irq_domain_ops irq_exti_domain_ops = {
 	.map	= irq_map_generic_chip,
 	.alloc  = stm32_exti_alloc,
 	.free	= stm32_exti_free,
+	.xlate	= irq_domain_xlate_twocell,
 };
 
 static void stm32_irq_ack(struct irq_data *d)
-- 
2.42.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [irqchip: irq/irqchip-fixes] irqchip/stm32-exti: add missing DT IRQ flag translation
  2023-10-03 16:20 [PATCH] irqchip/stm32-exti: add missing DT IRQ flag translation Ben Wolsieffer
@ 2023-10-07 12:00 ` irqchip-bot for Ben Wolsieffer
  0 siblings, 0 replies; 2+ messages in thread
From: irqchip-bot for Ben Wolsieffer @ 2023-10-07 12:00 UTC (permalink / raw)
  To: linux-kernel; +Cc: Ben Wolsieffer, Marc Zyngier, tglx

The following commit has been merged into the irq/irqchip-fixes branch of irqchip:

Commit-ID:     8554cba1d6dbd3c74e0549e28ddbaccbb1d6b30a
Gitweb:        https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/8554cba1d6dbd3c74e0549e28ddbaccbb1d6b30a
Author:        Ben Wolsieffer <ben.wolsieffer@hefring.com>
AuthorDate:    Tue, 03 Oct 2023 12:20:03 -04:00
Committer:     Marc Zyngier <maz@kernel.org>
CommitterDate: Sat, 07 Oct 2023 12:47:12 +01:00

irqchip/stm32-exti: add missing DT IRQ flag translation

The STM32F4/7 EXTI driver was missing the xlate callback, so IRQ trigger
flags specified in the device tree were being ignored. This was
preventing the RTC alarm interrupt from working, because it must be set
to trigger on the rising edge to function correctly.

Signed-off-by: Ben Wolsieffer <ben.wolsieffer@hefring.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20231003162003.1649967-1-ben.wolsieffer@hefring.com
---
 drivers/irqchip/irq-stm32-exti.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/irqchip/irq-stm32-exti.c b/drivers/irqchip/irq-stm32-exti.c
index d8ba5fb..971240e 100644
--- a/drivers/irqchip/irq-stm32-exti.c
+++ b/drivers/irqchip/irq-stm32-exti.c
@@ -460,6 +460,7 @@ static const struct irq_domain_ops irq_exti_domain_ops = {
 	.map	= irq_map_generic_chip,
 	.alloc  = stm32_exti_alloc,
 	.free	= stm32_exti_free,
+	.xlate	= irq_domain_xlate_twocell,
 };
 
 static void stm32_irq_ack(struct irq_data *d)

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-10-07 12:01 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-03 16:20 [PATCH] irqchip/stm32-exti: add missing DT IRQ flag translation Ben Wolsieffer
2023-10-07 12:00 ` [irqchip: irq/irqchip-fixes] " irqchip-bot for Ben Wolsieffer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®