mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 0/1] Add software timestamp capabilities to xen-netback device
@ 2023-10-10 14:26 Luca Fancellu
  2023-10-10 14:26 ` [PATCH 1/1] xen-netback: add software timestamp capabilities Luca Fancellu
  2023-10-13  9:30 ` [PATCH 0/1] Add software timestamp capabilities to xen-netback device patchwork-bot+netdevbpf
  0 siblings, 2 replies; 3+ messages in thread
From: Luca Fancellu @ 2023-10-10 14:26 UTC (permalink / raw)
  To: linux-kernel; +Cc: Wei Liu, Paul Durrant, xen-devel, netdev, Rahul Singh

Hi all,

during some experiment using PTP (ptp4l) between a Dom0 domain and a DomU guest,
I noticed that the virtual interface brought up by the toolstack was not able
to be used as ptp4l interface on the Dom0 side, a brief investigation on the
drivers revealed that the backend driver doesn't have the SW timestamp
capabilities, so in order to provide them, I'm sending this patch.

Luca Fancellu (1):
  xen-netback: add software timestamp capabilities

 drivers/net/xen-netback/interface.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)


base-commit: cb0856346a60fe3eb837ba5e73588a41f81ac05f
-- 
2.34.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 1/1] xen-netback: add software timestamp capabilities
  2023-10-10 14:26 [PATCH 0/1] Add software timestamp capabilities to xen-netback device Luca Fancellu
@ 2023-10-10 14:26 ` Luca Fancellu
  2023-10-13  9:30 ` [PATCH 0/1] Add software timestamp capabilities to xen-netback device patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: Luca Fancellu @ 2023-10-10 14:26 UTC (permalink / raw)
  To: linux-kernel; +Cc: Wei Liu, Paul Durrant, xen-devel, netdev, Rahul Singh

Add software timestamp capabilities to the xen-netback driver
by advertising it on the struct ethtool_ops and calling
skb_tx_timestamp before passing the buffer to the queue.

Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
---
 drivers/net/xen-netback/interface.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/net/xen-netback/interface.c b/drivers/net/xen-netback/interface.c
index f3f2c07423a6..b71158967123 100644
--- a/drivers/net/xen-netback/interface.c
+++ b/drivers/net/xen-netback/interface.c
@@ -254,6 +254,9 @@ xenvif_start_xmit(struct sk_buff *skb, struct net_device *dev)
 	if (vif->hash.alg == XEN_NETIF_CTRL_HASH_ALGORITHM_NONE)
 		skb_clear_hash(skb);
 
+	/* timestamp packet in software */
+	skb_tx_timestamp(skb);
+
 	if (!xenvif_rx_queue_tail(queue, skb))
 		goto drop;
 
@@ -460,7 +463,7 @@ static void xenvif_get_strings(struct net_device *dev, u32 stringset, u8 * data)
 
 static const struct ethtool_ops xenvif_ethtool_ops = {
 	.get_link	= ethtool_op_get_link,
-
+	.get_ts_info 	= ethtool_op_get_ts_info,
 	.get_sset_count = xenvif_get_sset_count,
 	.get_ethtool_stats = xenvif_get_ethtool_stats,
 	.get_strings = xenvif_get_strings,
-- 
2.34.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 0/1] Add software timestamp capabilities to xen-netback device
  2023-10-10 14:26 [PATCH 0/1] Add software timestamp capabilities to xen-netback device Luca Fancellu
  2023-10-10 14:26 ` [PATCH 1/1] xen-netback: add software timestamp capabilities Luca Fancellu
@ 2023-10-13  9:30 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-10-13  9:30 UTC (permalink / raw)
  To: Luca Fancellu; +Cc: linux-kernel, wei.liu, paul, xen-devel, netdev, rahul.singh

Hello:

This patch was applied to netdev/net-next.git (main)
by David S. Miller <davem@davemloft.net>:

On Tue, 10 Oct 2023 15:26:29 +0100 you wrote:
> Hi all,
> 
> during some experiment using PTP (ptp4l) between a Dom0 domain and a DomU guest,
> I noticed that the virtual interface brought up by the toolstack was not able
> to be used as ptp4l interface on the Dom0 side, a brief investigation on the
> drivers revealed that the backend driver doesn't have the SW timestamp
> capabilities, so in order to provide them, I'm sending this patch.
> 
> [...]

Here is the summary with links:
  - [1/1] xen-netback: add software timestamp capabilities
    https://git.kernel.org/netdev/net-next/c/0b38d2ec2282

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-10-13  9:30 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-10 14:26 [PATCH 0/1] Add software timestamp capabilities to xen-netback device Luca Fancellu
2023-10-10 14:26 ` [PATCH 1/1] xen-netback: add software timestamp capabilities Luca Fancellu
2023-10-13  9:30 ` [PATCH 0/1] Add software timestamp capabilities to xen-netback device patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®