* [PATCH] RISC-V: Remove __init on unaligned_emulation_finish()
@ 2023-11-06 23:11 Evan Green
2023-11-08 15:10 ` patchwork-bot+linux-riscv
0 siblings, 1 reply; 2+ messages in thread
From: Evan Green @ 2023-11-06 23:11 UTC (permalink / raw)
To: Palmer Dabbelt
Cc: cleger, Evan Green, Albert Ou, Björn Töpel,
Palmer Dabbelt, Paul Walmsley, linux-kernel, linux-riscv
This function shouldn't be __init, since it's called during hotplug. The
warning says it well enough:
WARNING: modpost: vmlinux: section mismatch in reference:
check_unaligned_access_all_cpus+0x13a (section: .text) ->
unaligned_emulation_finish (section: .init.text)
Signed-off-by: Evan Green <evan@rivosinc.com>
Fixes: 71c54b3d169d ("riscv: report misaligned accesses emulation to hwprobe")
---
arch/riscv/kernel/traps_misaligned.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/riscv/kernel/traps_misaligned.c b/arch/riscv/kernel/traps_misaligned.c
index bba301b5194d..5eba37147caa 100644
--- a/arch/riscv/kernel/traps_misaligned.c
+++ b/arch/riscv/kernel/traps_misaligned.c
@@ -625,7 +625,7 @@ bool check_unaligned_access_emulated(int cpu)
return misaligned_emu_detected;
}
-void __init unaligned_emulation_finish(void)
+void unaligned_emulation_finish(void)
{
int cpu;
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] RISC-V: Remove __init on unaligned_emulation_finish()
2023-11-06 23:11 [PATCH] RISC-V: Remove __init on unaligned_emulation_finish() Evan Green
@ 2023-11-08 15:10 ` patchwork-bot+linux-riscv
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+linux-riscv @ 2023-11-08 15:10 UTC (permalink / raw)
To: Evan Green
Cc: linux-riscv, palmer, cleger, aou, bjorn, palmer, paul.walmsley,
linux-kernel
Hello:
This patch was applied to riscv/linux.git (for-next)
by Palmer Dabbelt <palmer@rivosinc.com>:
On Mon, 6 Nov 2023 15:11:05 -0800 you wrote:
> This function shouldn't be __init, since it's called during hotplug. The
> warning says it well enough:
>
> WARNING: modpost: vmlinux: section mismatch in reference:
> check_unaligned_access_all_cpus+0x13a (section: .text) ->
> unaligned_emulation_finish (section: .init.text)
>
> [...]
Here is the summary with links:
- RISC-V: Remove __init on unaligned_emulation_finish()
https://git.kernel.org/riscv/c/6eb7a6445b76
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-11-08 15:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-06 23:11 [PATCH] RISC-V: Remove __init on unaligned_emulation_finish() Evan Green
2023-11-08 15:10 ` patchwork-bot+linux-riscv
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®