From: "Shuah Khan (Samsung OSG)" <shuah@kernel.org>
To: shuah@kernel.org
Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 7/7] selftests: kselftest: change KSFT_SKIP=4 instead of KSFT_PASS
Date: Tue, 1 May 2018 16:54:39 -0600 [thread overview]
Message-ID: <16ce561ed5b34d1066d2e9de747ccdf0550078e7.1525212671.git.shuah@kernel.org> (raw)
In-Reply-To: <cover.1525212671.git.shuah@kernel.org>
In-Reply-To: <cover.1525212671.git.shuah@kernel.org>
KSFT_SKIP points to KSFT_PASS resulting in reporting skipped tests as
Passed, when test programs exit with KSFT_SKIP or call ksft_exit_skip().
If tests are skipped because of unmet dependencies and/or unsupported
configuration, reporting them as passed leads to too many false positives.
Fix it to return a skip code of 4 to clearly differentiate the skipped
tests.
Signed-off-by: Shuah Khan (Samsung OSG) <shuah@kernel.org>
---
tools/testing/selftests/kselftest.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/kselftest.h b/tools/testing/selftests/kselftest.h
index 1b9d8ecdebce..15e6b75fc3a5 100644
--- a/tools/testing/selftests/kselftest.h
+++ b/tools/testing/selftests/kselftest.h
@@ -20,7 +20,7 @@
#define KSFT_XFAIL 2
#define KSFT_XPASS 3
/* Treat skip as pass */
-#define KSFT_SKIP KSFT_PASS
+#define KSFT_SKIP 4
/* counters */
struct ksft_count {
--
2.14.1
prev parent reply other threads:[~2018-05-01 22:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-01 22:54 [PATCH 0/7] Kselftest framework SKIP handling Shuah Khan (Samsung OSG)
2018-05-01 22:54 ` [PATCH 1/7] selftests: lib.mk: cleanup RUN_TESTS define and make it readable Shuah Khan (Samsung OSG)
2018-05-01 22:54 ` [PATCH 2/7] selftests: lib.mk: add SKIP handling to RUN_TESTS define Shuah Khan (Samsung OSG)
2018-05-01 22:54 ` [PATCH 3/7] selftests: lib.mk: move running and printing result to a new function Shuah Khan (Samsung OSG)
2018-05-01 22:54 ` [PATCH 4/7] selftests: lib.mk: Include test suite name in the RUN_TESTS output Shuah Khan (Samsung OSG)
2018-05-01 22:54 ` [PATCH 5/7] selftests: lib.mk: add SKIP handling and test suite name to EMIT_TESTS Shuah Khan (Samsung OSG)
2018-05-01 22:54 ` [PATCH 6/7] selftests: lib.mk: add test execute bit check " Shuah Khan (Samsung OSG)
2018-05-01 22:54 ` Shuah Khan (Samsung OSG) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16ce561ed5b34d1066d2e9de747ccdf0550078e7.1525212671.git.shuah@kernel.org \
--to=shuah@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®