From: "Shuah Khan (Samsung OSG)" <shuah@kernel.org>
To: shuah@kernel.org
Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 4/7] selftests: lib.mk: Include test suite name in the RUN_TESTS output
Date: Tue, 1 May 2018 16:54:36 -0600 [thread overview]
Message-ID: <87a45d125d28566835bfe836732c40805055b665.1525212671.git.shuah@kernel.org> (raw)
In-Reply-To: <cover.1525212671.git.shuah@kernel.org>
In-Reply-To: <cover.1525212671.git.shuah@kernel.org>
Currently just the test name is printed in the RUN_TESTS output. For
example, when raw_skew sub-test from timers tests in run, the output
shows just raw_skew. Include main test name when printing sub-test
results.
In addition, remove duplicate strings for printing common information
with a new for the test header information.
Before the change:
selftests: raw_skew
========================================
WARNING: ADJ_OFFSET in progress, this will cause inaccurate results
Estimating clock drift: -20.616(est) -20.586(act) [OK]
Pass 0 Fail 0 Xfail 0 Xpass 0 Skip 0 Error 0
1..0
ok 1..7 selftests: raw_skew [PASS]
After the change:
selftests: timers: raw_skew
========================================
WARNING: ADJ_OFFSET in progress, this will cause inaccurate results
Estimating clock drift: -19.794(est) -19.896(act) [OK]
Pass 0 Fail 0 Xfail 0 Xpass 0 Skip 0 Error 0
1..0
ok 1..7 selftests: timers: raw_skew [PASS]
Signed-off-by: Shuah Khan (Samsung OSG) <shuah@kernel.org>
---
tools/testing/selftests/lib.mk | 19 ++++++++++---------
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk
index dd516f92f7c2..eb2be6dabbda 100644
--- a/tools/testing/selftests/lib.mk
+++ b/tools/testing/selftests/lib.mk
@@ -20,26 +20,27 @@ all: $(TEST_GEN_PROGS) $(TEST_GEN_PROGS_EXTENDED) $(TEST_GEN_FILES)
.ONESHELL:
define RUN_TEST_PRINT_RESULT
- echo "selftests: $$BASENAME_TEST"; \
+ TEST_HDR_MSG="selftests: "`basename $$PWD`:" $$BASENAME_TEST"; \
+ echo $$TEST_HDR_MSG; \
echo "========================================"; \
if [ ! -x $$TEST ]; then \
- echo "selftests: Warning: file $$BASENAME_TEST is not executable, correct this.";\
- echo "not ok 1..$$test_num selftests: $$BASENAME_TEST [FAIL]"; \
+ echo "$$TEST_HDR_MSG: Warning: file $$BASENAME_TEST is not executable, correct this.";\
+ echo "not ok 1..$$test_num $$TEST_HDR_MSG [FAIL]"; \
else \
cd `dirname $$TEST` > /dev/null; \
if [ "X$(summary)" != "X" ]; then \
(./$$BASENAME_TEST > /tmp/$$BASENAME_TEST 2>&1 && \
- echo "ok 1..$$test_num selftests: $$BASENAME_TEST [PASS]") || \
+ echo "ok 1..$$test_num $$TEST_HDR_MSG [PASS]") || \
(if [ $$? -eq $$skip ]; then \
- echo "not ok 1..$$test_num selftests: $$BASENAME_TEST [SKIP]"; \
- else echo "not ok 1..$$test_num selftests: $$BASENAME_TEST [FAIL]"; \
+ echo "not ok 1..$$test_num $$TEST_HDR_MSG [SKIP]"; \
+ else echo "not ok 1..$$test_num $$TEST_HDR_MSG [FAIL]"; \
fi;) \
else \
(./$$BASENAME_TEST && \
- echo "ok 1..$$test_num selftests: $$BASENAME_TEST [PASS]") || \
+ echo "ok 1..$$test_num $$TEST_HDR_MSG [PASS]") || \
(if [ $$? -eq $$skip ]; then \
- echo "not ok 1..$$test_num selftests: $$BASENAME_TEST [SKIP]"; \
- else echo "not ok 1..$$test_num selftests: $$BASENAME_TEST [FAIL]"; \
+ echo "not ok 1..$$test_num $$TEST_HDR_MSG [SKIP]"; \
+ else echo "not ok 1..$$test_num $$TEST_HDR_MSG [FAIL]"; \
fi;) \
fi; \
cd - > /dev/null; \
--
2.14.1
next prev parent reply other threads:[~2018-05-01 22:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-01 22:54 [PATCH 0/7] Kselftest framework SKIP handling Shuah Khan (Samsung OSG)
2018-05-01 22:54 ` [PATCH 1/7] selftests: lib.mk: cleanup RUN_TESTS define and make it readable Shuah Khan (Samsung OSG)
2018-05-01 22:54 ` [PATCH 2/7] selftests: lib.mk: add SKIP handling to RUN_TESTS define Shuah Khan (Samsung OSG)
2018-05-01 22:54 ` [PATCH 3/7] selftests: lib.mk: move running and printing result to a new function Shuah Khan (Samsung OSG)
2018-05-01 22:54 ` Shuah Khan (Samsung OSG) [this message]
2018-05-01 22:54 ` [PATCH 5/7] selftests: lib.mk: add SKIP handling and test suite name to EMIT_TESTS Shuah Khan (Samsung OSG)
2018-05-01 22:54 ` [PATCH 6/7] selftests: lib.mk: add test execute bit check " Shuah Khan (Samsung OSG)
2018-05-01 22:54 ` [PATCH 7/7] selftests: kselftest: change KSFT_SKIP=4 instead of KSFT_PASS Shuah Khan (Samsung OSG)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a45d125d28566835bfe836732c40805055b665.1525212671.git.shuah@kernel.org \
--to=shuah@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®