[PATCH 0/2] clk: qcom: gcc-shikra: Add support for the USB3 DP PHY reset

[PATCH 0/2] clk: qcom: gcc-shikra: Add support for the USB3 DP PHY reset

[Imran Shaik]

Add bindings and driver support for GCC USB3 DP PHY reset on
Qualcomm Shikra SoC.

Signed-off-by: Imran Shaik <imran.shaik@oss.qualcomm.com>
---
Imran Shaik (2):
      dt-bindings: clock: qcom: Add the definition for the USB3 DP PHY reset
      clk: qcom: gcc-shikra: Add support for the USB3 DP PHY reset

 drivers/clk/qcom/gcc-shikra.c               | 1 +
 include/dt-bindings/clock/qcom,shikra-gcc.h | 1 +
 2 files changed, 2 insertions(+)
---
base-commit: 9974969c14031a097d6b45bcb7a06bb4aa525c40
change-id: 20260526-shikra-gcc-usb-resets-d50ff8a6c319
prerequisite-change-id: 20260429-shikra-gcc-rpmcc-clks-2094edfff3b0:v2
prerequisite-patch-id: 5a0fbdd458785da2d0e850c851a05046672ecadf
prerequisite-patch-id: 1f98e515a52bbeb25e2a960a804afe16c6a472a1
prerequisite-patch-id: a64476b2ba6e0f2a55928baf72ec32672ee0123c
prerequisite-patch-id: d0c8651205232862b40f942929e1efdaa3084eb3

Best regards,
-- 
Imran Shaik <imran.shaik@oss.qualcomm.com>

[PATCH 1/2] dt-bindings: clock: qcom: Add the definition for the USB3 DP PHY reset

[Imran Shaik]

Provide the GCC USB3 DP PHY reset definition in dt-bindings for the
Qualcomm Shikra SoC.

Signed-off-by: Imran Shaik <imran.shaik@oss.qualcomm.com>
---
 include/dt-bindings/clock/qcom,shikra-gcc.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/dt-bindings/clock/qcom,shikra-gcc.h b/include/dt-bindings/clock/qcom,shikra-gcc.h
index dc55e5652caae247359f869a998f81a785a82e0f..d3abaf541a33beaca4d5a2a8a0930f2a45ef8524 100644
--- a/include/dt-bindings/clock/qcom,shikra-gcc.h
+++ b/include/dt-bindings/clock/qcom,shikra-gcc.h
@@ -258,5 +258,6 @@
 #define GCC_VCODEC0_BCR						21
 #define GCC_VENUS_BCR						22
 #define GCC_VIDEO_INTERFACE_BCR					23
+#define GCC_USB3_DP_PHY_PRIM_BCR				24
 
 #endif

-- 
2.34.1

Re: [PATCH 1/2] dt-bindings: clock: qcom: Add the definition for the USB3 DP PHY reset

[Krzysztof Kozlowski]

On Tue, May 26, 2026 at 06:24:44PM +0530, Imran Shaik wrote:
> Provide the GCC USB3 DP PHY reset definition in dt-bindings for the
> Qualcomm Shikra SoC.
> 
> Signed-off-by: Imran Shaik <imran.shaik@oss.qualcomm.com>
> ---
>  include/dt-bindings/clock/qcom,shikra-gcc.h | 1 +

So just squash into the dependency.

Best regards,
Krzysztof

Re: [PATCH 1/2] dt-bindings: clock: qcom: Add the definition for the USB3 DP PHY reset

[Imran Shaik]

On 30-05-2026 04:59 pm, Krzysztof Kozlowski wrote:
> On Tue, May 26, 2026 at 06:24:44PM +0530, Imran Shaik wrote:
>> Provide the GCC USB3 DP PHY reset definition in dt-bindings for the
>> Qualcomm Shikra SoC.
>>
>> Signed-off-by: Imran Shaik <imran.shaik@oss.qualcomm.com>
>> ---
>>   include/dt-bindings/clock/qcom,shikra-gcc.h | 1 +
> 
> So just squash into the dependency.
> 

Sure, will squash these changes into the GCC series.

Thanks,
Imran

> Best regards,
> Krzysztof
> 

[PATCH 2/2] clk: qcom: gcc-shikra: Add support for the USB3 DP PHY reset

[Imran Shaik]

Add GCC USB3 DP PHY reset support for Qualcomm Shikra SoC.

Signed-off-by: Imran Shaik <imran.shaik@oss.qualcomm.com>
---
 drivers/clk/qcom/gcc-shikra.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/qcom/gcc-shikra.c b/drivers/clk/qcom/gcc-shikra.c
index fc1c90e7e7469818a4372e1bc192761096441221..f323ac5c6400c430b1c92cfc4f7a1550abf08de9 100644
--- a/drivers/clk/qcom/gcc-shikra.c
+++ b/drivers/clk/qcom/gcc-shikra.c
@@ -4331,6 +4331,7 @@ static const struct qcom_reset_map gcc_shikra_resets[] = {
 	[GCC_VCODEC0_BCR] = { 0x6d034 },
 	[GCC_VENUS_BCR] = { 0x6d018 },
 	[GCC_VIDEO_INTERFACE_BCR] = { 0x6e000 },
+	[GCC_USB3_DP_PHY_PRIM_BCR] = { 0x1b020 },
 };
 
 static struct clk_alpha_pll *gcc_shikra_plls[] = {

-- 
2.34.1

Re: [PATCH 2/2] clk: qcom: gcc-shikra: Add support for the USB3 DP PHY reset

[Dmitry Baryshkov]

On Tue, May 26, 2026 at 06:24:45PM +0530, Imran Shaik wrote:
> Add GCC USB3 DP PHY reset support for Qualcomm Shikra SoC.

Why was it not a part of the original submission?

For the change itself:

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>


> Signed-off-by: Imran Shaik <imran.shaik@oss.qualcomm.com>
> ---
>  drivers/clk/qcom/gcc-shikra.c | 1 +
>  1 file changed, 1 insertion(+)

-- 
With best wishes
Dmitry

Re: [PATCH 2/2] clk: qcom: gcc-shikra: Add support for the USB3 DP PHY reset

[Taniya Das]

On 5/26/2026 6:24 PM, Imran Shaik wrote:
> Signed-off-by: Imran Shaik <imran.shaik@oss.qualcomm.com>
> ---
>  drivers/clk/qcom/gcc-shikra.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/clk/qcom/gcc-shikra.c b/drivers/clk/qcom/gcc-shikra.c
> index fc1c90e7e7469818a4372e1bc192761096441221..f323ac5c6400c430b1c92cfc4f7a1550abf08de9 100644
> --- a/drivers/clk/qcom/gcc-shikra.c
> +++ b/drivers/clk/qcom/gcc-shikra.c
> @@ -4331,6 +4331,7 @@ static const struct qcom_reset_map gcc_shikra_resets[] = {
>  	[GCC_VCODEC0_BCR] = { 0x6d034 },
>  	[GCC_VENUS_BCR] = { 0x6d018 },
>  	[GCC_VIDEO_INTERFACE_BCR] = { 0x6e000 },
> +	[GCC_USB3_DP_PHY_PRIM_BCR] = { 0x1b020 },
>  };
>  

Reviewed-by: Taniya Das <taniya.das@oss.qualcomm.com>

-- 
Thanks,
Taniya Das

Re: [PATCH 2/2] clk: qcom: gcc-shikra: Add support for the USB3 DP PHY reset

[Konrad Dybcio]

On 5/26/26 2:54 PM, Imran Shaik wrote:
> Add GCC USB3 DP PHY reset support for Qualcomm Shikra SoC.
> 
> Signed-off-by: Imran Shaik <imran.shaik@oss.qualcomm.com>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad