mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Juergen Gross <jgross@suse.com>,
	linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org
Cc: jbeulich@suse.com
Subject: Re: [PATCH] xen: use hvc console for dom0
Date: Mon, 26 Feb 2018 14:02:17 -0500	[thread overview]
Message-ID: <16e21e9e-35d5-81f2-0f90-df5f8ac72446@oracle.com> (raw)
In-Reply-To: <20180226110822.13787-1-jgross@suse.com>

On 02/26/2018 06:08 AM, Juergen Gross wrote:
> Today the hvc console is added as a preferred console for pv domUs
> only. As this requires a boot parameter for getting dom0 messages per
> default add it for dom0, too.
>
> Signed-off-by: Juergen Gross <jgross@suse.com>
> ---
>  arch/x86/xen/enlighten_pv.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c
> index c047f42552e1..d27740a80c5e 100644
> --- a/arch/x86/xen/enlighten_pv.c
> +++ b/arch/x86/xen/enlighten_pv.c
> @@ -1377,7 +1377,6 @@ asmlinkage __visible void __init xen_start_kernel(void)
>  	if (!xen_initial_domain()) {
>  		add_preferred_console("xenboot", 0, NULL);
>  		add_preferred_console("tty", 0, NULL);
> -		add_preferred_console("hvc", 0, NULL);
>  		if (pci_xen)
>  			x86_init.pci.arch_init = pci_xen_init;
>  	} else {
> @@ -1410,6 +1409,9 @@ asmlinkage __visible void __init xen_start_kernel(void)
>  
>  		xen_boot_params_init_edd();
>  	}
> +
> +	add_preferred_console("hvc", 0, NULL);
> +

Won't this prevent dom0 output from showing up on vga console by default?

-boris

>  #ifdef CONFIG_PCI
>  	/* PCI BIOS service won't work from a PV guest. */
>  	pci_probe &= ~PCI_PROBE_BIOS;

  parent reply	other threads:[~2018-02-26 19:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-26 11:08 Juergen Gross
2018-02-26 12:06 ` [Xen-devel] " Andrii Anisov
2018-02-26 12:32   ` Juergen Gross
2018-02-27 11:14     ` Julien Grall
2018-02-27 20:03       ` Stefano Stabellini
2018-02-27 20:09         ` Julien Grall
2018-03-02 14:21           ` Juergen Gross
2018-02-26 19:02 ` Boris Ostrovsky [this message]
2018-02-27  9:26   ` Juergen Gross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16e21e9e-35d5-81f2-0f90-df5f8ac72446@oracle.com \
    --to=boris.ostrovsky@oracle.com \
    --cc=jbeulich@suse.com \
    --cc=jgross@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®