From: Markus Elfring <Markus.Elfring@web.de>
To: Stefan Wahren <wahrenst@gmx.net>,
Triet Hoang <triet.hoang.dev@gmail.com>,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
bcm-kernel-feedback-list@broadcom.com,
Florian Fainelli <florian.fainelli@broadcom.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [2/2] firmware: raspberrypi: Clean up local formatting
Date: Sat, 3 Oct 2026 13:17:04 +0200 [thread overview]
Message-ID: <16e2af34-9db3-4167-b6ef-1b3751fec7be@web.de> (raw)
In-Reply-To: <ef540a61-22d2-475c-a5bb-a7df8b44ee19@gmx.net>
>>> Add a blank line after the local variable declaration in
>>> response_callback() and fix the indentation of the UINT_MAX return in
>>> rpi_firmware_clk_get_max_rate().
>> …
>>
>> See also:
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v7.3-rc4#n88
> sorry but I didn't get. What's the problem about the commit message?
“… and fix …”
I imagine that another known advice can eventually be taken better into account.
“… Solve only one problem per patch. …”
Regards,
Markus
next prev parent reply other threads:[~2026-10-03 11:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-19 3:48 [PATCH 0/2] firmware: raspberrypi: Handle device registration errors Triet Hoang
2026-09-19 3:48 ` [PATCH 1/2] " Triet Hoang
2026-09-19 16:05 ` Stefan Wahren
2026-09-19 3:48 ` [PATCH 2/2] firmware: raspberrypi: Clean up local formatting Triet Hoang
2026-09-19 16:06 ` Stefan Wahren
2026-09-22 14:22 ` Markus Elfring
2026-10-02 15:13 ` Stefan Wahren
2026-10-03 11:17 ` Markus Elfring [this message]
2026-10-03 13:34 ` [2/2] " Stefan Wahren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16e2af34-9db3-4167-b6ef-1b3751fec7be@web.de \
--to=markus.elfring@web.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=florian.fainelli@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=triet.hoang.dev@gmail.com \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®