From: "Noralf Trønnes" <noralf@tronnes.org>
To: Arnd Bergmann <arnd@arndb.de>, David Airlie <airlied@linux.ie>
Cc: Thierry Reding <treding@nvidia.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tinydrm: repaper: add CONFIG_THERMAL dependency
Date: Sat, 29 Jul 2017 14:43:48 +0200 [thread overview]
Message-ID: <16f88019-6130-8f78-211a-1d26fc8a21f6@tronnes.org> (raw)
In-Reply-To: <20170727100004.300665-1-arnd@arndb.de>
Den 27.07.2017 11.58, skrev Arnd Bergmann:
> The new RePaper driver uses the thermal subsystem, and fails to link
> when it is built-in but thermal is a loadable module:
>
> drivers/gpu/drm/tinydrm/repaper.o: In function `repaper_probe':
> repaper.c:(.text+0x540): undefined reference to `thermal_zone_get_zone_by_name'
> drivers/gpu/drm/tinydrm/repaper.o: In function `repaper_fb_dirty':
> repaper.c:(.text+0xff4): undefined reference to `thermal_zone_get_temp'
>
> This adds another Kconfig dependency to prevent the broken configuration,
> forcing repaper to be a module too.
>
> Fixes: 3589211e9b03 ("drm/tinydrm: Add RePaper e-ink driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
Thanks for fixing this, applied to drm-misc.
Noralf.
> drivers/gpu/drm/tinydrm/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/tinydrm/Kconfig b/drivers/gpu/drm/tinydrm/Kconfig
> index 9596e447f877..f17c3caceab2 100644
> --- a/drivers/gpu/drm/tinydrm/Kconfig
> +++ b/drivers/gpu/drm/tinydrm/Kconfig
> @@ -23,6 +23,7 @@ config TINYDRM_MI0283QT
> config TINYDRM_REPAPER
> tristate "DRM support for Pervasive Displays RePaper panels (V231)"
> depends on DRM_TINYDRM && SPI
> + depends on THERMAL || !THERMAL
> help
> DRM driver for the following Pervasive Displays panels:
> 1.44" TFT EPD Panel (E1144CS021)
prev parent reply other threads:[~2017-07-29 12:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-27 9:58 Arnd Bergmann
2017-07-29 12:43 ` Noralf Trønnes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16f88019-6130-8f78-211a-1d26fc8a21f6@tronnes.org \
--to=noralf@tronnes.org \
--cc=airlied@linux.ie \
--cc=arnd@arndb.de \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®