* [PATCH net] net: axienet: Fix check for partial TX checksum
@ 2023-11-22 0:42 Samuel Holland
2023-11-22 0:55 ` Andrew Lunn
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Samuel Holland @ 2023-11-22 0:42 UTC (permalink / raw)
To: Radhey Shyam Pandey
Cc: Samuel Holland, Ariane Keller, Daniel Borkmann, David S. Miller,
Eric Dumazet, Jakub Kicinski, Michal Simek, Paolo Abeni,
linux-arm-kernel, linux-kernel, netdev
Due to a typo, the code checked the RX checksum feature in the TX path.
Fixes: 8a3b7a252dca ("drivers/net/ethernet/xilinx: added Xilinx AXI Ethernet driver")
Signed-off-by: Samuel Holland <samuel.holland@sifive.com>
---
drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
index 82d0d44b2b02..bf6e33990490 100644
--- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
+++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
@@ -822,7 +822,7 @@ axienet_start_xmit(struct sk_buff *skb, struct net_device *ndev)
if (lp->features & XAE_FEATURE_FULL_TX_CSUM) {
/* Tx Full Checksum Offload Enabled */
cur_p->app0 |= 2;
- } else if (lp->features & XAE_FEATURE_PARTIAL_RX_CSUM) {
+ } else if (lp->features & XAE_FEATURE_PARTIAL_TX_CSUM) {
csum_start_off = skb_transport_offset(skb);
csum_index_off = csum_start_off + skb->csum_offset;
/* Tx Partial Checksum Offload Enabled */
--
2.42.0
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net] net: axienet: Fix check for partial TX checksum
2023-11-22 0:42 [PATCH net] net: axienet: Fix check for partial TX checksum Samuel Holland
@ 2023-11-22 0:55 ` Andrew Lunn
2023-11-22 3:00 ` Pandey, Radhey Shyam
2023-11-23 17:00 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Andrew Lunn @ 2023-11-22 0:55 UTC (permalink / raw)
To: Samuel Holland
Cc: Radhey Shyam Pandey, Ariane Keller, Daniel Borkmann,
David S. Miller, Eric Dumazet, Jakub Kicinski, Michal Simek,
Paolo Abeni, linux-arm-kernel, linux-kernel, netdev
On Tue, Nov 21, 2023 at 04:42:17PM -0800, Samuel Holland wrote:
> Due to a typo, the code checked the RX checksum feature in the TX path.
>
> Fixes: 8a3b7a252dca ("drivers/net/ethernet/xilinx: added Xilinx AXI Ethernet driver")
> Signed-off-by: Samuel Holland <samuel.holland@sifive.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 4+ messages in thread* RE: [PATCH net] net: axienet: Fix check for partial TX checksum
2023-11-22 0:42 [PATCH net] net: axienet: Fix check for partial TX checksum Samuel Holland
2023-11-22 0:55 ` Andrew Lunn
@ 2023-11-22 3:00 ` Pandey, Radhey Shyam
2023-11-23 17:00 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Pandey, Radhey Shyam @ 2023-11-22 3:00 UTC (permalink / raw)
To: Samuel Holland
Cc: Ariane Keller, Daniel Borkmann, David S. Miller, Eric Dumazet,
Jakub Kicinski, Simek, Michal, Paolo Abeni, linux-arm-kernel,
linux-kernel, netdev
> -----Original Message-----
> From: Samuel Holland <samuel.holland@sifive.com>
> Sent: Wednesday, November 22, 2023 6:12 AM
> To: Pandey, Radhey Shyam <radhey.shyam.pandey@amd.com>
> Cc: Samuel Holland <samuel.holland@sifive.com>; Ariane Keller
> <ariane.keller@tik.ee.ethz.ch>; Daniel Borkmann <daniel@iogearbox.net>;
> David S. Miller <davem@davemloft.net>; Eric Dumazet
> <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Simek, Michal
> <michal.simek@amd.com>; Paolo Abeni <pabeni@redhat.com>; linux-arm-
> kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
> netdev@vger.kernel.org
> Subject: [PATCH net] net: axienet: Fix check for partial TX checksum
>
> Due to a typo, the code checked the RX checksum feature in the TX path.
>
> Fixes: 8a3b7a252dca ("drivers/net/ethernet/xilinx: added Xilinx AXI Ethernet
> driver")
> Signed-off-by: Samuel Holland <samuel.holland@sifive.com>
Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
Thanks!
> ---
>
> drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> index 82d0d44b2b02..bf6e33990490 100644
> --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> @@ -822,7 +822,7 @@ axienet_start_xmit(struct sk_buff *skb, struct
> net_device *ndev)
> if (lp->features & XAE_FEATURE_FULL_TX_CSUM) {
> /* Tx Full Checksum Offload Enabled */
> cur_p->app0 |= 2;
> - } else if (lp->features & XAE_FEATURE_PARTIAL_RX_CSUM) {
> + } else if (lp->features & XAE_FEATURE_PARTIAL_TX_CSUM) {
> csum_start_off = skb_transport_offset(skb);
> csum_index_off = csum_start_off + skb-
> >csum_offset;
> /* Tx Partial Checksum Offload Enabled */
> --
> 2.42.0
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net] net: axienet: Fix check for partial TX checksum
2023-11-22 0:42 [PATCH net] net: axienet: Fix check for partial TX checksum Samuel Holland
2023-11-22 0:55 ` Andrew Lunn
2023-11-22 3:00 ` Pandey, Radhey Shyam
@ 2023-11-23 17:00 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-11-23 17:00 UTC (permalink / raw)
To: Samuel Holland
Cc: radhey.shyam.pandey, ariane.keller, daniel, davem, edumazet,
kuba, michal.simek, pabeni, linux-arm-kernel, linux-kernel,
netdev
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Tue, 21 Nov 2023 16:42:17 -0800 you wrote:
> Due to a typo, the code checked the RX checksum feature in the TX path.
>
> Fixes: 8a3b7a252dca ("drivers/net/ethernet/xilinx: added Xilinx AXI Ethernet driver")
> Signed-off-by: Samuel Holland <samuel.holland@sifive.com>
> ---
>
> drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Here is the summary with links:
- [net] net: axienet: Fix check for partial TX checksum
https://git.kernel.org/netdev/net/c/fd0413bbf8b1
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-11-23 17:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-22 0:42 [PATCH net] net: axienet: Fix check for partial TX checksum Samuel Holland
2023-11-22 0:55 ` Andrew Lunn
2023-11-22 3:00 ` Pandey, Radhey Shyam
2023-11-23 17:00 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®