* [PATCH v2] soc: qcom: llcc: Fix LLCC_TRP_ATTR2_CFGn offset
@ 2023-10-12 16:05 Abel Vesa
2023-12-03 4:54 ` Bjorn Andersson
0 siblings, 1 reply; 2+ messages in thread
From: Abel Vesa @ 2023-10-12 16:05 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio
Cc: linux-arm-msm, Linux Kernel Mailing List, Avinash Philip,
Unnathi Chalicheemala, Satya Durga Srinivasu Prabhala
According to documentation, it has increments of 4, not 8.
Fixes: c72ca343f911 ("soc: qcom: llcc: Add v4.1 HW version support")
Reported-by: Unnathi Chalicheemala <quic_uchalich@quicinc.com>
Reviewed-by: Satya Durga Srinivasu Prabhala <quic_satyap@quicinc.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
---
Changes since v1:
* fixed Unnathi's first name typo
* added Konrad's and Satya's R-b tags
drivers/soc/qcom/llcc-qcom.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/qcom/llcc-qcom.c b/drivers/soc/qcom/llcc-qcom.c
index 674abd0d6700..fb4085b7cb19 100644
--- a/drivers/soc/qcom/llcc-qcom.c
+++ b/drivers/soc/qcom/llcc-qcom.c
@@ -47,7 +47,7 @@
#define LLCC_TRP_STATUSn(n) (4 + n * SZ_4K)
#define LLCC_TRP_ATTR0_CFGn(n) (0x21000 + SZ_8 * n)
#define LLCC_TRP_ATTR1_CFGn(n) (0x21004 + SZ_8 * n)
-#define LLCC_TRP_ATTR2_CFGn(n) (0x21100 + SZ_8 * n)
+#define LLCC_TRP_ATTR2_CFGn(n) (0x21100 + SZ_4 * n)
#define LLCC_TRP_SCID_DIS_CAP_ALLOC 0x21f00
#define LLCC_TRP_PCB_ACT 0x21f04
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2] soc: qcom: llcc: Fix LLCC_TRP_ATTR2_CFGn offset
2023-10-12 16:05 [PATCH v2] soc: qcom: llcc: Fix LLCC_TRP_ATTR2_CFGn offset Abel Vesa
@ 2023-12-03 4:54 ` Bjorn Andersson
0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Andersson @ 2023-12-03 4:54 UTC (permalink / raw)
To: Andy Gross, Konrad Dybcio, Abel Vesa
Cc: linux-arm-msm, Linux Kernel Mailing List, Avinash Philip,
Unnathi Chalicheemala, Satya Durga Srinivasu Prabhala
On Thu, 12 Oct 2023 19:05:09 +0300, Abel Vesa wrote:
> According to documentation, it has increments of 4, not 8.
>
>
Applied, thanks!
[1/1] soc: qcom: llcc: Fix LLCC_TRP_ATTR2_CFGn offset
commit: 03970d2fa35497d5a5812d67ce94ca5836335159
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-12-03 4:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-12 16:05 [PATCH v2] soc: qcom: llcc: Fix LLCC_TRP_ATTR2_CFGn offset Abel Vesa
2023-12-03 4:54 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®