mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 1/2] ASoC: qcom: sc8280xp: set card driver name from match data
@ 2023-12-01 13:53 Krzysztof Kozlowski
  2023-12-01 13:53 ` [PATCH 2/2] ASoC: qcom: sc8280xp: Add support for SM8450 and SM8550 Krzysztof Kozlowski
  2023-12-04 12:33 ` [PATCH 1/2] ASoC: qcom: sc8280xp: set card driver name from match data Mark Brown
  0 siblings, 2 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2023-12-01 13:53 UTC (permalink / raw)
  To: Srinivas Kandagatla, Banajit Goswami, Liam Girdwood, Mark Brown,
	Jaroslav Kysela, Takashi Iwai, alsa-devel, linux-sound,
	linux-kernel
  Cc: Krzysztof Kozlowski

Sound machine drivers for all newer Qualcomm SoC platforms are the
exactly same, therefore it makes sense to use same machine driver for
newer platforms as well.  Choice of sound topology and user-space Alsa
UCM files depends however on card driver name, which must be customized
per each board.  Allow such customization by using driver match data as
sound card driver name.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 sound/soc/qcom/sc8280xp.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/sound/soc/qcom/sc8280xp.c b/sound/soc/qcom/sc8280xp.c
index d93b18f07be5..7df28ecefd65 100644
--- a/sound/soc/qcom/sc8280xp.c
+++ b/sound/soc/qcom/sc8280xp.c
@@ -14,8 +14,6 @@
 #include "common.h"
 #include "sdw.h"
 
-#define DRIVER_NAME		"sc8280xp"
-
 struct sc8280xp_snd_data {
 	bool stream_prepared[AFE_PORT_MAX];
 	struct snd_soc_card *card;
@@ -133,13 +131,13 @@ static int sc8280xp_platform_probe(struct platform_device *pdev)
 	if (ret)
 		return ret;
 
-	card->driver_name = DRIVER_NAME;
+	card->driver_name = of_device_get_match_data(dev);
 	sc8280xp_add_be_ops(card);
 	return devm_snd_soc_register_card(dev, card);
 }
 
 static const struct of_device_id snd_sc8280xp_dt_match[] = {
-	{.compatible = "qcom,sc8280xp-sndcard",},
+	{.compatible = "qcom,sc8280xp-sndcard", "sc8280xp"},
 	{}
 };
 
-- 
2.34.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 2/2] ASoC: qcom: sc8280xp: Add support for SM8450 and SM8550
  2023-12-01 13:53 [PATCH 1/2] ASoC: qcom: sc8280xp: set card driver name from match data Krzysztof Kozlowski
@ 2023-12-01 13:53 ` Krzysztof Kozlowski
  2023-12-04 12:33 ` [PATCH 1/2] ASoC: qcom: sc8280xp: set card driver name from match data Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2023-12-01 13:53 UTC (permalink / raw)
  To: Srinivas Kandagatla, Banajit Goswami, Liam Girdwood, Mark Brown,
	Jaroslav Kysela, Takashi Iwai, alsa-devel, linux-sound,
	linux-kernel
  Cc: Krzysztof Kozlowski

Add compatibles for sound card on Qualcomm SM8450 and SM8550 boards.
The compatibles were already documented.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 sound/soc/qcom/sc8280xp.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sound/soc/qcom/sc8280xp.c b/sound/soc/qcom/sc8280xp.c
index 7df28ecefd65..837356ac541f 100644
--- a/sound/soc/qcom/sc8280xp.c
+++ b/sound/soc/qcom/sc8280xp.c
@@ -138,6 +138,8 @@ static int sc8280xp_platform_probe(struct platform_device *pdev)
 
 static const struct of_device_id snd_sc8280xp_dt_match[] = {
 	{.compatible = "qcom,sc8280xp-sndcard", "sc8280xp"},
+	{.compatible = "qcom,sm8450-sndcard", "sm8450"},
+	{.compatible = "qcom,sm8550-sndcard", "sm8550"},
 	{}
 };
 
-- 
2.34.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/2] ASoC: qcom: sc8280xp: set card driver name from match data
  2023-12-01 13:53 [PATCH 1/2] ASoC: qcom: sc8280xp: set card driver name from match data Krzysztof Kozlowski
  2023-12-01 13:53 ` [PATCH 2/2] ASoC: qcom: sc8280xp: Add support for SM8450 and SM8550 Krzysztof Kozlowski
@ 2023-12-04 12:33 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2023-12-04 12:33 UTC (permalink / raw)
  To: Srinivas Kandagatla, Banajit Goswami, Liam Girdwood,
	Jaroslav Kysela, Takashi Iwai, alsa-devel, linux-sound,
	linux-kernel, Krzysztof Kozlowski

On Fri, 01 Dec 2023 14:53:31 +0100, Krzysztof Kozlowski wrote:
> Sound machine drivers for all newer Qualcomm SoC platforms are the
> exactly same, therefore it makes sense to use same machine driver for
> newer platforms as well.  Choice of sound topology and user-space Alsa
> UCM files depends however on card driver name, which must be customized
> per each board.  Allow such customization by using driver match data as
> sound card driver name.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/2] ASoC: qcom: sc8280xp: set card driver name from match data
      commit: 625ed9457de50d7726ccb3f2bc4e01e543ceb126
[2/2] ASoC: qcom: sc8280xp: Add support for SM8450 and SM8550
      commit: fdcaecfc71e2f4ab70ce9469f14dd64c23bf401a

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-12-04 12:34 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-01 13:53 [PATCH 1/2] ASoC: qcom: sc8280xp: set card driver name from match data Krzysztof Kozlowski
2023-12-01 13:53 ` [PATCH 2/2] ASoC: qcom: sc8280xp: Add support for SM8450 and SM8550 Krzysztof Kozlowski
2023-12-04 12:33 ` [PATCH 1/2] ASoC: qcom: sc8280xp: set card driver name from match data Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®