* [PATCH] perf/arm-cmn: Fix HN-F class_occup_id events
@ 2023-11-23 11:58 Robin Murphy
2023-12-05 15:16 ` Will Deacon
0 siblings, 1 reply; 2+ messages in thread
From: Robin Murphy @ 2023-11-23 11:58 UTC (permalink / raw)
To: will; +Cc: mark.rutland, linux-arm-kernel, linux-kernel, Jing Zhang
A subtle copy-paste error managed to slip through the reorganisation
of these patches in development, and not only give some HN-F events
the wrong type, but use that wrong type before the subsequent patch
defined it. Too late to fix history, but we can at least fix the bug.
Fixes: b1b7dc38e482 ("perf/arm-cmn: Refactor HN-F event selector macros")
Reported-by: Jing Zhang <renyu.zj@linux.alibaba.com>
Signed-off-by: Robin Murphy <robin.murphy@arm.com>
---
drivers/perf/arm-cmn.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/perf/arm-cmn.c b/drivers/perf/arm-cmn.c
index 014010d03588..86d970e74129 100644
--- a/drivers/perf/arm-cmn.c
+++ b/drivers/perf/arm-cmn.c
@@ -811,7 +811,7 @@ static umode_t arm_cmn_event_attr_is_visible(struct kobject *kobj,
#define CMN_EVENT_HNF_OCC(_model, _name, _event) \
CMN_EVENT_HN_OCC(_model, hnf_##_name, CMN_TYPE_HNF, _event)
#define CMN_EVENT_HNF_CLS(_model, _name, _event) \
- CMN_EVENT_HN_CLS(_model, hnf_##_name, CMN_TYPE_HNS, _event)
+ CMN_EVENT_HN_CLS(_model, hnf_##_name, CMN_TYPE_HNF, _event)
#define CMN_EVENT_HNF_SNT(_model, _name, _event) \
CMN_EVENT_HN_SNT(_model, hnf_##_name, CMN_TYPE_HNF, _event)
--
2.39.2.101.g768bb238c484.dirty
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] perf/arm-cmn: Fix HN-F class_occup_id events
2023-11-23 11:58 [PATCH] perf/arm-cmn: Fix HN-F class_occup_id events Robin Murphy
@ 2023-12-05 15:16 ` Will Deacon
0 siblings, 0 replies; 2+ messages in thread
From: Will Deacon @ 2023-12-05 15:16 UTC (permalink / raw)
To: Robin Murphy
Cc: catalin.marinas, kernel-team, Will Deacon, mark.rutland,
linux-kernel, linux-arm-kernel, Jing Zhang
On Thu, 23 Nov 2023 11:58:13 +0000, Robin Murphy wrote:
> A subtle copy-paste error managed to slip through the reorganisation
> of these patches in development, and not only give some HN-F events
> the wrong type, but use that wrong type before the subsequent patch
> defined it. Too late to fix history, but we can at least fix the bug.
>
>
Applied to will (for-next/perf), thanks!
[1/1] perf/arm-cmn: Fix HN-F class_occup_id events
https://git.kernel.org/will/c/590f23b09240
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-12-05 15:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-23 11:58 [PATCH] perf/arm-cmn: Fix HN-F class_occup_id events Robin Murphy
2023-12-05 15:16 ` Will Deacon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®