* [PATCH] arm64: dts: qcom: ipq5332: add missing properties to the GPIO LED node
@ 2023-10-25 13:50 Kathiravan Thirumoorthy
2023-10-25 13:52 ` Krzysztof Kozlowski
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Kathiravan Thirumoorthy @ 2023-10-25 13:50 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, Kathiravan Thirumoorthy
Add the color and function property to the GPIO LED node, which are
missed out in the initial submission.
Signed-off-by: Kathiravan Thirumoorthy <quic_kathirav@quicinc.com>
---
arch/arm64/boot/dts/qcom/ipq5332-rdp-common.dtsi | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/ipq5332-rdp-common.dtsi b/arch/arm64/boot/dts/qcom/ipq5332-rdp-common.dtsi
index 4870cdb764d0..b37ae7749083 100644
--- a/arch/arm64/boot/dts/qcom/ipq5332-rdp-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq5332-rdp-common.dtsi
@@ -9,6 +9,7 @@
#include <dt-bindings/gpio/gpio.h>
#include <dt-bindings/input/input.h>
+#include <dt-bindings/leds/common.h>
#include "ipq5332.dtsi"
/ {
@@ -39,6 +40,8 @@ leds {
pinctrl-names = "default";
led-0 {
+ color = <LED_COLOR_ID_GREEN>;
+ function = LED_FUNCTION_WLAN;
gpios = <&tlmm 36 GPIO_ACTIVE_HIGH>;
linux,default-trigger = "phy0tx";
default-state = "off";
---
base-commit: fe1998aa935b44ef873193c0772c43bce74f17dc
change-id: 20231025-ipq5332-gpio-led-cd157e81d7b0
Best regards,
--
Kathiravan Thirumoorthy <quic_kathirav@quicinc.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: qcom: ipq5332: add missing properties to the GPIO LED node
2023-10-25 13:50 [PATCH] arm64: dts: qcom: ipq5332: add missing properties to the GPIO LED node Kathiravan Thirumoorthy
@ 2023-10-25 13:52 ` Krzysztof Kozlowski
2023-12-01 13:39 ` Kathiravan Thirumoorthy
2023-12-08 2:57 ` Bjorn Andersson
2 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2023-10-25 13:52 UTC (permalink / raw)
To: Kathiravan Thirumoorthy, Andy Gross, Bjorn Andersson,
Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel
On 25/10/2023 15:50, Kathiravan Thirumoorthy wrote:
> Add the color and function property to the GPIO LED node, which are
> missed out in the initial submission.
>
> Signed-off-by: Kathiravan Thirumoorthy <quic_kathirav@quicinc.com>
> ---
> arch/arm64/boot/dts/qcom/ipq5332-rdp-common.dtsi | 3 +++
> 1 file changed, 3 insertions(+)
>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: qcom: ipq5332: add missing properties to the GPIO LED node
2023-10-25 13:50 [PATCH] arm64: dts: qcom: ipq5332: add missing properties to the GPIO LED node Kathiravan Thirumoorthy
2023-10-25 13:52 ` Krzysztof Kozlowski
@ 2023-12-01 13:39 ` Kathiravan Thirumoorthy
2023-12-08 2:57 ` Bjorn Andersson
2 siblings, 0 replies; 4+ messages in thread
From: Kathiravan Thirumoorthy @ 2023-12-01 13:39 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel
On 10/25/2023 7:20 PM, Kathiravan Thirumoorthy wrote:
> Add the color and function property to the GPIO LED node, which are
> missed out in the initial submission.
>
Gentle Reminder...
> Signed-off-by: Kathiravan Thirumoorthy <quic_kathirav@quicinc.com>
> ---
> arch/arm64/boot/dts/qcom/ipq5332-rdp-common.dtsi | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq5332-rdp-common.dtsi b/arch/arm64/boot/dts/qcom/ipq5332-rdp-common.dtsi
> index 4870cdb764d0..b37ae7749083 100644
> --- a/arch/arm64/boot/dts/qcom/ipq5332-rdp-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq5332-rdp-common.dtsi
> @@ -9,6 +9,7 @@
>
> #include <dt-bindings/gpio/gpio.h>
> #include <dt-bindings/input/input.h>
> +#include <dt-bindings/leds/common.h>
> #include "ipq5332.dtsi"
>
> / {
> @@ -39,6 +40,8 @@ leds {
> pinctrl-names = "default";
>
> led-0 {
> + color = <LED_COLOR_ID_GREEN>;
> + function = LED_FUNCTION_WLAN;
> gpios = <&tlmm 36 GPIO_ACTIVE_HIGH>;
> linux,default-trigger = "phy0tx";
> default-state = "off";
>
> ---
> base-commit: fe1998aa935b44ef873193c0772c43bce74f17dc
> change-id: 20231025-ipq5332-gpio-led-cd157e81d7b0
>
> Best regards,
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: qcom: ipq5332: add missing properties to the GPIO LED node
2023-10-25 13:50 [PATCH] arm64: dts: qcom: ipq5332: add missing properties to the GPIO LED node Kathiravan Thirumoorthy
2023-10-25 13:52 ` Krzysztof Kozlowski
2023-12-01 13:39 ` Kathiravan Thirumoorthy
@ 2023-12-08 2:57 ` Bjorn Andersson
2 siblings, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2023-12-08 2:57 UTC (permalink / raw)
To: Andy Gross, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Kathiravan Thirumoorthy
Cc: linux-arm-msm, devicetree, linux-kernel
On Wed, 25 Oct 2023 19:20:05 +0530, Kathiravan Thirumoorthy wrote:
> Add the color and function property to the GPIO LED node, which are
> missed out in the initial submission.
>
>
Applied, thanks!
[1/1] arm64: dts: qcom: ipq5332: add missing properties to the GPIO LED node
commit: 63a021f52f69092f17d24707cd8e81f914f8d1e6
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-12-08 2:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-25 13:50 [PATCH] arm64: dts: qcom: ipq5332: add missing properties to the GPIO LED node Kathiravan Thirumoorthy
2023-10-25 13:52 ` Krzysztof Kozlowski
2023-12-01 13:39 ` Kathiravan Thirumoorthy
2023-12-08 2:57 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®