mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 0/3] Several smaller msm8974 fixes
@ 2023-12-17 15:22 Luca Weiss
  2023-12-17 15:22 ` [PATCH 1/3] ARM: dts: qcom: msm8974-klte: Remove unused property Luca Weiss
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Luca Weiss @ 2023-12-17 15:22 UTC (permalink / raw)
  To: ~postmarketos/upstreaming, phone-devel, Andy Gross,
	Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Samuel Pascua, Iskren Chernev
  Cc: linux-arm-msm, devicetree, linux-kernel, Konrad Dybcio,
	Alexey Minnekhanov, Luca Weiss

Send some smaller fixes that have been sitting around in my tree for
some time.

Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
---
Alexey Minnekhanov (1):
      ARM: dts: qcom: msm8974-klte: Remove unused property

Luca Weiss (2):
      ARM: dts: qcom: msm8974: Remove bogus cd-gpio pinctrl
      ARM: dts: qcom: msm8974*: Re-enable remoteprocs on various boards

 arch/arm/boot/dts/qcom/qcom-msm8974-lge-nexus5-hammerhead.dts      | 2 ++
 arch/arm/boot/dts/qcom/qcom-msm8974-sony-xperia-rhine.dtsi         | 2 ++
 arch/arm/boot/dts/qcom/qcom-msm8974.dtsi                           | 7 -------
 arch/arm/boot/dts/qcom/qcom-msm8974pro-samsung-klte.dts            | 1 -
 .../boot/dts/qcom/qcom-msm8974pro-sony-xperia-shinano-castor.dts   | 2 ++
 5 files changed, 6 insertions(+), 8 deletions(-)
---
base-commit: de06a4144d8e2c0923d08cab7c24958c28ddf17f
change-id: 20231217-msm8974-misc-5d5861522ad1

Best regards,
-- 
Luca Weiss <luca@z3ntu.xyz>


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 1/3] ARM: dts: qcom: msm8974-klte: Remove unused property
  2023-12-17 15:22 [PATCH 0/3] Several smaller msm8974 fixes Luca Weiss
@ 2023-12-17 15:22 ` Luca Weiss
  2023-12-17 15:22 ` [PATCH 2/3] ARM: dts: qcom: msm8974: Remove bogus cd-gpio pinctrl Luca Weiss
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Luca Weiss @ 2023-12-17 15:22 UTC (permalink / raw)
  To: ~postmarketos/upstreaming, phone-devel, Andy Gross,
	Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Samuel Pascua, Iskren Chernev
  Cc: linux-arm-msm, devicetree, linux-kernel, Konrad Dybcio,
	Alexey Minnekhanov, Luca Weiss

From: Alexey Minnekhanov <alexeymin@postmarketos.org>

Panel driver samsung,s6e3fa2 does not use te-gpios. The pin is already
configured properly through pinctrl.

Fixes: 3657b677d20d ("ARM: dts: qcom: msm8974-klte: add support for display")
Signed-off-by: Alexey Minnekhanov <alexeymin@postmarketos.org>
[luca: adjust commit message, add Fixes tag]
Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
---
 arch/arm/boot/dts/qcom/qcom-msm8974pro-samsung-klte.dts | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/boot/dts/qcom/qcom-msm8974pro-samsung-klte.dts b/arch/arm/boot/dts/qcom/qcom-msm8974pro-samsung-klte.dts
index ca3aa16b4b10..b93539e2b87e 100644
--- a/arch/arm/boot/dts/qcom/qcom-msm8974pro-samsung-klte.dts
+++ b/arch/arm/boot/dts/qcom/qcom-msm8974pro-samsung-klte.dts
@@ -363,7 +363,6 @@ panel: panel@0 {
 		vddr-supply = <&vreg_panel>;
 
 		reset-gpios = <&pma8084_gpios 17 GPIO_ACTIVE_LOW>;
-		te-gpios = <&tlmm 12 GPIO_ACTIVE_HIGH>;
 
 		port {
 			panel_in: endpoint {

-- 
2.43.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 2/3] ARM: dts: qcom: msm8974: Remove bogus cd-gpio pinctrl
  2023-12-17 15:22 [PATCH 0/3] Several smaller msm8974 fixes Luca Weiss
  2023-12-17 15:22 ` [PATCH 1/3] ARM: dts: qcom: msm8974-klte: Remove unused property Luca Weiss
@ 2023-12-17 15:22 ` Luca Weiss
  2023-12-17 15:22 ` [PATCH 3/3] ARM: dts: qcom: msm8974*: Re-enable remoteprocs on various boards Luca Weiss
  2023-12-17 20:24 ` [PATCH 0/3] Several smaller msm8974 fixes Bjorn Andersson
  3 siblings, 0 replies; 5+ messages in thread
From: Luca Weiss @ 2023-12-17 15:22 UTC (permalink / raw)
  To: ~postmarketos/upstreaming, phone-devel, Andy Gross,
	Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Samuel Pascua, Iskren Chernev
  Cc: linux-arm-msm, devicetree, linux-kernel, Konrad Dybcio,
	Alexey Minnekhanov, Luca Weiss

No board in mainline uses GPIO 54 for card-detect on sdhc_2, and this
also causes conflict when both sdhc_2 and blsp2_uart4 are used, such as
on qcom-msm8974-lge-nexus5-hammerhead.

Fixes: 1dfe967ec7cf ("ARM: dts: qcom-msm8974*: Consolidate I2C/UART/SDHCI")
Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
---
 arch/arm/boot/dts/qcom/qcom-msm8974.dtsi | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/arch/arm/boot/dts/qcom/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom/qcom-msm8974.dtsi
index ee202f3f161e..b1413983787c 100644
--- a/arch/arm/boot/dts/qcom/qcom-msm8974.dtsi
+++ b/arch/arm/boot/dts/qcom/qcom-msm8974.dtsi
@@ -1641,13 +1641,6 @@ data-pins {
 					bias-pull-up;
 					drive-strength = <2>;
 				};
-
-				cd-pins {
-					pins = "gpio54";
-					function = "gpio";
-					bias-disable;
-					drive-strength = <2>;
-				};
 			};
 
 			blsp1_uart2_default: blsp1-uart2-default-state {

-- 
2.43.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 3/3] ARM: dts: qcom: msm8974*: Re-enable remoteprocs on various boards
  2023-12-17 15:22 [PATCH 0/3] Several smaller msm8974 fixes Luca Weiss
  2023-12-17 15:22 ` [PATCH 1/3] ARM: dts: qcom: msm8974-klte: Remove unused property Luca Weiss
  2023-12-17 15:22 ` [PATCH 2/3] ARM: dts: qcom: msm8974: Remove bogus cd-gpio pinctrl Luca Weiss
@ 2023-12-17 15:22 ` Luca Weiss
  2023-12-17 20:24 ` [PATCH 0/3] Several smaller msm8974 fixes Bjorn Andersson
  3 siblings, 0 replies; 5+ messages in thread
From: Luca Weiss @ 2023-12-17 15:22 UTC (permalink / raw)
  To: ~postmarketos/upstreaming, phone-devel, Andy Gross,
	Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Samuel Pascua, Iskren Chernev
  Cc: linux-arm-msm, devicetree, linux-kernel, Konrad Dybcio,
	Alexey Minnekhanov, Luca Weiss

Even though a previous patch re-added the supplies to the adsp and modem
remoteprocs, due to timing differences in the meantime the remoteprocs
were disabled by default, but the commit re-adding the supplies didn't
enable them.

Enable them now to hopefully properly resolve the fallout now.

Fixes: 6d933c0ec171 ("ARM: dts: qcom: msm8974-*: re-add remoteproc supplies")
Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
---
 arch/arm/boot/dts/qcom/qcom-msm8974-lge-nexus5-hammerhead.dts         | 2 ++
 arch/arm/boot/dts/qcom/qcom-msm8974-sony-xperia-rhine.dtsi            | 2 ++
 arch/arm/boot/dts/qcom/qcom-msm8974pro-sony-xperia-shinano-castor.dts | 2 ++
 3 files changed, 6 insertions(+)

diff --git a/arch/arm/boot/dts/qcom/qcom-msm8974-lge-nexus5-hammerhead.dts b/arch/arm/boot/dts/qcom/qcom-msm8974-lge-nexus5-hammerhead.dts
index ca402b4a68bd..4aaae8537a3f 100644
--- a/arch/arm/boot/dts/qcom/qcom-msm8974-lge-nexus5-hammerhead.dts
+++ b/arch/arm/boot/dts/qcom/qcom-msm8974-lge-nexus5-hammerhead.dts
@@ -367,6 +367,7 @@ led@5 {
 
 &remoteproc_adsp {
 	cx-supply = <&pm8841_s2>;
+	status = "okay";
 };
 
 &remoteproc_mss {
@@ -374,6 +375,7 @@ &remoteproc_mss {
 	mss-supply = <&pm8841_s3>;
 	mx-supply = <&pm8841_s1>;
 	pll-supply = <&pm8941_l12>;
+	status = "okay";
 };
 
 &rpm_requests {
diff --git a/arch/arm/boot/dts/qcom/qcom-msm8974-sony-xperia-rhine.dtsi b/arch/arm/boot/dts/qcom/qcom-msm8974-sony-xperia-rhine.dtsi
index 94cbad81379f..d34659ebac22 100644
--- a/arch/arm/boot/dts/qcom/qcom-msm8974-sony-xperia-rhine.dtsi
+++ b/arch/arm/boot/dts/qcom/qcom-msm8974-sony-xperia-rhine.dtsi
@@ -217,6 +217,7 @@ &pm8941_wled {
 
 &remoteproc_adsp {
 	cx-supply = <&pm8841_s2>;
+	status = "okay";
 };
 
 &remoteproc_mss {
@@ -224,6 +225,7 @@ &remoteproc_mss {
 	mss-supply = <&pm8841_s3>;
 	mx-supply = <&pm8841_s1>;
 	pll-supply = <&pm8941_l12>;
+	status = "okay";
 };
 
 &rpm_requests {
diff --git a/arch/arm/boot/dts/qcom/qcom-msm8974pro-sony-xperia-shinano-castor.dts b/arch/arm/boot/dts/qcom/qcom-msm8974pro-sony-xperia-shinano-castor.dts
index 7c6fe442b559..ee94741a26ed 100644
--- a/arch/arm/boot/dts/qcom/qcom-msm8974pro-sony-xperia-shinano-castor.dts
+++ b/arch/arm/boot/dts/qcom/qcom-msm8974pro-sony-xperia-shinano-castor.dts
@@ -324,6 +324,7 @@ led@7 {
 
 &remoteproc_adsp {
 	cx-supply = <&pm8841_s2>;
+	status = "okay";
 };
 
 &remoteproc_mss {
@@ -331,6 +332,7 @@ &remoteproc_mss {
 	mss-supply = <&pm8841_s3>;
 	mx-supply = <&pm8841_s1>;
 	pll-supply = <&pm8941_l12>;
+	status = "okay";
 };
 
 &rpm_requests {

-- 
2.43.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 0/3] Several smaller msm8974 fixes
  2023-12-17 15:22 [PATCH 0/3] Several smaller msm8974 fixes Luca Weiss
                   ` (2 preceding siblings ...)
  2023-12-17 15:22 ` [PATCH 3/3] ARM: dts: qcom: msm8974*: Re-enable remoteprocs on various boards Luca Weiss
@ 2023-12-17 20:24 ` Bjorn Andersson
  3 siblings, 0 replies; 5+ messages in thread
From: Bjorn Andersson @ 2023-12-17 20:24 UTC (permalink / raw)
  To: ~postmarketos/upstreaming, phone-devel, Andy Gross,
	Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Samuel Pascua, Iskren Chernev, Luca Weiss
  Cc: linux-arm-msm, devicetree, linux-kernel, Konrad Dybcio,
	Alexey Minnekhanov


On Sun, 17 Dec 2023 16:22:52 +0100, Luca Weiss wrote:
> Send some smaller fixes that have been sitting around in my tree for
> some time.
> 
> 

Applied, thanks!

[1/3] ARM: dts: qcom: msm8974-klte: Remove unused property
      commit: 32b075f8a2d4fefb8d791431606930883a5d5f15
[2/3] ARM: dts: qcom: msm8974: Remove bogus cd-gpio pinctrl
      commit: 1522b3bb306986e2f3923152a05939176b2a8a0c
[3/3] ARM: dts: qcom: msm8974*: Re-enable remoteprocs on various boards
      commit: 648002a27c6b3ae293cc415e1fbf20aaa6af8bd3

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2023-12-17 20:24 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-17 15:22 [PATCH 0/3] Several smaller msm8974 fixes Luca Weiss
2023-12-17 15:22 ` [PATCH 1/3] ARM: dts: qcom: msm8974-klte: Remove unused property Luca Weiss
2023-12-17 15:22 ` [PATCH 2/3] ARM: dts: qcom: msm8974: Remove bogus cd-gpio pinctrl Luca Weiss
2023-12-17 15:22 ` [PATCH 3/3] ARM: dts: qcom: msm8974*: Re-enable remoteprocs on various boards Luca Weiss
2023-12-17 20:24 ` [PATCH 0/3] Several smaller msm8974 fixes Bjorn Andersson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®