From: Rob Herring <robh@kernel.org>
To: "André Draszik" <andre.draszik@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Masahiro Yamada <masahiroy@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Subject: Re: [PATCH] dt-bindings: ignore paths outside kernel for DT_SCHEMA_FILES
Date: Wed, 3 Jan 2024 16:58:27 -0700 [thread overview]
Message-ID: <170432630603.2042234.10993333941885772911.robh@kernel.org> (raw)
In-Reply-To: <20231220145537.2163811-1-andre.draszik@linaro.org>
On Wed, 20 Dec 2023 14:55:37 +0000, André Draszik wrote:
> If the location of the kernel sources contains the string that we're
> filtering for using DT_SCHEMA_FILES, then all schemas will currently be
> matched, returned and checked, not just the ones we actually expected.
> As an example, if the kernel sources happen to be below a directory
> 'google', and DT_SCHEMA_FILES=google, everything is checked. More
> common examples might be having the sources below people's home
> directories that contain the string st or arm and then searching for
> those. The list is endless.
>
> Fix this by only matching for schemas below the kernel source's
> bindings directory.
>
> Note that I opted for the implementation here so as to not having to
> deal with escaping DT_SCHEMA_FILES, which would have been the
> alternative if the grep match itself had been updated.
>
> Cc: Masahiro Yamada <masahiroy@kernel.org>
> Signed-off-by: André Draszik <andre.draszik@linaro.org>
> ---
> Documentation/devicetree/bindings/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Applied, thanks!
next prev parent reply other threads:[~2024-01-03 23:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-20 14:55 André Draszik
2024-01-03 23:58 ` Rob Herring [this message]
2024-01-15 9:20 ` Michal Simek
2024-01-15 9:36 ` André Draszik
2024-01-15 9:40 ` André Draszik
2024-01-15 16:29 ` Conor Dooley
2024-01-15 16:37 ` Michal Simek
2024-01-15 16:57 ` André Draszik
2024-01-15 17:43 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170432630603.2042234.10993333941885772911.robh@kernel.org \
--to=robh@kernel.org \
--cc=andre.draszik@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®