* [PATCH RESEND net] net: Implement missing SO_TIMESTAMPING_NEW cmsg support
@ 2024-01-04 8:57 Thomas Lange
2024-01-04 14:55 ` Willem de Bruijn
2024-01-04 16:30 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Thomas Lange @ 2024-01-04 8:57 UTC (permalink / raw)
To: netdev, linux-kernel
Cc: willemdebruijn.kernel, jthinz, arnd, deepa.kernel, davem,
edumazet, kuba, pabeni, Thomas Lange
Commit 9718475e6908 ("socket: Add SO_TIMESTAMPING_NEW") added the new
socket option SO_TIMESTAMPING_NEW. However, it was never implemented in
__sock_cmsg_send thus breaking SO_TIMESTAMPING cmsg for platforms using
SO_TIMESTAMPING_NEW.
Fixes: 9718475e6908 ("socket: Add SO_TIMESTAMPING_NEW")
Link: https://lore.kernel.org/netdev/6a7281bf-bc4a-4f75-bb88-7011908ae471@app.fastmail.com/
Signed-off-by: Thomas Lange <thomas@corelatus.se>
---
net/core/sock.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/core/sock.c b/net/core/sock.c
index 51d52859e942..d02534c77413 100644
--- a/net/core/sock.c
+++ b/net/core/sock.c
@@ -2813,6 +2813,7 @@ int __sock_cmsg_send(struct sock *sk, struct cmsghdr *cmsg,
sockc->mark = *(u32 *)CMSG_DATA(cmsg);
break;
case SO_TIMESTAMPING_OLD:
+ case SO_TIMESTAMPING_NEW:
if (cmsg->cmsg_len != CMSG_LEN(sizeof(u32)))
return -EINVAL;
--
2.39.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH RESEND net] net: Implement missing SO_TIMESTAMPING_NEW cmsg support
2024-01-04 8:57 [PATCH RESEND net] net: Implement missing SO_TIMESTAMPING_NEW cmsg support Thomas Lange
@ 2024-01-04 14:55 ` Willem de Bruijn
2024-01-04 16:30 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Willem de Bruijn @ 2024-01-04 14:55 UTC (permalink / raw)
To: Thomas Lange, netdev, linux-kernel
Cc: willemdebruijn.kernel, jthinz, arnd, deepa.kernel, davem,
edumazet, kuba, pabeni, Thomas Lange
Thomas Lange wrote:
> Commit 9718475e6908 ("socket: Add SO_TIMESTAMPING_NEW") added the new
> socket option SO_TIMESTAMPING_NEW. However, it was never implemented in
> __sock_cmsg_send thus breaking SO_TIMESTAMPING cmsg for platforms using
> SO_TIMESTAMPING_NEW.
>
> Fixes: 9718475e6908 ("socket: Add SO_TIMESTAMPING_NEW")
> Link: https://lore.kernel.org/netdev/6a7281bf-bc4a-4f75-bb88-7011908ae471@app.fastmail.com/
> Signed-off-by: Thomas Lange <thomas@corelatus.se>
Reviewed-by: Willem de Bruijn <willemb@google.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH RESEND net] net: Implement missing SO_TIMESTAMPING_NEW cmsg support
2024-01-04 8:57 [PATCH RESEND net] net: Implement missing SO_TIMESTAMPING_NEW cmsg support Thomas Lange
2024-01-04 14:55 ` Willem de Bruijn
@ 2024-01-04 16:30 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-01-04 16:30 UTC (permalink / raw)
To: Thomas Lange
Cc: netdev, linux-kernel, willemdebruijn.kernel, jthinz, arnd,
deepa.kernel, davem, edumazet, kuba, pabeni
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Thu, 4 Jan 2024 09:57:44 +0100 you wrote:
> Commit 9718475e6908 ("socket: Add SO_TIMESTAMPING_NEW") added the new
> socket option SO_TIMESTAMPING_NEW. However, it was never implemented in
> __sock_cmsg_send thus breaking SO_TIMESTAMPING cmsg for platforms using
> SO_TIMESTAMPING_NEW.
>
> Fixes: 9718475e6908 ("socket: Add SO_TIMESTAMPING_NEW")
> Link: https://lore.kernel.org/netdev/6a7281bf-bc4a-4f75-bb88-7011908ae471@app.fastmail.com/
> Signed-off-by: Thomas Lange <thomas@corelatus.se>
>
> [...]
Here is the summary with links:
- [RESEND,net] net: Implement missing SO_TIMESTAMPING_NEW cmsg support
https://git.kernel.org/netdev/net/c/382a32018b74
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-01-04 16:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-04 8:57 [PATCH RESEND net] net: Implement missing SO_TIMESTAMPING_NEW cmsg support Thomas Lange
2024-01-04 14:55 ` Willem de Bruijn
2024-01-04 16:30 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®