mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 1/1] of: property: Make 'no port node found' output a debug message
@ 2024-01-17  8:32 Alexander Stein
  2024-01-19 23:12 ` Rob Herring
  0 siblings, 1 reply; 2+ messages in thread
From: Alexander Stein @ 2024-01-17  8:32 UTC (permalink / raw)
  To: Rob Herring, Frank Rowand; +Cc: Alexander Stein, devicetree, linux-kernel

There are cases where an unavailable port is not an error, making this
error message a false-positive. Since commit d56de8c9a17d8 ("usb: typec:
tcpm: try to get role switch from tcpc fwnode") the role switch is tried
on the port dev first and tcpc fwnode afterwards. If using the latter
bindings getting from port dev fails every time. The kernel log is flooded
with the messages like:
 OF: graph: no port node found in /soc@0/bus@42000000/i2c@42530000/usb-typec@50
Silence this message by making it a debug message.

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
 drivers/of/property.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/of/property.c b/drivers/of/property.c
index 641a40cf5cf34..a02a985c13baa 100644
--- a/drivers/of/property.c
+++ b/drivers/of/property.c
@@ -665,7 +665,7 @@ struct device_node *of_graph_get_next_endpoint(const struct device_node *parent,
 		of_node_put(node);
 
 		if (!port) {
-			pr_err("graph: no port node found in %pOF\n", parent);
+			pr_debug("graph: no port node found in %pOF\n", parent);
 			return NULL;
 		}
 	} else {
-- 
2.34.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH 1/1] of: property: Make 'no port node found' output a debug message
  2024-01-17  8:32 [PATCH 1/1] of: property: Make 'no port node found' output a debug message Alexander Stein
@ 2024-01-19 23:12 ` Rob Herring
  0 siblings, 0 replies; 2+ messages in thread
From: Rob Herring @ 2024-01-19 23:12 UTC (permalink / raw)
  To: Alexander Stein; +Cc: Frank Rowand, linux-kernel, Rob Herring, devicetree


On Wed, 17 Jan 2024 09:32:06 +0100, Alexander Stein wrote:
> There are cases where an unavailable port is not an error, making this
> error message a false-positive. Since commit d56de8c9a17d8 ("usb: typec:
> tcpm: try to get role switch from tcpc fwnode") the role switch is tried
> on the port dev first and tcpc fwnode afterwards. If using the latter
> bindings getting from port dev fails every time. The kernel log is flooded
> with the messages like:
>  OF: graph: no port node found in /soc@0/bus@42000000/i2c@42530000/usb-typec@50
> Silence this message by making it a debug message.
> 
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
>  drivers/of/property.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Applied, thanks!


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-01-19 23:12 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-17  8:32 [PATCH 1/1] of: property: Make 'no port node found' output a debug message Alexander Stein
2024-01-19 23:12 ` Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®