From: Rob Herring <robh@kernel.org>
To: Amrit Anand <quic_amrianan@quicinc.com>
Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
kernel@quicinc.com, devicetree@vger.kernel.org,
konrad.dybcio@linaro.org, andersson@kernel.org,
robh+dt@kernel.org, Elliot Berman <quic_eberman@quicinc.com>,
agross@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: hwinfo: Add Qualcomm's board-id types
Date: Sat, 20 Jan 2024 06:36:42 -0600 [thread overview]
Message-ID: <170575419908.2509092.7007610150543615061.robh@kernel.org> (raw)
In-Reply-To: <1705749649-4708-3-git-send-email-quic_amrianan@quicinc.com>
On Sat, 20 Jan 2024 16:50:49 +0530, Amrit Anand wrote:
> Qualcomm based DT uses two or three different identifiers. The SoC
> based idenfier which signifies chipset and the revision for those
> chipsets. The board based identifier is used to distinguish different
> boards (e.g. IDP, MTP) along with the different types of same boards.
> The PMIC attached to the board can also be used as a identifier for
> device tree.
>
> Signed-off-by: Elliot Berman <quic_eberman@quicinc.com>
> Signed-off-by: Amrit Anand <quic_amrianan@quicinc.com>
> ---
> .../devicetree/bindings/hwinfo/qcom,board-id.yaml | 86 ++++++++++++++++++++++
> include/dt-bindings/arm/qcom,ids.h | 68 +++++++++++++++--
> 2 files changed, 146 insertions(+), 8 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/hwinfo/qcom,board-id.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
./Documentation/devicetree/bindings/hwinfo/qcom,board-id.yaml:70:4: [warning] wrong indentation: expected 2 but found 3 (indentation)
dtschema/dtc warnings/errors:
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/1705749649-4708-3-git-send-email-quic_amrianan@quicinc.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2024-01-20 12:36 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-20 11:20 [PATCH 0/2] Add board-id support for multiple DT selection Amrit Anand
2024-01-20 11:20 ` [PATCH 1/2] dt-bindings: hwinfo: Introduce board-id Amrit Anand
2024-01-20 12:36 ` Rob Herring
2024-01-20 19:10 ` Trilok Soni
2024-01-22 10:10 ` Amrit Anand
2024-01-23 11:50 ` Krzysztof Kozlowski
2024-01-23 17:18 ` Conor Dooley
2024-01-23 18:51 ` Elliot Berman
2024-01-23 20:05 ` Trilok Soni
2024-01-24 12:44 ` Amrit Anand
2024-01-23 12:09 ` Krzysztof Kozlowski
2024-01-24 12:42 ` Amrit Anand
2024-01-25 10:40 ` Krzysztof Kozlowski
2024-01-24 15:00 ` Rob Herring
2024-01-20 11:20 ` [PATCH 2/2] dt-bindings: hwinfo: Add Qualcomm's board-id types Amrit Anand
2024-01-20 12:36 ` Rob Herring [this message]
2024-01-20 13:32 ` Konrad Dybcio
2024-01-22 10:07 ` Amrit Anand
2024-01-22 18:10 ` Elliot Berman
2024-01-22 19:27 ` Dmitry Baryshkov
2024-01-24 12:47 ` Amrit Anand
2024-01-21 2:05 ` kernel test robot
2024-01-22 18:12 ` Elliot Berman
2024-01-20 13:04 ` [PATCH 0/2] Add board-id support for multiple DT selection Konrad Dybcio
2024-01-22 17:50 ` Elliot Berman
2024-01-24 14:56 ` Rob Herring
2024-02-02 5:00 ` Amrit Anand
2024-02-14 12:56 ` Amrit Anand
2024-02-14 13:12 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170575419908.2509092.7007610150543615061.robh@kernel.org \
--to=robh@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@quicinc.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_amrianan@quicinc.com \
--cc=quic_eberman@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®