mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "tip-bot2 for Li Zhijian" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Li Zhijian <lizhijian@fujitsu.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: smp/core] kernel/cpu: Convert snprintf() to sysfs_emit()
Date: Fri, 26 Jan 2024 17:32:20 -0000	[thread overview]
Message-ID: <170629034015.398.17590522685927916785.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20240116045151.3940401-40-lizhijian@fujitsu.com>

The following commit has been merged into the smp/core branch of tip:

Commit-ID:     effe6d278e06f85289b6ada0402a6d16ebc149a5
Gitweb:        https://git.kernel.org/tip/effe6d278e06f85289b6ada0402a6d16ebc149a5
Author:        Li Zhijian <lizhijian@fujitsu.com>
AuthorDate:    Tue, 16 Jan 2024 12:51:51 +08:00
Committer:     Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Fri, 26 Jan 2024 18:25:16 +01:00

kernel/cpu: Convert snprintf() to sysfs_emit()

Per filesystems/sysfs.rst, show() should only use sysfs_emit()
or sysfs_emit_at() when formatting the value to be returned to user space.

coccinelle complains that there are still a couple of functions that use
snprintf(). Convert them to sysfs_emit().

No functional change intended.

Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/r/20240116045151.3940401-40-lizhijian@fujitsu.com

---
 kernel/cpu.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/cpu.c b/kernel/cpu.c
index f059375..ad7d0b0 100644
--- a/kernel/cpu.c
+++ b/kernel/cpu.c
@@ -3004,7 +3004,7 @@ static ssize_t control_show(struct device *dev,
 		return sysfs_emit(buf, "%d\n", cpu_smt_num_threads);
 #endif
 
-	return snprintf(buf, PAGE_SIZE - 2, "%s\n", state);
+	return sysfs_emit(buf, "%s\n", state);
 }
 
 static ssize_t control_store(struct device *dev, struct device_attribute *attr,
@@ -3017,7 +3017,7 @@ static DEVICE_ATTR_RW(control);
 static ssize_t active_show(struct device *dev,
 			   struct device_attribute *attr, char *buf)
 {
-	return snprintf(buf, PAGE_SIZE - 2, "%d\n", sched_smt_active());
+	return sysfs_emit(buf, "%d\n", sched_smt_active());
 }
 static DEVICE_ATTR_RO(active);
 

  reply	other threads:[~2024-01-26 17:32 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-16  4:10 [PATCH 00/42] Fix coccicheck warnings Li Zhijian
2024-01-16  4:10 ` [PATCH 01/42] coccinelle: device_attr_show.cocci: update description and warning message Li Zhijian
2024-01-18 20:26   ` Julia Lawall
2024-01-19  2:53     ` Zhijian Li (Fujitsu)
2024-01-19  6:25       ` Zhijian Li (Fujitsu)
2024-01-16  4:10 ` [PATCH 02/42] arch/arm/mm: Convert snprintf to sysfs_emit Li Zhijian
2024-01-16  4:51 ` [PATCH 03/42] arch/x86/events/amd: " Li Zhijian
2024-01-16  4:51   ` [PATCH 04/42] arch/x86/events/core: " Li Zhijian
2024-01-16  7:01     ` Adrian Hunter
2024-01-16  7:35       ` Zhijian Li (Fujitsu)
2024-01-16  4:51   ` [PATCH 05/42] arch/x86/events/intel: " Li Zhijian
2024-01-19 22:00     ` Namhyung Kim
2024-01-22  2:59       ` Zhijian Li (Fujitsu)
2024-01-16  4:51   ` [PATCH 06/42] drivers/bus/fsl-mc: " Li Zhijian
2024-01-16  4:51   ` [PATCH 07/42] drivers/edac: " Li Zhijian
2024-01-16  4:51   ` [PATCH 08/42] drivers/fsi: " Li Zhijian
2024-01-17 14:19     ` Eddie James
2024-01-16  4:51   ` [PATCH 09/42] drivers/hid/hid-lenovo: " Li Zhijian
2024-01-16  4:51   ` [PATCH 10/42] drivers/hid/hid-roccat-*: " Li Zhijian
2024-01-16  4:51   ` [PATCH 11/42] drivers/hid: " Li Zhijian
2024-02-24 16:59     ` Bruno Prémont
2024-02-28  9:56       ` Zhijian Li (Fujitsu)
2024-01-16  4:51   ` [PATCH 12/42] drivers/message/fusion: " Li Zhijian
2024-01-16  4:51   ` [PATCH 13/42] drivers/most: " Li Zhijian
2024-01-16  4:51   ` [PATCH 14/42] drivers/platform/mellanox: " Li Zhijian
2024-01-24 11:01     ` Ilpo Järvinen
2024-01-16  4:51   ` [PATCH 15/42] drivers/ptp: " Li Zhijian
2024-01-16  5:01     ` Rahul Rameshbabu
2024-01-16  5:52       ` Zhijian Li (Fujitsu)
2024-01-16 15:33     ` Jakub Kicinski
2024-01-17  5:39       ` Zhijian Li (Fujitsu)
2024-01-16  4:51   ` [PATCH 16/42] drivers/scsi/53c700: " Li Zhijian
2024-01-16  4:51   ` [PATCH 17/42] drivers/scsi/aacraid: " Li Zhijian
2024-01-16  4:51   ` [PATCH 18/42] drivers/scsi/aic94xx: " Li Zhijian
2024-01-16  4:51   ` [PATCH 19/42] drivers/scsi/arcmsr: " Li Zhijian
2024-01-16  4:51   ` [PATCH 20/42] drivers/scsi/be2iscsi: " Li Zhijian
2024-01-16  4:51   ` [PATCH 21/42] drivers/scsi/fcoe: " Li Zhijian
2024-01-16  4:51   ` [PATCH 22/42] drivers/scsi/fnic: " Li Zhijian
2024-01-18 23:24     ` Karan Tilak Kumar (kartilak)
2024-01-16  4:51   ` [PATCH 23/42] drivers/scsi/hpsa: " Li Zhijian
2024-01-16  4:51   ` [PATCH 24/42] drivers/scsi/hptiop: " Li Zhijian
2024-01-16  4:51   ` [PATCH 25/42] drivers/scsi/ibmvscsi: " Li Zhijian
2024-01-16 21:38     ` Tyrel Datwyler
2024-01-16  4:51   ` [PATCH 26/42] drivers/scsi/ibmvscsi_tgt: " Li Zhijian
2024-01-16 21:38     ` Tyrel Datwyler
2024-01-16  4:51   ` [PATCH 27/42] drivers/scsi/isci: " Li Zhijian
2024-01-16  7:24     ` Artur Paszkiewicz
2024-01-16  4:51   ` [PATCH 28/42] drivers/scsi/megaraid: " Li Zhijian
2024-01-16  4:51   ` [PATCH 29/42] drivers/scsi/mpt3sas: " Li Zhijian
2024-01-16  4:51   ` [PATCH 30/42] drivers/scsi/myrb: " Li Zhijian
2024-01-16  4:51   ` [PATCH 31/42] drivers/scsi/myrs: " Li Zhijian
2024-01-16  4:51   ` [PATCH 32/42] drivers/scsi/ncr53c8xx: " Li Zhijian
2024-01-16  4:51   ` [PATCH 33/42] drivers/scsi/pcmcia/sym53c500_cs: " Li Zhijian
2024-01-16  4:51   ` [PATCH 34/42] drivers/scsi/pm8001: " Li Zhijian
2024-01-16  5:52     ` Jinpu Wang
2024-01-16  4:51   ` [PATCH 35/42] drivers/scsi/pmcraid: " Li Zhijian
2024-01-16  4:51   ` [PATCH 36/42] drivers/scsi/qla4xxx/ql4_attr: " Li Zhijian
2024-01-16  4:51   ` [PATCH 37/42] drivers/scsi/scsi_sysfs: " Li Zhijian
2024-01-16  4:51   ` [PATCH 38/42] drivers/scsi/scsi_transport_fc: " Li Zhijian
2024-01-16  4:51   ` [PATCH 39/42] drivers/scsi/scsi_transport_sas: " Li Zhijian
2024-01-16  4:51   ` [PATCH 40/42] drivers/scsi/snic/snic_attrs: " Li Zhijian
2024-01-16  4:51   ` [PATCH 41/42] drivers/video/fbdev/uvesafb: " Li Zhijian
2024-01-16  4:51   ` [PATCH 42/42] kernel/cpu: " Li Zhijian
2024-01-26 17:32     ` tip-bot2 for Li Zhijian [this message]
2024-02-06  2:07 ` (subset) [PATCH 00/42] Fix coccicheck warnings Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=170629034015.398.17590522685927916785.tip-bot2@tip-bot2 \
    --to=tip-bot2@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=lizhijian@fujitsu.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®