From: "Zhijian Li (Fujitsu)" <lizhijian@fujitsu.com>
To: Adrian Hunter <adrian.hunter@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Ian Rogers <irogers@google.com>,
Thomas Gleixner <tglx@linutronix.de>,
Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"x86@kernel.org" <x86@kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
"linux-perf-users@vger.kernel.org"
<linux-perf-users@vger.kernel.org>
Subject: Re: [PATCH 04/42] arch/x86/events/core: Convert snprintf to sysfs_emit
Date: Tue, 16 Jan 2024 07:35:30 +0000 [thread overview]
Message-ID: <3f26722a-e838-4674-9617-87aea0a5d6ea@fujitsu.com> (raw)
In-Reply-To: <c9a3f5b7-4f81-4d24-835b-c365d7d61995@intel.com>
Adrian,
On 16/01/2024 15:01, Adrian Hunter wrote:
>> diff --git a/arch/x86/events/core.c b/arch/x86/events/core.c
>> index 40ad1425ffa2..52e5707be03b 100644
>> --- a/arch/x86/events/core.c
>> +++ b/arch/x86/events/core.c
>> @@ -1892,7 +1892,7 @@ ssize_t events_hybrid_sysfs_show(struct device *dev,
>> if (x86_pmu.hybrid_pmu[i].pmu_type & pmu->pmu_type) {
>> next_str = strchr(str, ';');
>> if (next_str)
>> - return snprintf(page, next_str - str + 1, "%s", str);
>> + return sysfs_emit(page, "%s", str);
> The intention seems to be to print only up to, and not including, the next ';',
> but sysfs_emit() is not going to do that.
Indeed, it intend to print a sub-string only, this conversion was wrong.
Let's leave it alone
next prev parent reply other threads:[~2024-01-16 7:36 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-16 4:10 [PATCH 00/42] Fix coccicheck warnings Li Zhijian
2024-01-16 4:10 ` [PATCH 01/42] coccinelle: device_attr_show.cocci: update description and warning message Li Zhijian
2024-01-18 20:26 ` Julia Lawall
2024-01-19 2:53 ` Zhijian Li (Fujitsu)
2024-01-19 6:25 ` Zhijian Li (Fujitsu)
2024-01-16 4:10 ` [PATCH 02/42] arch/arm/mm: Convert snprintf to sysfs_emit Li Zhijian
2024-01-16 4:51 ` [PATCH 03/42] arch/x86/events/amd: " Li Zhijian
2024-01-16 4:51 ` [PATCH 04/42] arch/x86/events/core: " Li Zhijian
2024-01-16 7:01 ` Adrian Hunter
2024-01-16 7:35 ` Zhijian Li (Fujitsu) [this message]
2024-01-16 4:51 ` [PATCH 05/42] arch/x86/events/intel: " Li Zhijian
2024-01-19 22:00 ` Namhyung Kim
2024-01-22 2:59 ` Zhijian Li (Fujitsu)
2024-01-16 4:51 ` [PATCH 06/42] drivers/bus/fsl-mc: " Li Zhijian
2024-01-16 4:51 ` [PATCH 07/42] drivers/edac: " Li Zhijian
2024-01-16 4:51 ` [PATCH 08/42] drivers/fsi: " Li Zhijian
2024-01-17 14:19 ` Eddie James
2024-01-16 4:51 ` [PATCH 09/42] drivers/hid/hid-lenovo: " Li Zhijian
2024-01-16 4:51 ` [PATCH 10/42] drivers/hid/hid-roccat-*: " Li Zhijian
2024-01-16 4:51 ` [PATCH 11/42] drivers/hid: " Li Zhijian
2024-02-24 16:59 ` Bruno Prémont
2024-02-28 9:56 ` Zhijian Li (Fujitsu)
2024-01-16 4:51 ` [PATCH 12/42] drivers/message/fusion: " Li Zhijian
2024-01-16 4:51 ` [PATCH 13/42] drivers/most: " Li Zhijian
2024-01-16 4:51 ` [PATCH 14/42] drivers/platform/mellanox: " Li Zhijian
2024-01-24 11:01 ` Ilpo Järvinen
2024-01-16 4:51 ` [PATCH 15/42] drivers/ptp: " Li Zhijian
2024-01-16 5:01 ` Rahul Rameshbabu
2024-01-16 5:52 ` Zhijian Li (Fujitsu)
2024-01-16 15:33 ` Jakub Kicinski
2024-01-17 5:39 ` Zhijian Li (Fujitsu)
2024-01-16 4:51 ` [PATCH 16/42] drivers/scsi/53c700: " Li Zhijian
2024-01-16 4:51 ` [PATCH 17/42] drivers/scsi/aacraid: " Li Zhijian
2024-01-16 4:51 ` [PATCH 18/42] drivers/scsi/aic94xx: " Li Zhijian
2024-01-16 4:51 ` [PATCH 19/42] drivers/scsi/arcmsr: " Li Zhijian
2024-01-16 4:51 ` [PATCH 20/42] drivers/scsi/be2iscsi: " Li Zhijian
2024-01-16 4:51 ` [PATCH 21/42] drivers/scsi/fcoe: " Li Zhijian
2024-01-16 4:51 ` [PATCH 22/42] drivers/scsi/fnic: " Li Zhijian
2024-01-18 23:24 ` Karan Tilak Kumar (kartilak)
2024-01-16 4:51 ` [PATCH 23/42] drivers/scsi/hpsa: " Li Zhijian
2024-01-16 4:51 ` [PATCH 24/42] drivers/scsi/hptiop: " Li Zhijian
2024-01-16 4:51 ` [PATCH 25/42] drivers/scsi/ibmvscsi: " Li Zhijian
2024-01-16 21:38 ` Tyrel Datwyler
2024-01-16 4:51 ` [PATCH 26/42] drivers/scsi/ibmvscsi_tgt: " Li Zhijian
2024-01-16 21:38 ` Tyrel Datwyler
2024-01-16 4:51 ` [PATCH 27/42] drivers/scsi/isci: " Li Zhijian
2024-01-16 7:24 ` Artur Paszkiewicz
2024-01-16 4:51 ` [PATCH 28/42] drivers/scsi/megaraid: " Li Zhijian
2024-01-16 4:51 ` [PATCH 29/42] drivers/scsi/mpt3sas: " Li Zhijian
2024-01-16 4:51 ` [PATCH 30/42] drivers/scsi/myrb: " Li Zhijian
2024-01-16 4:51 ` [PATCH 31/42] drivers/scsi/myrs: " Li Zhijian
2024-01-16 4:51 ` [PATCH 32/42] drivers/scsi/ncr53c8xx: " Li Zhijian
2024-01-16 4:51 ` [PATCH 33/42] drivers/scsi/pcmcia/sym53c500_cs: " Li Zhijian
2024-01-16 4:51 ` [PATCH 34/42] drivers/scsi/pm8001: " Li Zhijian
2024-01-16 5:52 ` Jinpu Wang
2024-01-16 4:51 ` [PATCH 35/42] drivers/scsi/pmcraid: " Li Zhijian
2024-01-16 4:51 ` [PATCH 36/42] drivers/scsi/qla4xxx/ql4_attr: " Li Zhijian
2024-01-16 4:51 ` [PATCH 37/42] drivers/scsi/scsi_sysfs: " Li Zhijian
2024-01-16 4:51 ` [PATCH 38/42] drivers/scsi/scsi_transport_fc: " Li Zhijian
2024-01-16 4:51 ` [PATCH 39/42] drivers/scsi/scsi_transport_sas: " Li Zhijian
2024-01-16 4:51 ` [PATCH 40/42] drivers/scsi/snic/snic_attrs: " Li Zhijian
2024-01-16 4:51 ` [PATCH 41/42] drivers/video/fbdev/uvesafb: " Li Zhijian
2024-01-16 4:51 ` [PATCH 42/42] kernel/cpu: " Li Zhijian
2024-01-26 17:32 ` [tip: smp/core] kernel/cpu: Convert snprintf() to sysfs_emit() tip-bot2 for Li Zhijian
2024-02-06 2:07 ` (subset) [PATCH 00/42] Fix coccicheck warnings Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f26722a-e838-4674-9617-87aea0a5d6ea@fujitsu.com \
--to=lizhijian@fujitsu.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®