* [PATCH] arm64: dts: qcom: sdm845-oneplus-common: improve DAI node naming
@ 2023-12-29 20:02 David Heidelberg
2023-12-29 21:41 ` Luca Weiss
2024-01-28 17:45 ` Bjorn Andersson
0 siblings, 2 replies; 4+ messages in thread
From: David Heidelberg @ 2023-12-29 20:02 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Caleb Connolly, Dylan Van Assche
Cc: David Heidelberg, linux-arm-msm, devicetree, linux-kernel
Make it easier to understand what the reg in those nodes is by using the
constants provided by qcom,q6dsp-lpass-ports.h.
Name nodes according to dt-binding expectations.
Fix for
```
arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dtb: service@4: dais: Unevaluated properties are not allowed ('qi2s@22', 'qi2s@23' were unexpected)
```
Fixes: b7b734286856 ("arm64: dts: qcom: sdm845-oneplus-*: add audio devices")
Signed-off-by: David Heidelberg <david@ixit.cz>
---
arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
index e821103d49c0..46e25c53829a 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
@@ -508,13 +508,13 @@ led-1 {
};
&q6afedai {
- qi2s@22 {
- reg = <22>;
+ dai@22 {
+ reg = <QUATERNARY_MI2S_RX>;
qcom,sd-lines = <1>;
};
- qi2s@23 {
- reg = <23>;
+ dai@23 {
+ reg = <QUATERNARY_MI2S_TX>;
qcom,sd-lines = <0>;
};
};
--
2.43.0
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: qcom: sdm845-oneplus-common: improve DAI node naming
2023-12-29 20:02 [PATCH] arm64: dts: qcom: sdm845-oneplus-common: improve DAI node naming David Heidelberg
@ 2023-12-29 21:41 ` Luca Weiss
2023-12-29 23:16 ` David Heidelberg
2024-01-28 17:45 ` Bjorn Andersson
1 sibling, 1 reply; 4+ messages in thread
From: Luca Weiss @ 2023-12-29 21:41 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Caleb Connolly, Dylan Van Assche, David Heidelberg
Cc: David Heidelberg, linux-arm-msm, devicetree, linux-kernel
On Freitag, 29. Dezember 2023 21:02:33 CET David Heidelberg wrote:
> Make it easier to understand what the reg in those nodes is by using the
> constants provided by qcom,q6dsp-lpass-ports.h.
>
> Name nodes according to dt-binding expectations.
>
> Fix for
> ```
> arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dtb: service@4: dais:
> Unevaluated properties are not allowed ('qi2s@22', 'qi2s@23' were
> unexpected) ```
>
> Fixes: b7b734286856 ("arm64: dts: qcom: sdm845-oneplus-*: add audio
> devices") Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
> arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
> b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi index
> e821103d49c0..46e25c53829a 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
> @@ -508,13 +508,13 @@ led-1 {
> };
>
> &q6afedai {
> - qi2s@22 {
> - reg = <22>;
> + dai@22 {
> + reg = <QUATERNARY_MI2S_RX>;
> qcom,sd-lines = <1>;
> };
>
> - qi2s@23 {
> - reg = <23>;
> + dai@23 {
> + reg = <QUATERNARY_MI2S_TX>;
I did the 'reg' part before, either I missed this file or it was added after I
made the patch.
https://lore.kernel.org/linux-arm-msm/20220603094710.64591-1-luca.weiss@fairphone.com/
But looks correct:
Reviewed-by: Luca Weiss <luca@z3ntu.xyz>
> qcom,sd-lines = <0>;
> };
> };
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: qcom: sdm845-oneplus-common: improve DAI node naming
2023-12-29 21:41 ` Luca Weiss
@ 2023-12-29 23:16 ` David Heidelberg
0 siblings, 0 replies; 4+ messages in thread
From: David Heidelberg @ 2023-12-29 23:16 UTC (permalink / raw)
To: Luca Weiss, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Caleb Connolly,
Dylan Van Assche
Cc: linux-arm-msm, devicetree, linux-kernel
Weird, I'm on next-20231222 so I assume it got missed somehow :(
Thanks!
On 29/12/2023 22:41, Luca Weiss wrote:
> On Freitag, 29. Dezember 2023 21:02:33 CET David Heidelberg wrote:
>> Make it easier to understand what the reg in those nodes is by using the
>> constants provided by qcom,q6dsp-lpass-ports.h.
>>
>> Name nodes according to dt-binding expectations.
>>
>> Fix for
>> ```
>> arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dtb: service@4: dais:
>> Unevaluated properties are not allowed ('qi2s@22', 'qi2s@23' were
>> unexpected) ```
>>
>> Fixes: b7b734286856 ("arm64: dts: qcom: sdm845-oneplus-*: add audio
>> devices") Signed-off-by: David Heidelberg <david@ixit.cz>
>> ---
>> arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
>> b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi index
>> e821103d49c0..46e25c53829a 100644
>> --- a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
>> @@ -508,13 +508,13 @@ led-1 {
>> };
>>
>> &q6afedai {
>> - qi2s@22 {
>> - reg = <22>;
>> + dai@22 {
>> + reg = <QUATERNARY_MI2S_RX>;
>> qcom,sd-lines = <1>;
>> };
>>
>> - qi2s@23 {
>> - reg = <23>;
>> + dai@23 {
>> + reg = <QUATERNARY_MI2S_TX>;
> I did the 'reg' part before, either I missed this file or it was added after I
> made the patch.
> https://lore.kernel.org/linux-arm-msm/20220603094710.64591-1-luca.weiss@fairphone.com/
>
> But looks correct:
>
> Reviewed-by: Luca Weiss <luca@z3ntu.xyz>
>
>
>> qcom,sd-lines = <0>;
>> };
>> };
>
>
>
--
David Heidelberg
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sdm845-oneplus-common: improve DAI node naming
2023-12-29 20:02 [PATCH] arm64: dts: qcom: sdm845-oneplus-common: improve DAI node naming David Heidelberg
2023-12-29 21:41 ` Luca Weiss
@ 2024-01-28 17:45 ` Bjorn Andersson
1 sibling, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2024-01-28 17:45 UTC (permalink / raw)
To: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Caleb Connolly, Dylan Van Assche, David Heidelberg
Cc: linux-arm-msm, devicetree, linux-kernel
On Fri, 29 Dec 2023 21:02:33 +0100, David Heidelberg wrote:
> Make it easier to understand what the reg in those nodes is by using the
> constants provided by qcom,q6dsp-lpass-ports.h.
>
> Name nodes according to dt-binding expectations.
>
> Fix for
> ```
> arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dtb: service@4: dais: Unevaluated properties are not allowed ('qi2s@22', 'qi2s@23' were unexpected)
> ```
>
> [...]
Applied, thanks!
[1/1] arm64: dts: qcom: sdm845-oneplus-common: improve DAI node naming
commit: 278d3807d304c90e59edb61aa7ed8a05e1e836bf
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-01-28 17:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-29 20:02 [PATCH] arm64: dts: qcom: sdm845-oneplus-common: improve DAI node naming David Heidelberg
2023-12-29 21:41 ` Luca Weiss
2023-12-29 23:16 ` David Heidelberg
2024-01-28 17:45 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®