* [PATCH v2 1/1] Bluetooth: hci_qca: Set BDA quirk bit if fwnode exists in DT
2024-01-24 14:30 [PATCH v2 0/1] Bluetooth: hci_qca: add check to set HCI_QUIRK_USE_BDADDR_PROPERTY Janaki Ramaiah Thota
@ 2024-01-24 14:30 ` Janaki Ramaiah Thota
2024-02-02 19:10 ` [PATCH v2 0/1] Bluetooth: hci_qca: add check to set HCI_QUIRK_USE_BDADDR_PROPERTY patchwork-bot+bluetooth
1 sibling, 0 replies; 3+ messages in thread
From: Janaki Ramaiah Thota @ 2024-01-24 14:30 UTC (permalink / raw)
To: Marcel Holtmann, Luiz Augusto von Dentz, Balakrishna Godavarthi
Cc: quic_mohamull, quic_hbandi, linux-bluetooth, linux-kernel
BT adapter going into UNCONFIGURED state during BT turn ON when
devicetree has no local-bd-address node.
Bluetooth will not work out of the box on such devices, to avoid this
problem, added check to set HCI_QUIRK_USE_BDADDR_PROPERTY based on
local-bd-address node entry.
When this quirk is not set, the public Bluetooth address read by host
from controller though HCI Read BD Address command is
considered as valid.
Fixes: e668eb1e1578 ("Bluetooth: hci_core: Don't stop BT if the BD address missing in dts")
Signed-off-by: Janaki Ramaiah Thota <quic_janathot@quicinc.com>
---
drivers/bluetooth/hci_qca.c | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
index 94b8c406f0c0..06193546ebb6 100644
--- a/drivers/bluetooth/hci_qca.c
+++ b/drivers/bluetooth/hci_qca.c
@@ -7,6 +7,7 @@
*
* Copyright (C) 2007 Texas Instruments, Inc.
* Copyright (c) 2010, 2012, 2018 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved.
*
* Acknowledgements:
* This file is based on hci_ll.c, which was...
@@ -1904,7 +1905,17 @@ static int qca_setup(struct hci_uart *hu)
case QCA_WCN6750:
case QCA_WCN6855:
case QCA_WCN7850:
- set_bit(HCI_QUIRK_USE_BDADDR_PROPERTY, &hdev->quirks);
+
+ /* Set BDA quirk bit for reading BDA value from fwnode property
+ * only if that property exist in DT.
+ */
+ if (fwnode_property_present(dev_fwnode(hdev->dev.parent), "local-bd-address")) {
+ set_bit(HCI_QUIRK_USE_BDADDR_PROPERTY, &hdev->quirks);
+ bt_dev_info(hdev, "setting quirk bit to read BDA from fwnode later");
+ } else {
+ bt_dev_dbg(hdev, "local-bd-address` is not present in the devicetree so not setting quirk bit for BDA");
+ }
+
hci_set_aosp_capable(hdev);
ret = qca_read_soc_version(hdev, &ver, soc_type);
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2 0/1] Bluetooth: hci_qca: add check to set HCI_QUIRK_USE_BDADDR_PROPERTY
2024-01-24 14:30 [PATCH v2 0/1] Bluetooth: hci_qca: add check to set HCI_QUIRK_USE_BDADDR_PROPERTY Janaki Ramaiah Thota
2024-01-24 14:30 ` [PATCH v2 1/1] Bluetooth: hci_qca: Set BDA quirk bit if fwnode exists in DT Janaki Ramaiah Thota
@ 2024-02-02 19:10 ` patchwork-bot+bluetooth
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+bluetooth @ 2024-02-02 19:10 UTC (permalink / raw)
To: Janaki Ramaiah Thota
Cc: marcel, luiz.dentz, quic_bgodavar, quic_mohamull, quic_hbandi,
linux-bluetooth, linux-kernel
Hello:
This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:
On Wed, 24 Jan 2024 20:00:41 +0530 you wrote:
> Changes in v2:
> - Addressing comments from Paul Menzel
>
> Janaki Ramaiah Thota (1):
> Bluetooth: hci_qca: Set BDA quirk bit if fwnode exists in DT
>
> drivers/bluetooth/hci_qca.c | 13 ++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
Here is the summary with links:
- [v2,1/1] Bluetooth: hci_qca: Set BDA quirk bit if fwnode exists in DT
https://git.kernel.org/bluetooth/bluetooth-next/c/e6cc937460d9
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread