* [PATCH net-next] net: dsa: realtek: fix digital interface select macro for EXT0
@ 2024-02-12 21:34 Luiz Angelo Daros de Luca
2024-02-12 22:11 ` Alvin Šipraga
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Luiz Angelo Daros de Luca @ 2024-02-12 21:34 UTC (permalink / raw)
To: Linus Walleij, Alvin Šipraga, Andrew Lunn, Florian Fainelli,
Vladimir Oltean, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni
Cc: netdev, linux-kernel, Luiz Angelo Daros de Luca
While no supported devices currently utilize EXT0, the register reserves
the bits for an EXT0. EXT0 is utilized by devices from the generation
prior to rtl8365mb, such as those supported by the driver library
rtl8367b.
Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com>
---
drivers/net/dsa/realtek/rtl8365mb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/dsa/realtek/rtl8365mb.c b/drivers/net/dsa/realtek/rtl8365mb.c
index be56373e9473..12665a8a3412 100644
--- a/drivers/net/dsa/realtek/rtl8365mb.c
+++ b/drivers/net/dsa/realtek/rtl8365mb.c
@@ -209,10 +209,10 @@
#define RTL8365MB_EXT_PORT_MODE_100FX 13
/* External interface mode configuration registers 0~1 */
-#define RTL8365MB_DIGITAL_INTERFACE_SELECT_REG0 0x1305 /* EXT1 */
+#define RTL8365MB_DIGITAL_INTERFACE_SELECT_REG0 0x1305 /* EXT0,EXT1 */
#define RTL8365MB_DIGITAL_INTERFACE_SELECT_REG1 0x13C3 /* EXT2 */
#define RTL8365MB_DIGITAL_INTERFACE_SELECT_REG(_extint) \
- ((_extint) == 1 ? RTL8365MB_DIGITAL_INTERFACE_SELECT_REG0 : \
+ ((_extint) <= 1 ? RTL8365MB_DIGITAL_INTERFACE_SELECT_REG0 : \
(_extint) == 2 ? RTL8365MB_DIGITAL_INTERFACE_SELECT_REG1 : \
0x0)
#define RTL8365MB_DIGITAL_INTERFACE_SELECT_MODE_MASK(_extint) \
---
base-commit: 0f37666d87d2dea42ec21776c3d562b7cbd71612
change-id: 20240212-realtek-fix_ext0-804aa3272a76
Best regards,
--
Luiz Angelo Daros de Luca <luizluca@gmail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net-next] net: dsa: realtek: fix digital interface select macro for EXT0
2024-02-12 21:34 [PATCH net-next] net: dsa: realtek: fix digital interface select macro for EXT0 Luiz Angelo Daros de Luca
@ 2024-02-12 22:11 ` Alvin Šipraga
2024-02-12 22:50 ` Linus Walleij
2024-02-14 3:20 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Alvin Šipraga @ 2024-02-12 22:11 UTC (permalink / raw)
To: Luiz Angelo Daros de Luca
Cc: Linus Walleij, Andrew Lunn, Florian Fainelli, Vladimir Oltean,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
netdev, linux-kernel
On Mon, Feb 12, 2024 at 06:34:33PM -0300, Luiz Angelo Daros de Luca wrote:
> While no supported devices currently utilize EXT0, the register reserves
> the bits for an EXT0. EXT0 is utilized by devices from the generation
> prior to rtl8365mb, such as those supported by the driver library
> rtl8367b.
>
> Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com>
> ---
Reviewed-by: Alvin Šipraga <alsi@bang-olufsen.dk>
> drivers/net/dsa/realtek/rtl8365mb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/dsa/realtek/rtl8365mb.c b/drivers/net/dsa/realtek/rtl8365mb.c
> index be56373e9473..12665a8a3412 100644
> --- a/drivers/net/dsa/realtek/rtl8365mb.c
> +++ b/drivers/net/dsa/realtek/rtl8365mb.c
> @@ -209,10 +209,10 @@
> #define RTL8365MB_EXT_PORT_MODE_100FX 13
>
> /* External interface mode configuration registers 0~1 */
> -#define RTL8365MB_DIGITAL_INTERFACE_SELECT_REG0 0x1305 /* EXT1 */
> +#define RTL8365MB_DIGITAL_INTERFACE_SELECT_REG0 0x1305 /* EXT0,EXT1 */
> #define RTL8365MB_DIGITAL_INTERFACE_SELECT_REG1 0x13C3 /* EXT2 */
> #define RTL8365MB_DIGITAL_INTERFACE_SELECT_REG(_extint) \
> - ((_extint) == 1 ? RTL8365MB_DIGITAL_INTERFACE_SELECT_REG0 : \
> + ((_extint) <= 1 ? RTL8365MB_DIGITAL_INTERFACE_SELECT_REG0 : \
> (_extint) == 2 ? RTL8365MB_DIGITAL_INTERFACE_SELECT_REG1 : \
> 0x0)
> #define RTL8365MB_DIGITAL_INTERFACE_SELECT_MODE_MASK(_extint) \
>
> ---
> base-commit: 0f37666d87d2dea42ec21776c3d562b7cbd71612
> change-id: 20240212-realtek-fix_ext0-804aa3272a76
>
> Best regards,
> --
> Luiz Angelo Daros de Luca <luizluca@gmail.com>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] net: dsa: realtek: fix digital interface select macro for EXT0
2024-02-12 21:34 [PATCH net-next] net: dsa: realtek: fix digital interface select macro for EXT0 Luiz Angelo Daros de Luca
2024-02-12 22:11 ` Alvin Šipraga
@ 2024-02-12 22:50 ` Linus Walleij
2024-02-14 3:20 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2024-02-12 22:50 UTC (permalink / raw)
To: Luiz Angelo Daros de Luca
Cc: Alvin Šipraga, Andrew Lunn, Florian Fainelli,
Vladimir Oltean, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, netdev, linux-kernel
On Mon, Feb 12, 2024 at 10:34 PM Luiz Angelo Daros de Luca
<luizluca@gmail.com> wrote:
> While no supported devices currently utilize EXT0, the register reserves
> the bits for an EXT0. EXT0 is utilized by devices from the generation
> prior to rtl8365mb, such as those supported by the driver library
> rtl8367b.
>
> Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] net: dsa: realtek: fix digital interface select macro for EXT0
2024-02-12 21:34 [PATCH net-next] net: dsa: realtek: fix digital interface select macro for EXT0 Luiz Angelo Daros de Luca
2024-02-12 22:11 ` Alvin Šipraga
2024-02-12 22:50 ` Linus Walleij
@ 2024-02-14 3:20 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-02-14 3:20 UTC (permalink / raw)
To: Luiz Angelo Daros de Luca
Cc: linus.walleij, alsi, andrew, f.fainelli, olteanv, davem,
edumazet, kuba, pabeni, netdev, linux-kernel
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Mon, 12 Feb 2024 18:34:33 -0300 you wrote:
> While no supported devices currently utilize EXT0, the register reserves
> the bits for an EXT0. EXT0 is utilized by devices from the generation
> prior to rtl8365mb, such as those supported by the driver library
> rtl8367b.
>
> Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com>
>
> [...]
Here is the summary with links:
- [net-next] net: dsa: realtek: fix digital interface select macro for EXT0
https://git.kernel.org/netdev/net-next/c/32e4a5447ed9
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-02-14 3:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-12 21:34 [PATCH net-next] net: dsa: realtek: fix digital interface select macro for EXT0 Luiz Angelo Daros de Luca
2024-02-12 22:11 ` Alvin Šipraga
2024-02-12 22:50 ` Linus Walleij
2024-02-14 3:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®