mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v3] ARM: dts: qcom: msm8974: correct qfprom node size
@ 2024-02-10 16:45 Luca Weiss
  2024-02-12 11:09 ` Konrad Dybcio
  2024-02-14 17:57 ` Bjorn Andersson
  0 siblings, 2 replies; 3+ messages in thread
From: Luca Weiss @ 2024-02-10 16:45 UTC (permalink / raw)
  To: ~postmarketos/upstreaming, phone-devel, Andy Gross,
	Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Eduardo Valentin, Conor Dooley, Rajendra Nayak
  Cc: Rob Herring, Andy Gross, linux-arm-msm, devicetree, linux-kernel,
	Craig Tatlor, Luca Weiss

From: Craig Tatlor <ctatlor97@gmail.com>

The qfprom actually is bigger than 0x1000, so adjust the reg.

Note that the non-ECC-corrected qfprom can be found at 0xfc4b8000
(-0x4000). The current reg points to the ECC-corrected qfprom block
which should have equivalent values at all offsets compared to the
non-corrected version.

[luca@z3ntu.xyz: extract to standalone patch and adjust for review
comments]

Fixes: c59ffb519357 ("arm: dts: msm8974: Add thermal zones, tsens and qfprom nodes")
Signed-off-by: Craig Tatlor <ctatlor97@gmail.com>
Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
---
Changes in v3:
- Update size from 0x3000 to 0x2100 (Dmitry)
- Link to v2: https://lore.kernel.org/r/20230130-msm8974-qfprom-v2-1-3839cf41d9ee@z3ntu.xyz

Changes in v2:
- Keep base offset but expand reg from 0x1000 to 0x3000 (Konrad)
- Link to v1: https://lore.kernel.org/r/20230130-msm8974-qfprom-v1-1-975aa0e5e083@z3ntu.xyz
---
 arch/arm/boot/dts/qcom/qcom-msm8974.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/qcom/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom/qcom-msm8974.dtsi
index b1413983787c..083ab780ab7e 100644
--- a/arch/arm/boot/dts/qcom/qcom-msm8974.dtsi
+++ b/arch/arm/boot/dts/qcom/qcom-msm8974.dtsi
@@ -1234,7 +1234,7 @@ restart@fc4ab000 {
 
 		qfprom: qfprom@fc4bc000 {
 			compatible = "qcom,msm8974-qfprom", "qcom,qfprom";
-			reg = <0xfc4bc000 0x1000>;
+			reg = <0xfc4bc000 0x2100>;
 			#address-cells = <1>;
 			#size-cells = <1>;
 

---
base-commit: 54be6c6c5ae8e0d93a6c4641cb7528eb0b6ba478
change-id: 20230130-msm8974-qfprom-619c0e8f26eb

Best regards,
-- 
Luca Weiss <luca@z3ntu.xyz>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v3] ARM: dts: qcom: msm8974: correct qfprom node size
  2024-02-10 16:45 [PATCH v3] ARM: dts: qcom: msm8974: correct qfprom node size Luca Weiss
@ 2024-02-12 11:09 ` Konrad Dybcio
  2024-02-14 17:57 ` Bjorn Andersson
  1 sibling, 0 replies; 3+ messages in thread
From: Konrad Dybcio @ 2024-02-12 11:09 UTC (permalink / raw)
  To: Luca Weiss, ~postmarketos/upstreaming, phone-devel, Andy Gross,
	Bjorn Andersson, Rob Herring, Krzysztof Kozlowski,
	Eduardo Valentin, Conor Dooley, Rajendra Nayak
  Cc: Rob Herring, Andy Gross, linux-arm-msm, devicetree, linux-kernel,
	Craig Tatlor

On 10.02.2024 17:45, Luca Weiss wrote:
> From: Craig Tatlor <ctatlor97@gmail.com>
> 
> The qfprom actually is bigger than 0x1000, so adjust the reg.
> 
> Note that the non-ECC-corrected qfprom can be found at 0xfc4b8000
> (-0x4000). The current reg points to the ECC-corrected qfprom block
> which should have equivalent values at all offsets compared to the
> non-corrected version.
> 
> [luca@z3ntu.xyz: extract to standalone patch and adjust for review
> comments]
> 
> Fixes: c59ffb519357 ("arm: dts: msm8974: Add thermal zones, tsens and qfprom nodes")
> Signed-off-by: Craig Tatlor <ctatlor97@gmail.com>
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v3] ARM: dts: qcom: msm8974: correct qfprom node size
  2024-02-10 16:45 [PATCH v3] ARM: dts: qcom: msm8974: correct qfprom node size Luca Weiss
  2024-02-12 11:09 ` Konrad Dybcio
@ 2024-02-14 17:57 ` Bjorn Andersson
  1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2024-02-14 17:57 UTC (permalink / raw)
  To: ~postmarketos/upstreaming, phone-devel, Andy Gross,
	Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Eduardo Valentin, Conor Dooley, Rajendra Nayak, Luca Weiss
  Cc: Rob Herring, Andy Gross, linux-arm-msm, devicetree, linux-kernel,
	Craig Tatlor


On Sat, 10 Feb 2024 17:45:40 +0100, Luca Weiss wrote:
> The qfprom actually is bigger than 0x1000, so adjust the reg.
> 
> Note that the non-ECC-corrected qfprom can be found at 0xfc4b8000
> (-0x4000). The current reg points to the ECC-corrected qfprom block
> which should have equivalent values at all offsets compared to the
> non-corrected version.
> 
> [...]

Applied, thanks!

[1/1] ARM: dts: qcom: msm8974: correct qfprom node size
      commit: 724c4bf0e4bf81dba77736afb93964c986c3c123

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-02-14 17:57 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-10 16:45 [PATCH v3] ARM: dts: qcom: msm8974: correct qfprom node size Luca Weiss
2024-02-12 11:09 ` Konrad Dybcio
2024-02-14 17:57 ` Bjorn Andersson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®