* [PATCH 1/2] dt-bindings: leds: qcom-lpg: Drop redundant qcom,pm8550-pwm in if:then:
@ 2024-02-26 7:37 Krzysztof Kozlowski
2024-02-26 7:37 ` [PATCH 2/2] dt-bindings: leds: qcom-lpg: Narrow nvmem for other variants Krzysztof Kozlowski
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2024-02-26 7:37 UTC (permalink / raw)
To: Pavel Machek, Lee Jones, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Bjorn Andersson, linux-leds, devicetree,
linux-kernel
Cc: Krzysztof Kozlowski
"qcom,pm8550-pwm" is compatible with "qcom,pm8350c-pwm" (latter used as
fallback), thus it is enough for the "if:then:" clause to check for the
presence of the fallback "qcom,pm8350c-pwm".
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml b/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
index 6649ca2ec805..699db7995dd5 100644
--- a/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
+++ b/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
@@ -141,13 +141,13 @@ allOf:
maxItems: 1
nvmem-names:
maxItems: 1
+
- if:
properties:
compatible:
contains:
enum:
- qcom,pm8350c-pwm
- - qcom,pm8550-pwm
then:
properties:
nvmem:
--
2.34.1
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH 2/2] dt-bindings: leds: qcom-lpg: Narrow nvmem for other variants
2024-02-26 7:37 [PATCH 1/2] dt-bindings: leds: qcom-lpg: Drop redundant qcom,pm8550-pwm in if:then: Krzysztof Kozlowski
@ 2024-02-26 7:37 ` Krzysztof Kozlowski
2024-02-27 3:47 ` Rob Herring
2024-02-27 3:47 ` [PATCH 1/2] dt-bindings: leds: qcom-lpg: Drop redundant qcom,pm8550-pwm in if:then: Rob Herring
2024-02-29 17:32 ` Lee Jones
2 siblings, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2024-02-26 7:37 UTC (permalink / raw)
To: Pavel Machek, Lee Jones, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Bjorn Andersson, linux-leds, devicetree,
linux-kernel
Cc: Krzysztof Kozlowski
Only few variants support PPG and store LPG per-channel data and pattern
in SDAM modules. Disallow the nvmem for other variants to make the
binding precise.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../bindings/leds/leds-qcom-lpg.yaml | 20 +++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml b/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
index 699db7995dd5..54a428d3d46f 100644
--- a/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
+++ b/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
@@ -130,6 +130,26 @@ required:
additionalProperties: false
allOf:
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - qcom,pm660l-lpg
+ - qcom,pm8150b-lpg
+ - qcom,pm8150l-lpg
+ - qcom,pm8916-pwm
+ - qcom,pm8941-lpg
+ - qcom,pm8994-lpg
+ - qcom,pmc8180c-lpg
+ - qcom,pmi8994-lpg
+ - qcom,pmi8998-lpg
+ - qcom,pmk8550-pwm
+ then:
+ properties:
+ nvmem: false
+ nvmem-names: false
+
- if:
properties:
compatible:
--
2.34.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 2/2] dt-bindings: leds: qcom-lpg: Narrow nvmem for other variants
2024-02-26 7:37 ` [PATCH 2/2] dt-bindings: leds: qcom-lpg: Narrow nvmem for other variants Krzysztof Kozlowski
@ 2024-02-27 3:47 ` Rob Herring
0 siblings, 0 replies; 5+ messages in thread
From: Rob Herring @ 2024-02-27 3:47 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: linux-leds, Pavel Machek, Bjorn Andersson, Krzysztof Kozlowski,
linux-kernel, Lee Jones, Conor Dooley, devicetree
On Mon, 26 Feb 2024 08:37:13 +0100, Krzysztof Kozlowski wrote:
> Only few variants support PPG and store LPG per-channel data and pattern
> in SDAM modules. Disallow the nvmem for other variants to make the
> binding precise.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../bindings/leds/leds-qcom-lpg.yaml | 20 +++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] dt-bindings: leds: qcom-lpg: Drop redundant qcom,pm8550-pwm in if:then:
2024-02-26 7:37 [PATCH 1/2] dt-bindings: leds: qcom-lpg: Drop redundant qcom,pm8550-pwm in if:then: Krzysztof Kozlowski
2024-02-26 7:37 ` [PATCH 2/2] dt-bindings: leds: qcom-lpg: Narrow nvmem for other variants Krzysztof Kozlowski
@ 2024-02-27 3:47 ` Rob Herring
2024-02-29 17:32 ` Lee Jones
2 siblings, 0 replies; 5+ messages in thread
From: Rob Herring @ 2024-02-27 3:47 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: linux-kernel, Bjorn Andersson, Lee Jones, linux-leds,
Conor Dooley, Pavel Machek, Krzysztof Kozlowski, devicetree
On Mon, 26 Feb 2024 08:37:12 +0100, Krzysztof Kozlowski wrote:
> "qcom,pm8550-pwm" is compatible with "qcom,pm8350c-pwm" (latter used as
> fallback), thus it is enough for the "if:then:" clause to check for the
> presence of the fallback "qcom,pm8350c-pwm".
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] dt-bindings: leds: qcom-lpg: Drop redundant qcom,pm8550-pwm in if:then:
2024-02-26 7:37 [PATCH 1/2] dt-bindings: leds: qcom-lpg: Drop redundant qcom,pm8550-pwm in if:then: Krzysztof Kozlowski
2024-02-26 7:37 ` [PATCH 2/2] dt-bindings: leds: qcom-lpg: Narrow nvmem for other variants Krzysztof Kozlowski
2024-02-27 3:47 ` [PATCH 1/2] dt-bindings: leds: qcom-lpg: Drop redundant qcom,pm8550-pwm in if:then: Rob Herring
@ 2024-02-29 17:32 ` Lee Jones
2 siblings, 0 replies; 5+ messages in thread
From: Lee Jones @ 2024-02-29 17:32 UTC (permalink / raw)
To: Pavel Machek, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Bjorn Andersson, linux-leds, devicetree, linux-kernel,
Krzysztof Kozlowski
On Mon, 26 Feb 2024 08:37:12 +0100, Krzysztof Kozlowski wrote:
> "qcom,pm8550-pwm" is compatible with "qcom,pm8350c-pwm" (latter used as
> fallback), thus it is enough for the "if:then:" clause to check for the
> presence of the fallback "qcom,pm8350c-pwm".
>
>
Applied, thanks!
[1/2] dt-bindings: leds: qcom-lpg: Drop redundant qcom,pm8550-pwm in if:then:
commit: 3cc566d0a66dfcf929fb01154ac66e798106261f
[2/2] dt-bindings: leds: qcom-lpg: Narrow nvmem for other variants
commit: 8bebf994a972369e327b1d3e8fb1a43b25d0bd09
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-02-29 17:32 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-26 7:37 [PATCH 1/2] dt-bindings: leds: qcom-lpg: Drop redundant qcom,pm8550-pwm in if:then: Krzysztof Kozlowski
2024-02-26 7:37 ` [PATCH 2/2] dt-bindings: leds: qcom-lpg: Narrow nvmem for other variants Krzysztof Kozlowski
2024-02-27 3:47 ` Rob Herring
2024-02-27 3:47 ` [PATCH 1/2] dt-bindings: leds: qcom-lpg: Drop redundant qcom,pm8550-pwm in if:then: Rob Herring
2024-02-29 17:32 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®