* [PATCH] net: systemport: Omit superfluous error message in bcm_sysport_probe()
@ 2020-04-18 8:51 Tang Bin
2020-04-18 15:51 ` Florian Fainelli
2020-04-20 18:05 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Tang Bin @ 2020-04-18 8:51 UTC (permalink / raw)
To: f.fainelli, davem
Cc: bcm-kernel-feedback-list, netdev, linux-kernel, Tang Bin
In the function bcm_sysport_probe(), when get irq failed, the function
platform_get_irq() logs an error message, so remove redundant message
here.
Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
---
drivers/net/ethernet/broadcom/bcmsysport.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/broadcom/bcmsysport.c b/drivers/net/ethernet/broadcom/bcmsysport.c
index af7ce5c54..c99e5a3fa 100644
--- a/drivers/net/ethernet/broadcom/bcmsysport.c
+++ b/drivers/net/ethernet/broadcom/bcmsysport.c
@@ -2475,7 +2475,6 @@ static int bcm_sysport_probe(struct platform_device *pdev)
priv->wol_irq = platform_get_irq(pdev, 1);
}
if (priv->irq0 <= 0 || (priv->irq1 <= 0 && !priv->is_lite)) {
- dev_err(&pdev->dev, "invalid interrupts\n");
ret = -EINVAL;
goto err_free_netdev;
}
--
2.20.1.windows.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: systemport: Omit superfluous error message in bcm_sysport_probe()
2020-04-18 8:51 [PATCH] net: systemport: Omit superfluous error message in bcm_sysport_probe() Tang Bin
@ 2020-04-18 15:51 ` Florian Fainelli
2020-04-20 18:05 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Florian Fainelli @ 2020-04-18 15:51 UTC (permalink / raw)
To: Tang Bin, f.fainelli, davem
Cc: bcm-kernel-feedback-list, netdev, linux-kernel
On 4/18/2020 1:51 AM, Tang Bin wrote:
> In the function bcm_sysport_probe(), when get irq failed, the function
> platform_get_irq() logs an error message, so remove redundant message
> here.
>
> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: systemport: Omit superfluous error message in bcm_sysport_probe()
2020-04-18 8:51 [PATCH] net: systemport: Omit superfluous error message in bcm_sysport_probe() Tang Bin
2020-04-18 15:51 ` Florian Fainelli
@ 2020-04-20 18:05 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2020-04-20 18:05 UTC (permalink / raw)
To: tangbin; +Cc: f.fainelli, bcm-kernel-feedback-list, netdev, linux-kernel
From: Tang Bin <tangbin@cmss.chinamobile.com>
Date: Sat, 18 Apr 2020 16:51:06 +0800
> In the function bcm_sysport_probe(), when get irq failed, the function
> platform_get_irq() logs an error message, so remove redundant message
> here.
>
> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-20 18:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-18 8:51 [PATCH] net: systemport: Omit superfluous error message in bcm_sysport_probe() Tang Bin
2020-04-18 15:51 ` Florian Fainelli
2020-04-20 18:05 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®