* [PATCH] net: wan: fsl_qmc_hdlc: Fix module compilation
@ 2024-03-14 12:33 Herve Codina
2024-03-18 9:30 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Herve Codina @ 2024-03-14 12:33 UTC (permalink / raw)
To: Michael Ellerman, Vadim Fedorenko, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Herve Codina, Yury Norov,
Andy Shevchenko, Rasmus Villemoes
Cc: linux-kernel, netdev, linuxppc-dev, Andrew Lunn, Mark Brown,
Ratheesh Kannoth, Christophe Leroy, Thomas Petazzoni
The fsl_qmc_driver does not compile as module:
error: ‘qmc_hdlc_driver’ undeclared here (not in a function);
405 | MODULE_DEVICE_TABLE(of, qmc_hdlc_driver);
| ^~~~~~~~~~~~~~~
Fix the typo.
Fixes: b40f00ecd463 ("net: wan: Add support for QMC HDLC")
Reported-by: Michael Ellerman <mpe@ellerman.id.au>
Closes: https://lore.kernel.org/linux-kernel/87ttl93f7i.fsf@mail.lhotse/
Signed-off-by: Herve Codina <herve.codina@bootlin.com>
---
drivers/net/wan/fsl_qmc_hdlc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wan/fsl_qmc_hdlc.c b/drivers/net/wan/fsl_qmc_hdlc.c
index 960371df470a..f69b1f579a0c 100644
--- a/drivers/net/wan/fsl_qmc_hdlc.c
+++ b/drivers/net/wan/fsl_qmc_hdlc.c
@@ -780,7 +780,7 @@ static const struct of_device_id qmc_hdlc_id_table[] = {
{ .compatible = "fsl,qmc-hdlc" },
{} /* sentinel */
};
-MODULE_DEVICE_TABLE(of, qmc_hdlc_driver);
+MODULE_DEVICE_TABLE(of, qmc_hdlc_id_table);
static struct platform_driver qmc_hdlc_driver = {
.driver = {
--
2.44.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] net: wan: fsl_qmc_hdlc: Fix module compilation
2024-03-14 12:33 [PATCH] net: wan: fsl_qmc_hdlc: Fix module compilation Herve Codina
@ 2024-03-18 9:30 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-03-18 9:30 UTC (permalink / raw)
To: Herve Codina
Cc: mpe, vadim.fedorenko, davem, edumazet, kuba, pabeni, yury.norov,
andriy.shevchenko, linux, linux-kernel, netdev, linuxppc-dev,
andrew, broonie, rkannoth, christophe.leroy, thomas.petazzoni
Hello:
This patch was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:
On Thu, 14 Mar 2024 13:33:46 +0100 you wrote:
> The fsl_qmc_driver does not compile as module:
> error: ‘qmc_hdlc_driver’ undeclared here (not in a function);
> 405 | MODULE_DEVICE_TABLE(of, qmc_hdlc_driver);
> | ^~~~~~~~~~~~~~~
>
> Fix the typo.
>
> [...]
Here is the summary with links:
- net: wan: fsl_qmc_hdlc: Fix module compilation
https://git.kernel.org/netdev/net/c/badc9e33c795
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-03-18 9:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-14 12:33 [PATCH] net: wan: fsl_qmc_hdlc: Fix module compilation Herve Codina
2024-03-18 9:30 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome