From: Kalle Valo <kvalo@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Jeff Johnson <jjohnson@kernel.org>,
Brian Norris <briannorris@chromium.org>,
Ajay Singh <ajay.kathat@microchip.com>,
Claudiu Beznea <claudiu.beznea@tuxon.dev>,
linux-wireless@vger.kernel.org, ath10k@lists.infradead.org,
linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: Re: [3/6] wifi: rsi: sdio: simplify module initialization
Date: Fri, 5 Apr 2024 09:00:05 +0000 (UTC) [thread overview]
Message-ID: <171230760246.2149729.1844900006480308481.kvalo@kernel.org> (raw)
In-Reply-To: <20240329171019.63836-3-krzysztof.kozlowski@linaro.org>
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
> This driver's initialization functions do not perform any custom code,
> except printing messages. Printing messages on modules
> loading/unloading is discouraged because it pollutes the dmesg
> regardless whether user actually has this device. Core kernel code
> already gives tools to investigate whether module was loaded or not.
>
> Drop the printing messages which allows to replace open-coded
> module_sdio_driver().
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
4 patches applied to wireless-next.git, thanks.
73ec84df3469 wifi: rsi: sdio: simplify module initialization
718fcb7d7b3f wifi: wl1251: simplify module initialization
c33c93e9e96a wifi: wilc1000: replace open-coded module_sdio_driver()
170861bc0044 wifi: mwifiex: replace open-coded module_sdio_driver()
--
https://patchwork.kernel.org/project/linux-wireless/patch/20240329171019.63836-3-krzysztof.kozlowski@linaro.org/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2024-04-05 9:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-29 17:10 [PATCH 1/6] wifi: ath10k: " Krzysztof Kozlowski
2024-03-29 17:10 ` [PATCH 2/6] wifi: ath6kl: " Krzysztof Kozlowski
2024-04-04 10:13 ` Kalle Valo
2024-03-29 17:10 ` [PATCH 3/6] wifi: rsi: " Krzysztof Kozlowski
2024-04-05 9:00 ` Kalle Valo [this message]
2024-03-29 17:10 ` [PATCH 4/6] wifi: ti: wl1251: " Krzysztof Kozlowski
2024-03-29 17:10 ` [PATCH 5/6] wifi: microchip: wilc1000: replace open-coded module_sdio_driver() Krzysztof Kozlowski
2024-03-29 17:10 ` [PATCH 6/6] wifi: marvell: mwifiex: " Krzysztof Kozlowski
2024-03-31 20:26 ` Francesco Dolcini
2024-03-29 17:22 ` [PATCH 1/6] wifi: ath10k: sdio: simplify module initialization Jeff Johnson
2024-04-03 13:50 ` Kalle Valo
2024-04-03 13:55 ` Krzysztof Kozlowski
2024-04-03 14:02 ` Krzysztof Kozlowski
2024-04-03 14:25 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171230760246.2149729.1844900006480308481.kvalo@kernel.org \
--to=kvalo@kernel.org \
--cc=ajay.kathat@microchip.com \
--cc=ath10k@lists.infradead.org \
--cc=briannorris@chromium.org \
--cc=claudiu.beznea@tuxon.dev \
--cc=jjohnson@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®