From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Kalle Valo <kvalo@kernel.org>, Jeff Johnson <quic_jjohnson@quicinc.com>
Cc: Jeff Johnson <jjohnson@kernel.org>,
Brian Norris <briannorris@chromium.org>,
Ajay Singh <ajay.kathat@microchip.com>,
Claudiu Beznea <claudiu.beznea@tuxon.dev>,
linux-wireless@vger.kernel.org, ath10k@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] wifi: ath10k: sdio: simplify module initialization
Date: Wed, 3 Apr 2024 16:02:30 +0200 [thread overview]
Message-ID: <ec78df08-118b-4086-beec-9227b309595a@linaro.org> (raw)
In-Reply-To: <87jzle5zda.fsf@kernel.org>
On 03/04/2024 15:50, Kalle Valo wrote:
> Jeff Johnson <quic_jjohnson@quicinc.com> writes:
>
>> On 3/29/2024 10:10 AM, Krzysztof Kozlowski wrote:
>>> This driver's initialization functions do not perform any custom code,
>>> except printing messages. Printing messages on modules
>>> loading/unloading is discouraged because it pollutes the dmesg
>>> regardless whether user actually has this device. Core kernel code
>>> already gives tools to investigate whether module was loaded or not.
>>>
>>> Drop the printing messages which allows to replace open-coded
>>> module_sdio_driver().
>>>
>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
>> Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com>
>>
>>>
>>> ---
>>>
>>> FYI:
>>> I have ongoing patchset touching few lines above this patch chunk
>>> (sdio_driver) which might go via different tree. If that patchset is
>>> applied via different tree, it might result in a trivial conflict, but
>>> there is no dependency. They can go via separate trees (except that
>>> trivial conflict).
>>
>> I'll let Kalle respond if he'll take this through the ath tree vs letting you
>> take it through your tree
>
> I prefer to avoid conflicts as much as possible. In this patchset I'm
> not anticipating any conflicts with wireless trees, so if we can avoid
> any conflicts, please take this patchset via the other tree:
>
> Acked-by: Kalle Valo <kvalo@kernel.org>
>
> I'll drop this patchset from my queue. But if I should take these to
> wireless trees instead just let me know.
Just to clarify - only the first patch has possible conflict. The rest
should be fine. Can you pick up 2-6 patches from this set?
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-04-03 14:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-29 17:10 Krzysztof Kozlowski
2024-03-29 17:10 ` [PATCH 2/6] wifi: ath6kl: " Krzysztof Kozlowski
2024-04-04 10:13 ` Kalle Valo
2024-03-29 17:10 ` [PATCH 3/6] wifi: rsi: " Krzysztof Kozlowski
2024-04-05 9:00 ` [3/6] " Kalle Valo
2024-03-29 17:10 ` [PATCH 4/6] wifi: ti: wl1251: " Krzysztof Kozlowski
2024-03-29 17:10 ` [PATCH 5/6] wifi: microchip: wilc1000: replace open-coded module_sdio_driver() Krzysztof Kozlowski
2024-03-29 17:10 ` [PATCH 6/6] wifi: marvell: mwifiex: " Krzysztof Kozlowski
2024-03-31 20:26 ` Francesco Dolcini
2024-03-29 17:22 ` [PATCH 1/6] wifi: ath10k: sdio: simplify module initialization Jeff Johnson
2024-04-03 13:50 ` Kalle Valo
2024-04-03 13:55 ` Krzysztof Kozlowski
2024-04-03 14:02 ` Krzysztof Kozlowski [this message]
2024-04-03 14:25 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec78df08-118b-4086-beec-9227b309595a@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=ajay.kathat@microchip.com \
--cc=ath10k@lists.infradead.org \
--cc=briannorris@chromium.org \
--cc=claudiu.beznea@tuxon.dev \
--cc=jjohnson@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_jjohnson@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®